Fix InnerList::parameters visibility

Author: nyamsprod

CHANGELOG.md

@@ -11,6 +11,7 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 ### Fixed
 
 - **[BC Break]** `Item::value` method returns the Item (returns value can be `float|int|string|bool|ByteSequence|Token`).
+- `InnerList::parameters` is no longer accessible as a public readonly property.
 
 ### Deprecated
 

composer.json

@@ -30,7 +30,7 @@
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^v3.13.2",
         "httpwg/structured-field-tests": "*@dev",
-        "phpstan/phpstan": "^1.9.5",
+        "phpstan/phpstan": "^1.9.8",
         "phpstan/phpstan-strict-rules": "^1.4.4",
         "phpstan/phpstan-phpunit": "^1.3.3",
         "phpstan/phpstan-deprecation-rules": "^1.1.1",

src/InnerList.php

@@ -20,7 +20,7 @@ final class InnerList implements MemberList, ParameterAccess
     /** @var array<int, Item> */
     private array $members = [];
 
-    private function __construct(public readonly Parameters $parameters)
+    private function __construct(private readonly Parameters $parameters)
     {
     }
 

src/InnerListTest.php

@@ -22,13 +22,13 @@ public function it_can_be_instantiated_with_an_collection_of_item(): void
 
         self::assertSame($stringItem, $instance->get(0));
         self::assertTrue($instance->hasMembers());
-        self::assertTrue($instance->parameters->hasMembers());
+        self::assertTrue($instance->parameters()->hasMembers());
         self::assertEquals($arrayParams, iterator_to_array($instance));
 
         $instance->clear();
 
         self::assertFalse($instance->hasMembers());
-        self::assertTrue($instance->parameters->hasMembers());
+        self::assertTrue($instance->parameters()->hasMembers());
     }
 
     /** @test */
@@ -41,7 +41,7 @@ public function it_can_add_or_remove_members(): void
 
         self::assertCount(2, $instance);
         self::assertTrue($instance->has(1));
-        self::assertFalse($instance->parameters->hasMembers());
+        self::assertFalse($instance->parameters()->hasMembers());
 
         $instance->remove(1);
 
@@ -108,15 +108,15 @@ public function it_can_access_its_parameter_values(): void
     {
         $instance = InnerList::fromList([false], ['foo' => 'bar']);
 
-        self::assertSame('bar', $instance->parameters['foo']->value());
+        self::assertSame('bar', $instance->parameters()['foo']->value());
     }
 
     /** @test */
     public function it_fails_to_access_unknown_parameter_values(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        InnerList::fromList([false], ['foo' => 'bar'])->parameters['bar']->value();
+        InnerList::fromList([false], ['foo' => 'bar'])->parameters()['bar']->value();
     }
 
     /** @test */
@@ -125,8 +125,8 @@ public function it_successfully_parse_a_http_field(): void
         $instance = InnerList::fromHttpValue('("hello)world" 42 42.0;john=doe);foo="bar("');
 
         self::assertCount(3, $instance);
-        self::assertCount(1, $instance->parameters);
-        self::assertSame('bar(', $instance->parameters['foo']->value());
+        self::assertCount(1, $instance->parameters());
+        self::assertSame('bar(', $instance->parameters()['foo']->value());
         self::assertSame('hello)world', $instance->get(0)->value());
         self::assertSame(42, $instance->get(1)->value());
         self::assertSame(42.0, $instance->get(2)->value());