rename create into new named constructor

Author: nyamsprod

CHANGELOG.md

@@ -12,11 +12,13 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 - `Item` implements the `ValueAccess` interface;
 - `Item::toPair` to complement `Item::fromPair`;
 - `Item::fromDate` to improve and complete the Item Date public API;
+- `Item::new` to improve Item public API;
 - `Item::fromAssociative` to improve Item public API;
 - `Item::fromString` to improve Item public API;
 - `Value` internal class to improve Item public API;
 - `Token::toString` to return the string representation of the token.
 - `Parameters::new` and `Dictionary::new` to return a new and empty instance
+- `InnerList::new` and `InnerList::new` to return a new instance
 
 ### Fixed
 
@@ -32,9 +34,10 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 - **[BC Break]** `InnerList::fromAssociativeParameters` use `InnerList::fromAssociative` instead.
 - **[BC Break]** `Value` interface use a combination of `ValueAccess` **and** `ParameterAccess` instead.
 - **[BC Break]** `Token::value` is no longer public use `Token::toString` instead.
-- **[BC Break]** `Item::from` is removed use `Item::fromAssociative` instead.
+- **[BC Break]** `Item::from` is removed use `Item::fromAssociative` or `Item::new` instead.
 - **[BC Break]** `Parameters::create` is removed use `Parameters::new` instead.
-- **[BC Break]** `Dictionary::create` is removed use `Dictionary::new` instead.
+- **[BC Break]** `InnerList::from` is removed use `InnerList::new` instead.
+- **[BC Break]** `OuterList::create` is removed use `OuterList::new` instead.
 
 ## [0.8.0] - 2023-03-12
 

README.md

@@ -218,6 +218,7 @@ bare items (ie: item without parameters attached to them).
 ```php
 use Bakame\Http\StructuredFields\Item;
 
+Item::new(mixed $value): self;
 Item::fromDecodedByteSequence(Stringable|string $value): self;
 Item::fromEncodedByteSequence(Stringable|string $value): self;
 Item::fromToken(Stringable|string $value): self;
@@ -307,13 +308,13 @@ $map->remove(string ...$key): static;
 
 #### Lists
 
-To Create `OuterList` and `InnerList` instances you can use the `from` named constructor:
+To Create `OuterList` and `InnerList` instances you can use the `new` named constructor:
 
 ```php
 use Bakame\Http\StructuredFields\InnerList;
 use Bakame\Http\StructuredFields\Item;
 
-$list = InnerList::from(
+$list = InnerList::new(
     Item::fromDecodedByteSequence('Hello World'),
     42.0,
     42
@@ -329,7 +330,7 @@ Once again, builder methods exist on both classes to ease container construction
 use Bakame\Http\StructuredFields\InnerList;
 use Bakame\Http\StructuredFields\Item;
 
-$list = InnerList::from()
+$list = InnerList::new()
     ->unshift('42')
     ->push(42)
     ->insert(1, 42.0)

src/Dictionary.php

@@ -53,7 +53,7 @@ private static function filterMember(mixed $member): object
         return match (true) {
             $member instanceof ParameterAccess &&
             ($member instanceof MemberList || $member instanceof ValueAccess) => $member,
-            is_iterable($member) => InnerList::from(...$member),
+            is_iterable($member) => InnerList::new(...$member),
             default => Item::fromAssociative($member),
         };
     }

src/InnerList.php

@@ -63,7 +63,7 @@ public static function fromHttpValue(Stringable|string $httpValue): self
     /**
      * Returns a new instance.
      */
-    public static function from(StructuredField|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): self
+    public static function new(StructuredField|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): self
     {
         return new self(Parameters::new(), $members);
     }

src/InnerListTest.php

@@ -31,7 +31,7 @@ public function it_can_add_or_remove_members(): void
     {
         $stringItem = Item::fromAssociative('helloWorld');
         $booleanItem = Item::true();
-        $instance = InnerList::from($stringItem, $booleanItem);
+        $instance = InnerList::new($stringItem, $booleanItem);
 
         self::assertCount(2, $instance);
         self::assertTrue($instance->has(1));
@@ -61,7 +61,7 @@ public function it_can_add_or_remove_members(): void
     #[Test]
     public function it_can_unshift_insert_and_replace(): void
     {
-        $container = InnerList::from()
+        $container = InnerList::new()
             ->unshift('42')
             ->push(42)
             ->insert(1, 42.0)
@@ -76,7 +76,7 @@ public function it_can_unshift_insert_and_replace(): void
     #[Test]
     public function it_returns_the_same_object_if_nothing_is_changed(): void
     {
-        $container = InnerList::from(42, 'forty-two');
+        $container = InnerList::new(42, 'forty-two');
 
         $sameContainer = $container
             ->unshift()
@@ -91,21 +91,21 @@ public function it_fails_to_replace_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::from()->replace(0, ByteSequence::fromDecoded('Hello World'));
+        InnerList::new()->replace(0, ByteSequence::fromDecoded('Hello World'));
     }
 
     #[Test]
     public function it_fails_to_insert_at_an_invalid_index(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::from()->insert(3, ByteSequence::fromDecoded('Hello World'));
+        InnerList::new()->insert(3, ByteSequence::fromDecoded('Hello World'));
     }
 
     #[Test]
     public function it_fails_to_return_an_member_with_invalid_index(): void
     {
-        $instance = InnerList::from();
+        $instance = InnerList::new();
 
         self::assertFalse($instance->has(3));
 
@@ -128,7 +128,7 @@ public function it_fails_to_access_unknown_parameter_values(): void
     {
         $this->expectException(StructuredFieldError::class);
 
-        InnerList::from(false)->parameters()->get('bar')->value();
+        InnerList::new(false)->parameters()->get('bar')->value();
     }
 
     #[Test]
@@ -159,29 +159,29 @@ public function it_fails_to_insert_unknown_index_via_the_array_access_interface(
     {
         $this->expectException(StructuredFieldError::class);
 
-        InnerList::from()->insert(0, Item::fromAssociative(42.0));
+        InnerList::new()->insert(0, Item::fromAssociative(42.0));
     }
 
     #[Test]
     public function it_returns_the_same_object_if_no_member_is_removed(): void
     {
-        self::assertCount(0, InnerList::from()->remove(0));
+        self::assertCount(0, InnerList::new()->remove(0));
     }
 
     #[Test]
     public function it_fails_to_fetch_an_value_using_an_integer(): void
     {
         $this->expectException(InvalidOffset::class);
 
-        InnerList::from()->get('zero');
+        InnerList::new()->get('zero');
     }
 
     #[Test]
     public function it_can_access_the_item_value(): void
     {
         $token = Token::fromString('token');
         $input = ['foobar', 0, false, $token];
-        $structuredField = InnerList::from(...$input);
+        $structuredField = InnerList::new(...$input);
 
         self::assertFalse($structuredField->get(2)->value());
         self::assertEquals($token, $structuredField->get(-1)->value());
@@ -260,7 +260,7 @@ public function it_can_create_via_parameters_access_methods_a_new_object(): void
     #[Test]
     public function it_implements_the_array_access_interface(): void
     {
-        $structuredField = InnerList::from('foobar', 'foobar', 'zero', 0);
+        $structuredField = InnerList::new('foobar', 'foobar', 'zero', 0);
 
         self::assertInstanceOf(Item::class, $structuredField->get(0));
         self::assertInstanceOf(Item::class, $structuredField[0]);
@@ -273,22 +273,22 @@ public function it_forbids_removing_members_using_the_array_access_interface():
     {
         $this->expectException(LogicException::class);
 
-        unset(InnerList::from('foobar', 'foobar', 'zero', 0)[0]);
+        unset(InnerList::new('foobar', 'foobar', 'zero', 0)[0]);
     }
 
     #[Test]
     public function it_forbids_adding_members_using_the_array_access_interface(): void
     {
         $this->expectException(LogicException::class);
 
-        InnerList::from('foobar', 'foobar', 'zero', 0)[0] = Item::fromAssociative(false);
+        InnerList::new('foobar', 'foobar', 'zero', 0)[0] = Item::fromAssociative(false);
     }
 
 
     #[Test]
     public function it_can_returns_the_container_member_keys(): void
     {
-        $instance = InnerList::from();
+        $instance = InnerList::new();
 
         self::assertSame([], $instance->keys());
 
@@ -297,7 +297,7 @@ public function it_can_returns_the_container_member_keys(): void
 
         self::assertSame([0, 1], $newInstance->keys());
 
-        $container = InnerList::from()
+        $container = InnerList::new()
             ->unshift('42')
             ->push(42)
             ->insert(1, 42.0)

src/Item.php

@@ -89,6 +89,16 @@ public static function fromPair(array $pair): self
         return new self(new Value($pair[0]), $pair[1]);
     }
 
+    /**
+     * Returns a new bare instance from value.
+     *
+     * @throws SyntaxError If the value is not valid to create a Bare Item.
+     */
+    public static function new(mixed $value): self
+    {
+        return new self(new Value($value), Parameters::new());
+    }
+
     /**
      * Returns a new bare instance from value.
      */

src/ItemTest.php

@@ -77,7 +77,7 @@ public static function provideInvalidArguments(): iterable
     #[DataProvider('provideFrom1stArgument')]
     public function it_instantiate_many_types(ValueAccess|ByteSequence|Token|DateTimeInterface|Stringable|string|int|float|bool $value, string $expected): void
     {
-        self::assertSame($expected, Item::fromAssociative($value)->toHttpValue());
+        self::assertSame($expected, Item::new($value)->toHttpValue());
     }
 
     #[Test]

src/OuterList.php

@@ -46,15 +46,15 @@ private static function filterMember(mixed $member): object
     {
         return match (true) {
             $member instanceof ParameterAccess && ($member instanceof MemberList || $member instanceof ValueAccess) => $member,
-            is_iterable($member) => InnerList::from(...$member),
+            is_iterable($member) => InnerList::new(...$member),
             default => Item::fromAssociative($member),
         };
     }
 
     /**
      * @param SfMember|SfMemberInput ...$members
      */
-    public static function from(iterable|StructuredField|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): self
+    public static function new(iterable|StructuredField|Token|ByteSequence|DateTimeInterface|Stringable|string|int|float|bool ...$members): self
     {
         return new self(...$members);
     }
@@ -66,7 +66,7 @@ public static function from(iterable|StructuredField|Token|ByteSequence|DateTime
      */
     public static function fromHttpValue(Stringable|string $httpValue): self
     {
-        return self::from(...array_map(
+        return self::new(...array_map(
             fn (mixed $value) => is_array($value) ? InnerList::fromAssociative($value[0], $value[1]) : $value,
             Parser::parseList($httpValue)
         ));