Improve Item test suite

Author: nyamsprod

composer.json

@@ -55,15 +55,15 @@
         "test": [
             "@phpunit",
             "@phpstan",
-            "@phpcs",
-            "@benchmark"
+            "@phpcs"
         ]
     },
     "scripts-descriptions": {
         "phpstan": "Runs complete codebase static analysis",
         "phpunit": "Runs unit and functional testing",
         "phpcs": "Runs coding style testing",
         "phpcs:fix": "Fix coding style issues",
+        "benchmark": "Runs parser benchmark",
         "test": "Runs all tests"
     },
     "repositories": [

src/Dictionary.php

@@ -35,7 +35,7 @@ private function __construct(iterable $members = [])
     {
         $filteredMembers = [];
         foreach ($members as $key => $member) {
-            $filteredMembers[MapKey::fromString($key)->value] = self::filterMember($member);
+            $filteredMembers[MapKey::from($key)->value] = self::filterMember($member);
         }
 
         $this->members = $filteredMembers;

src/ItemTest.php

@@ -12,6 +12,9 @@
 use PHPUnit\Framework\Attributes\Test;
 use Stringable;
 
+/**
+ * @phpstan-import-type DataType from Value
+ */
 final class ItemTest extends StructuredFieldTestCase
 {
     /** @var array<string> */
@@ -28,19 +31,46 @@ final class ItemTest extends StructuredFieldTestCase
     ];
 
     #[Test]
-    public function it_fails_to_instantiate_a_decimal_too_big(): void
+    #[DataProvider('provideInvalidArguments')]
+    public function it_fails_to_instantiate_an_item(mixed $value): void
     {
         $this->expectException(SyntaxError::class);
 
-        Item::from(1_000_000_000_000.0);
+        Item::from($value);
     }
 
-    #[Test]
-    public function it_fails_to_instantiate_a_decimal_too_small(): void
+    /**
+     * @return iterable<string, array{value:mixed}>
+     */
+    public static function provideInvalidArguments(): iterable
     {
-        $this->expectException(SyntaxError::class);
+        yield 'if the decimal is too big' => [
+            'value' => 1_000_000_000_000.0,
+        ];
+
+        yield 'if the decimal is too small' => [
+            'value' => -1_000_000_000_000.0,
+        ];
+
+        yield 'if the integer is too big' => [
+            'value' => 1_000_000_000_000_000,
+        ];
 
-        Item::from(-1_000_000_000_000.0);
+        yield 'if the integer is too small' => [
+            'value' => -1_000_000_000_000_000,
+        ];
+
+        yield 'if the date is too much in the future' => [
+            'value' => new DateTime('@'. 1_000_000_000_000_000),
+        ];
+
+        yield 'if the date is too much in the past' => [
+            'value' => new DateTime('@'.-1_000_000_000_000_000),
+        ];
+
+        yield 'if the string contains invalud characters' => [
+            'value' => "\0foobar",
+        ];
     }
 
     #[Test]
@@ -91,22 +121,6 @@ public function __toString(): string
         ];
     }
 
-    #[Test]
-    public function it_fails_to_instantiate_a_integer_too_big(): void
-    {
-        $this->expectException(SyntaxError::class);
-
-        Item::from(1_000_000_000_000_000);
-    }
-
-    #[Test]
-    public function it_fails_to_instantiate_a_integer_too_small(): void
-    {
-        $this->expectException(SyntaxError::class);
-
-        Item::from(-1_000_000_000_000_000);
-    }
-
     #[Test]
     public function it_instantiates_a_token(): void
     {
@@ -133,14 +147,6 @@ public function it_fails_to_instantiate_an_invalid_date_format(): void
         Item::fromHttpValue('@112345.678');
     }
 
-    #[Test]
-    public function it_fails_to_instantiate_an_out_of_range_date_in_the_future(): void
-    {
-        $this->expectException(SyntaxError::class);
-
-        Item::from(new DateTime('@'. 1_000_000_000_000_000));
-    }
-
     #[Test]
     public function it_fails_to_instantiate_an_out_of_range_timestamp_in_the_future(): void
     {
@@ -149,14 +155,6 @@ public function it_fails_to_instantiate_an_out_of_range_timestamp_in_the_future(
         Item::fromTimestamp(1_000_000_000_000_000);
     }
 
-    #[Test]
-    public function it_fails_to_instantiate_an_out_of_range_date_in_the_past(): void
-    {
-        $this->expectException(SyntaxError::class);
-
-        Item::from(new DateTime('@'.-1_000_000_000_000_000));
-    }
-
     #[Test]
     public function it_fails_to_instantiate_an_out_of_range_timestamp_in_the_past(): void
     {
@@ -205,14 +203,6 @@ public function it_instantiates_a_string(): void
         self::assertSame('"foobar"', Item::from('foobar')->toHttpValue());
     }
 
-    #[Test]
-    public function it_fails_to_instantiate_an_invalid_string(): void
-    {
-        $this->expectException(SyntaxError::class);
-
-        Item::from("\0foobar");
-    }
-
     #[Test]
     #[DataProvider('itemTypeProvider')]
     public function it_can_tell_the_item_type(Item $item, Type $expectedType): void

src/MapKey.php

@@ -18,8 +18,12 @@ private function __construct(
     /**
      * @throws SyntaxError If the string is not a valid HTTP value field key
      */
-    public static function fromString(string $httpValue): self
+    public static function from(string|int $httpValue): self
     {
+        if (!is_string($httpValue)) {
+            throw new SyntaxError('The key must be a string; '.gettype($httpValue).' received.');
+        }
+
         $instance = self::fromStringBeginning($httpValue);
         if ($instance->value !== $httpValue) {
             throw new SyntaxError('No valid http value key could be extracted from "'.$httpValue.'".');

src/Parameters.php

@@ -33,7 +33,7 @@ private function __construct(iterable $members = [])
     {
         $filteredMembers = [];
         foreach ($members as $key => $member) {
-            $filteredMembers[MapKey::fromString($key)->value] = self::filterMember($member);
+            $filteredMembers[MapKey::from($key)->value] = self::filterMember($member);
         }
 
         $this->members = $filteredMembers;

src/ParametersTest.php

@@ -49,6 +49,14 @@ public function test_it_can_be_instantiated_with_key_value_pairs(): void
         );
     }
 
+    #[Test]
+    public function it_fails_to_instantiate_a_pair_with_the_associative_constructor(): void
+    {
+        $this->expectException(SyntaxError::class);
+
+        Parameters::fromAssociative([['a', 'b']]); // @phpstan-ignore-line
+    }
+
     #[Test]
     public function it_fails_to_instantiate_with_an_item_containing_already_parameters(): void
     {