optional paramters for fromPair is made mandatory

Author: nyamsprod

CHANGELOG.md

@@ -21,13 +21,15 @@ All Notable changes to `bakame/http-strucured-fields` will be documented in this
 
 - Improve annotation using `@phpstan-type`
 - `Value` internal class to improve Item public API;
+- **[BC Break]**  `::fromAssociative` and `::fromPair` the `$parameters` argument is now required;
 
 ### Deprecated
 
 - None
 
 ### Removed
 
+- **[BC Break]**  Remove `Stringable` automatically converted into a string type.
 - **[BC Break]** `InnerList::fromPairParameters` use `InnerList::fromPair` instead.
 - **[BC Break]** `InnerList::fromAssociativeParameters` use `InnerList::fromAssociative` instead.
 - **[BC Break]** `Value` interface use a combination of `ValueAccess` **and** `ParameterAccess` instead.

src/InnerList.php

@@ -71,13 +71,11 @@ public static function new(StructuredField|Token|ByteSequence|DateTimeInterface|
     /**
      * @param array{
      *     0:iterable<SfItemInput>,
-     *     1?:MemberOrderedMap<string, SfItem>|iterable<array{0:string, 1:SfItemInput}>
+     *     1:MemberOrderedMap<string, SfItem>|iterable<array{0:string, 1:SfItemInput}>
      * } $pair
      */
     public static function fromPair(array $pair): self
     {
-        $pair[1] = $pair[1] ?? [];
-
         if (!array_is_list($pair)) { /* @phpstan-ignore-line */
             throw new SyntaxError('The pair must be represented by an array as a list.');
         }

src/Item.php

@@ -34,6 +34,8 @@ private function __construct(
      * in compliance with RFC8941.
      *
      * @see https://www.rfc-editor.org/rfc/rfc8941.html#section-3.3
+     *
+     * @throws SyntaxError If the HTTP value can not be parsed
      */
     public static function fromHttpValue(Stringable|string $httpValue): self
     {
@@ -54,6 +56,8 @@ public static function fromHttpValue(Stringable|string $httpValue): self
      * Returns a new instance from a value type and an iterable of key-value parameters.
      *
      * @param iterable<string, SfItemInput> $parameters
+     *
+     * @throws SyntaxError If the value or the parameters are not valid
      */
     public static function fromAssociative(mixed $value, iterable $parameters): self
     {
@@ -67,13 +71,13 @@ public static function fromAssociative(mixed $value, iterable $parameters): self
     /**
      * @param array{
      *     0:SfItemInput,
-     *     1?:MemberOrderedMap<string, SfItem>|iterable<array{0:string, 1:SfItemInput}>
+     *     1:MemberOrderedMap<string, SfItem>|iterable<array{0:string, 1:SfItemInput}>
      * } $pair
+     *
+     * @throws SyntaxError If the pair or its content is not valid.
      */
     public static function fromPair(array $pair): self
     {
-        $pair[1] = $pair[1] ?? [];
-
         if (!array_is_list($pair)) { /* @phpstan-ignore-line */
             throw new SyntaxError('The pair must be represented by an array as a list.');
         }
@@ -92,11 +96,11 @@ public static function fromPair(array $pair): self
     /**
      * Returns a new bare instance from value.
      *
-     * @throws SyntaxError If the value is not valid to create a Bare Item.
+     * @throws SyntaxError If the value is not valid.
      */
     public static function new(mixed $value): self
     {
-        return new self(new Value($value), Parameters::new());
+        return self::fromValue(new Value($value));
     }
 
     /**
@@ -109,6 +113,8 @@ private static function fromValue(Value $value): self
 
     /**
      * Returns a new instance from a string.
+     *
+     * @throws SyntaxError if the string is invalid
      */
     public static function fromString(Stringable|string $value): self
     {
@@ -117,6 +123,8 @@ public static function fromString(Stringable|string $value): self
 
     /**
      * Returns a new instance from an encoded byte sequence and an iterable of key-value parameters.
+     *
+     * @throws SyntaxError if the sequence is invalid
      */
     public static function fromEncodedByteSequence(Stringable|string $value): self
     {
@@ -125,6 +133,8 @@ public static function fromEncodedByteSequence(Stringable|string $value): self
 
     /**
      * Returns a new instance from a decoded byte sequence and an iterable of key-value parameters.
+     *
+     * @throws SyntaxError if the sequence is invalid
      */
     public static function fromDecodedByteSequence(Stringable|string $value): self
     {
@@ -133,6 +143,8 @@ public static function fromDecodedByteSequence(Stringable|string $value): self
 
     /**
      * Returns a new instance from a Token and an iterable of key-value parameters.
+     *
+     * @throws SyntaxError if the token is invalid
      */
     public static function fromToken(Stringable|string $value): self
     {
@@ -141,6 +153,8 @@ public static function fromToken(Stringable|string $value): self
 
     /**
      * Returns a new instance from a timestamp and an iterable of key-value parameters.
+     *
+     * @throws SyntaxError if the timestamp value is not supported
      */
     public static function fromTimestamp(int $timestamp): self
     {

src/ItemTest.php

@@ -349,10 +349,8 @@ public function it_fails_to_access_unknown_parameter_values(): void
     public function it_can_create_an_item_from_a_array_of_pairs(): void
     {
         $instance1 = Item::new(Token::fromString('babayaga'));
-        $instance2 = Item::fromPair([Token::fromString('babayaga')]);
         $instance3 = Item::fromPair([Token::fromString('babayaga'), []]);
 
-        self::assertEquals($instance2, $instance1);
         self::assertEquals($instance3, $instance1);
     }
 

src/ValueAccess.php

@@ -28,6 +28,8 @@ public function type(): Type;
      * an instance that contains the specified value change.
      *
      * @param ValueAccess|SfTypeInput $value
+     *
+     * @throws SyntaxError If the value is invalid or not supported
      */
     public function withValue(mixed $value): static;
 }