Bugfix Parameters::toHttpValue

Author: nyamsprod

src/Parameters.php

@@ -99,7 +99,7 @@ public function keys(): array
         return array_keys($this->elements);
     }
 
-    public function getByKey(string $key): Item|InnerList|null
+    public function getByKey(string $key): Item
     {
         if (!array_key_exists($key, $this->elements)) {
             throw InvalidOffset::dueToKeyNotFound($key);
@@ -141,16 +141,22 @@ public function hasIndex(int $index): bool
 
     public function toHttpValue(): string
     {
-        $returnValue = '';
+        $returnValue = [];
 
         foreach ($this->elements as $key => $val) {
-            $returnValue .= ';'.$key;
+            if (!$val->parameters()->isEmpty()) {
+                throw new SyntaxError('the Item cannot be parameterized.');
+            }
+
+            $value = ';'.$key;
             if ($val->value() !== true) {
-                $returnValue .= '='.$val->toHttpValue();
+                $value .= '='.$val->toHttpValue();
             }
+
+            $returnValue[] = $value;
         }
 
-        return $returnValue;
+        return implode('', $returnValue);
     }
 
     public function set(string $key, Item|ByteSequence|Token|bool|int|float|string $element): void

src/ParametersTest.php

@@ -178,4 +178,16 @@ public function it_can_merge_without_argument_and_not_throw(): void
         $instance->merge();
         self::assertCount(1, $instance);
     }
+
+    /**
+     * @test
+     */
+    public function it_fails_if_internal_parameters_are_changed_illegally(): void
+    {
+        $this->expectException(SyntaxError::class);
+
+        $fields = Item::from('/terms', ['rel' => 'copyright', 'anchor' => '#foo']);
+        $fields->parameters()->getByKey('anchor')->parameters()->set('yolo', 42);
+        $fields->toHttpValue();
+    }
 }