npm test seems to hang indefinitely

[mtscout6]

I was trying to see if this would work in react-bootstrap against our downstream dependent react-router-bootstrap. I added react-router-bootstrap to the .dont-break file in the root of the react-bootstrap repo and ran ./node_modules/.bin/dont-break I get the following output and it has been hanging for an hour:

➜  react-bootstrap git:(dont-break) ✗ ./node_modules/.bin/dont-break
dont-break@0.3.0 - Checks if the current version of your package would break dependent projects
in folder /Users/smithm/dev/react-bootstrap
testing dependents [ 'react-router-bootstrap' ]
testing react-router-bootstrap
  installing react-router-bootstrap
installed into /tmp/react-bootstrap@0.23.0-against-react-router-bootstrap
installing dev dependencies /tmp/react-bootstrap@0.23.0-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap
  NPM install in current folder
restoring current directory /Users/smithm/dev/react-bootstrap
  npm test

Am I missing something?

[bahmutov]

Will try running today

[bahmutov]

Yup, times out. Something is wrong! Will investigate, need to stream the test output, rather than wait until the child process finishes

[kentcdodds]

Seeing this also :-( https://codeship.com/projects/85475/builds/6272691

[bahmutov]

Can you guys try again against dont-break@0.3.3 please? It streams test output / errors

[kentcdodds]

This is what I get now:

... more logs...


.

Finished in 1.249 seconds
1 test, 1 assertion, 0 failures

15:04:40.980 INFO - Executing: [delete session: 53459d8e-ca57-4e16-b8eb-7000010d6bce])
15:04:41.535 INFO - Done: [delete session: 53459d8e-ca57-4e16-b8eb-7000010d6bce]
[launcher] 0 instance(s) of WebDriver still running
[launcher] chrome #1 passed
tests work in /tmp/angular-formly@6.14.1-against-angular-formly-example/lib/node_modules/angular-formly-example
all dependents tested
PASS: Current version does not break dependents
restored folder /home/rof/src/github.com/formly-js/angular-formly
finishing with success? true



--------------------------------------------------------------------------------
This command didn't output anything for for a while, thus we stopped it.
If the error is on our end please inform us so we can help you to fix this.
--------------------------------------------------------------------------------

[kentcdodds]

Here's my command: dont-break -d angular-formly-example

[mtscout6]

Failed for me as well. Here's the output:

➜  react-bootstrap git:(dont-break) ./node_modules/.bin/dont-break
dont-break@0.3.3 - Checks if the current version of your package would break dependent projects
in folder /Users/smithm/dev/react-bootstrap
testing dependents
react-router-bootstrap
testing "react-router-bootstrap"
testing folder "/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap"
  installing react-router-bootstrap
npm WARN peerDependencies The peer dependency react-bootstrap@>=0.22.4 included from react-router-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react-router@>=0.13.1 included from react-router-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@0.13.x included from react-router will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm WARN peerDependencies The peer dependency react@>=0.13 included from react-bootstrap will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
react@0.13.3 /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react
└── envify@3.4.0 (through@2.3.7, jstransform@10.1.0)

react-bootstrap@0.23.4 /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-bootstrap
└── classnames@2.1.2

react-router@0.13.3 /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router
├── object-assign@2.1.1
└── qs@2.4.1

react-router-bootstrap@0.16.0 /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap
└── classnames@2.1.2
installed into /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap
installing dev dependencies /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap
  NPM install in current folder
npm WARN package.json react-router-bootstrap@0.16.0 license should be a valid SPDX license expression
npm WARN engine karma-cli@0.0.4: wanted: {"node":"~0.8 || ~0.10"} (current: {"node":"2.2.1","npm":"2.11.0"})
npm WARN prefer global karma-cli@0.0.4 should be installed with -g

> fsevents@0.3.6 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/babel/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  SOLINK_MODULE(target) Release/.node
  SOLINK_MODULE(target) Release/.node: Finished
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
  SOLINK_MODULE(target) Release/fse.node: Finished

> fsevents@0.3.6 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/karma/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  SOLINK_MODULE(target) Release/.node
  SOLINK_MODULE(target) Release/.node: Finished
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
  SOLINK_MODULE(target) Release/fse.node: Finished

> phantomjs@1.9.17 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/phantomjs
> node install.js

Download already available at /var/folders/rt/phr89yfj2fl206jtk0l86724th0_1v/T/phantomjs/phantomjs-1.9.8-macosx.zip
Extracting zip contents
Removing /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/phantomjs/lib/phantom
Copying extracted folder /var/folders/rt/phr89yfj2fl206jtk0l86724th0_1v/T/phantomjs/phantomjs-1.9.8-macosx.zip-extract-1434468235532/phantomjs-1.9.8-macosx -> /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/phantomjs/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/phantomjs/lib/phantom/bin/phantomjs

> ws@0.5.0 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/webpack-dev-server/node_modules/socket.io/node_modules/engine.io/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

> ws@0.4.31 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/webpack-dev-server/node_modules/socket.io-client/node_modules/engine.io-client/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

> fsevents@0.3.6 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/webpack/node_modules/watchpack/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  SOLINK_MODULE(target) Release/.node
  SOLINK_MODULE(target) Release/.node: Finished
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
  SOLINK_MODULE(target) Release/fse.node: Finished
npm WARN prefer global babel@5.5.8 should be installed with -g

> ws@0.4.32 install /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/ws
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o

> react-router-bootstrap@0.16.0 prepublish /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap
> npm run build


> react-router-bootstrap@0.16.0 build /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap
> babel src --out-dir=lib && webpack && COMPRESS=1 webpack

src doesn't exist

npm ERR! Darwin 14.3.0
npm ERR! argv "/usr/local/bin/iojs" "/usr/local/bin/npm" "run" "build"
npm ERR! node v2.2.1
npm ERR! npm  v2.11.0
npm ERR! code ELIFECYCLE
npm ERR! react-router-bootstrap@0.16.0 build: `babel src --out-dir=lib && webpack && COMPRESS=1 webpack`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the react-router-bootstrap@0.16.0 build script 'babel src --out-dir=lib && webpack && COMPRESS=1 webpack'.
npm ERR! This is most likely a problem with the react-router-bootstrap package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel src --out-dir=lib && webpack && COMPRESS=1 webpack
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-router-bootstrap
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/npm-debug.log

npm ERR! Darwin 14.3.0
npm ERR! argv "/usr/local/bin/iojs" "/usr/local/bin/npm" "install"
npm ERR! node v2.2.1
npm ERR! npm  v2.11.0
npm ERR! code ELIFECYCLE
npm ERR! react-router-bootstrap@0.16.0 prepublish: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the react-router-bootstrap@0.16.0 prepublish script 'npm run build'.
npm ERR! This is most likely a problem with the react-router-bootstrap package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-router-bootstrap
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/npm-debug.log
npm returned 1
errors:
npm WARN package.json react-router-bootstrap@0.16.0 license should be a valid SPDX license expression
npm WARN engine karma-cli@0.0.4: wanted: {"node":"~0.8 || ~0.10"} (current: {"node":"2.2.1","npm":"2.11.0"})
npm WARN prefer global karma-cli@0.0.4 should be installed with -g
npm WARN prefer global babel@5.5.8 should be installed with -g
src doesn't exist

npm ERR! Darwin 14.3.0
npm ERR! argv "/usr/local/bin/iojs" "/usr/local/bin/npm" "run" "build"
npm ERR! node v2.2.1
npm ERR! npm  v2.11.0
npm ERR! code ELIFECYCLE
npm ERR! react-router-bootstrap@0.16.0 build: `babel src --out-dir=lib && webpack && COMPRESS=1 webpack`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the react-router-bootstrap@0.16.0 build script 'babel src --out-dir=lib && webpack && COMPRESS=1 webpack'.
npm ERR! This is most likely a problem with the react-router-bootstrap package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel src --out-dir=lib && webpack && COMPRESS=1 webpack
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-router-bootstrap
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/npm-debug.log

npm ERR! Darwin 14.3.0
npm ERR! argv "/usr/local/bin/iojs" "/usr/local/bin/npm" "install"
npm ERR! node v2.2.1
npm ERR! npm  v2.11.0
npm ERR! code ELIFECYCLE
npm ERR! react-router-bootstrap@0.16.0 prepublish: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the react-router-bootstrap@0.16.0 prepublish script 'npm run build'.
npm ERR! This is most likely a problem with the react-router-bootstrap package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get their info via:
npm ERR!     npm owner ls react-router-bootstrap
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/npm-debug.log

Could not install dependencies in /tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap
{ code: 1,
  errors: 'npm WARN package.json react-router-bootstrap@0.16.0 license should be a valid SPDX license expression\nnpm WARN engine karma-cli@0.0.4: wanted: {"node":"~0.8 || ~0.10"} (current: {"node":"2.2.1","npm":"2.11.0"})\nnpm WARN prefer global karma-cli@0.0.4 should be installed with -g\nnpm WARN prefer global babel@5.5.8 should be installed with -g\nsrc doesn\'t exist\n\nnpm ERR! Darwin 14.3.0\nnpm ERR! argv "/usr/local/bin/iojs" "/usr/local/bin/npm" "run" "build"\nnpm ERR! node v2.2.1\nnpm ERR! npm  v2.11.0\nnpm ERR! code ELIFECYCLE\nnpm ERR! react-router-bootstrap@0.16.0 build: `babel src --out-dir=lib && webpack && COMPRESS=1 webpack`\nnpm ERR! Exit status 2\nnpm ERR! \nnpm ERR! Failed at the react-router-bootstrap@0.16.0 build script \'babel src --out-dir=lib && webpack && COMPRESS=1 webpack\'.\nnpm ERR! This is most likely a problem with the react-router-bootstrap package,\nnpm ERR! not with npm itself.\nnpm ERR! Tell the author that this fails on your system:\nnpm ERR!     babel src --out-dir=lib && webpack && COMPRESS=1 webpack\nnpm ERR! You can get their info via:\nnpm ERR!     npm owner ls react-router-bootstrap\nnpm ERR! There is likely additional logging output above.\n\nnpm ERR! Please include the following file with any support request:\nnpm ERR!     /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/npm-debug.log\n\nnpm ERR! Darwin 14.3.0\nnpm ERR! argv "/usr/local/bin/iojs" "/usr/local/bin/npm" "install"\nnpm ERR! node v2.2.1\nnpm ERR! npm  v2.11.0\nnpm ERR! code ELIFECYCLE\nnpm ERR! react-router-bootstrap@0.16.0 prepublish: `npm run build`\nnpm ERR! Exit status 1\nnpm ERR! \nnpm ERR! Failed at the react-router-bootstrap@0.16.0 prepublish script \'npm run build\'.\nnpm ERR! This is most likely a problem with the react-router-bootstrap package,\nnpm ERR! not with npm itself.\nnpm ERR! Tell the author that this fails on your system:\nnpm ERR!     npm run build\nnpm ERR! You can get their info via:\nnpm ERR!     npm owner ls react-router-bootstrap\nnpm ERR! There is likely additional logging output above.\n\nnpm ERR! Please include the following file with any support request:\nnpm ERR!     /private/tmp/react-bootstrap@0.23.4-against-react-router-bootstrap/lib/node_modules/react-router-bootstrap/npm-debug.log\n' }
FAIL: Current version breaks dependents
restored folder /Users/smithm/dev/react-bootstrap
finishing with success? false

Near as I can tell this implies that the downstream should include tests in the npm release. Is that a pre-requisite of downstream modules?

[bahmutov]

@mtscout6 seems the downstream project does not include source / unit tests, thus trying to run the build and test command fails. There is a feature request to be able to test against git repos and not against the published NPM modules, see /issues/15

[bahmutov]

@kentcdodds I cannot see the codeship project, seems weird that the project keeps running - the last line is actually the exit, see https://github.com/bahmutov/dont-break/blob/master/index.js#L20