Fix place order response

 - Read environment from Xcode variable.

Author: Fernando Fernandes

Sources/SwiftTrader/Config/Environment.swift

@@ -0,0 +1,33 @@
+//
+//  Environment.swift
+//  
+//
+//  Created by Fernando Fernandes on 09.02.22.
+//
+
+import Foundation
+
+/// Defines the target exchange environment, such as `production` or `sandbox`.
+public enum Environment: String {
+    case production
+    case sandbox
+}
+
+// MARK: - Interface
+
+public extension Environment {
+    
+    /// An `ENVIRONMENT` variable can be set in the run schema in Xcode to easily switch between them.
+    /// This functions returns it or `nil` if it's absent.
+    static func environmentFromXcode() -> Environment? {
+#if os(macOS) || os(iOS)
+        guard let environmentValue = ProcessInfo.processInfo.environment["ENVIRONMENT"],
+              let environment = Environment(rawValue: environmentValue) else {
+                  return nil
+              }
+        return environment
+#else
+        return nil
+#endif
+    }
+}

Sources/SwiftTrader/Model/Kucoin/Order/KucoinFuturesPlaceOrder.swift

@@ -12,9 +12,6 @@ import Foundation
 /// https://docs.kucoin.com/futures/#place-an-order
 public struct KucoinFuturesPlaceOrder: Codable {
     public let code: String
-    public let data: KucoinFuturesOrderPlaced
-}
-
-public struct KucoinFuturesOrderPlaced: Codable {
-    public let orderId: String
+    public let msg: String?
+    public let orderId: String?
 }

Sources/SwiftTrader/Network/Kucoin/AccountOverview/KucoinFuturesAccountOverviewResource.swift

@@ -16,7 +16,7 @@ public struct KucoinFuturesAccountOverviewResource: NetworkResource {
 
     public var url: URL {
         get throws {
-            let baseURLString = KucoinAPI.Futures.URL.base
+            let baseURLString = KucoinAPI.Futures.baseURL()
             guard var urlComponents = URLComponents(string: baseURLString) else {
                 throw NetworkRequestError.invalidURLString(urlString: baseURLString)
             }

Sources/SwiftTrader/Network/Kucoin/KucoinAPI.swift

@@ -11,16 +11,30 @@ import Foundation
 public struct KucoinAPI {
 
     public struct Futures {
-
+        
         public struct Path {
             static let accountOverview  = "/api/v1/account-overview"
             static let orders           = "/api/v1/orders"
             static let positions        = "/api/v1/positions"
         }
 
-        public struct URL {
-            static let base     = "https://api-futures.kucoin.com"
-            static let sandbox  = "https://api-sandbox-futures.kucoin.com"
+        /// Returns the base `URL` based on an Xcode environment variable.
+        ///
+        /// In case the above fails/is absent, returns the `production` base `URL`.
+        public static func baseURL() -> String {
+            let production = "https://api-futures.kucoin.com"
+            let sandbox = "https://api-sandbox-futures.kucoin.com"
+            if let environment = Environment.environmentFromXcode() {
+                switch environment {
+                case .production:
+                    return production
+                case .sandbox:
+                    return sandbox
+                }
+            } else {
+                // Fallback to production.
+                return production
+            }
         }
     }
 

Sources/SwiftTrader/Network/Kucoin/Orders/KucoinFuturesOrderListResource.swift

@@ -16,7 +16,7 @@ public struct KucoinFuturesOrderListResource: NetworkResource {
 
     public var url: URL {
         get throws {
-            let baseURLString = KucoinAPI.Futures.URL.base
+            let baseURLString = KucoinAPI.Futures.baseURL()
             guard var urlComponents = URLComponents(string: baseURLString) else {
                 throw NetworkRequestError.invalidURLString(urlString: baseURLString)
             }

Sources/SwiftTrader/Network/Kucoin/Orders/KucoinFuturesPlaceOrderRequest.swift

@@ -34,7 +34,8 @@ public struct KucoinFuturesPlaceOrdersRequest: NetworkRequest {
 
             #warning("TODO: This has to be parameterized")
             var json = [String:Any]()
-            json["symbol"] = "XBTUSDM"
+            json["clientOid"] = UUID().uuidString
+            json["symbol"] = "XBTUSDTM"
             json["price"] = "42000"
             json["closeOrder"] = true
 

Sources/SwiftTrader/Network/Kucoin/Orders/KucoinFuturesPlaceOrderResource.swift

@@ -16,7 +16,7 @@ public struct KucoinFuturesPlaceOrderResource: NetworkResource {
 
     public var url: URL {
         get throws {
-            let baseURLString = KucoinAPI.Futures.URL.base
+            let baseURLString = KucoinAPI.Futures.baseURL()
             guard var urlComponents = URLComponents(string: baseURLString) else {
                 throw NetworkRequestError.invalidURLString(urlString: baseURLString)
             }

Sources/SwiftTrader/Network/Kucoin/Positions/KucoinFuturesPositionListResource.swift

@@ -16,7 +16,7 @@ public struct KucoinFuturesPositionListResource: NetworkResource {
 
     public var url: URL {
         get throws {
-            let baseURLString = KucoinAPI.Futures.URL.base
+            let baseURLString = KucoinAPI.Futures.baseURL()
             guard var urlComponents = URLComponents(string: baseURLString) else {
                 throw NetworkRequestError.invalidURLString(urlString: baseURLString)
             }

Sources/SwiftTrader/Network/NetworkRequest/NetworkRequestError.swift

@@ -25,7 +25,7 @@ public enum NetworkRequestError: Error {
     /// Could not instantiate a `URLComponents` struct using the given `String` URL.
     case invalidURLString(urlString: String)
 
-    /// The request failed; the `Error` parameter indicates why.
+    /// The request has failed; the `Error` parameter indicates why.
     case requestFailed(error: Error)
 
     /// The response status code is something other than `200`.