Issue #39: change last_cache to state variable (#40)

Author: herbdool

config/matomo.settings.json

@@ -20,7 +20,6 @@
     "page_title_hierarchy_exclude_home": true,
     "custom_var": [],
     "cache": 0,
-    "last_cache": 0,
     "translation_set": 0,
     "noscript": 0,
     "codesnippet_before": "",

matomo.install

@@ -110,3 +110,15 @@ function matomo_update_1001() {
     $config->save();
   }
 }
+
+/**
+ * Change last_cache setting to state.
+ */
+function matomo_update_1002() {
+  $config = config('matomo.settings');
+  $last_cache = $config->get('last_cache');
+  $config->clear('last_cache');
+  $config->save();
+
+  state_set('matomo_last_cache', $last_cache);
+}

matomo.module

@@ -468,10 +468,9 @@ function matomo_user_presave($account) {
 function matomo_cron() {
   $config = config('matomo.settings');
   // Regenerate the matomo.js every day.
-  if (REQUEST_TIME - $config->get('last_cache') >= 86400 && $config->get('cache')) {
+  if (REQUEST_TIME - state_get('matomo_last_cache', 0) >= 86400 && $config->get('cache')) {
     _matomo_cache($config->get('url_http') . 'matomo.js', TRUE);
-    $config->set('last_cache', REQUEST_TIME);
-    $config->save();
+    state_set('matomo_last_cache', REQUEST_TIME);
   }
 }