Skip to content

Commit 2ff8469

Browse files
authored
fix typo, close #6 (#7)
* fix typo, close #6 Signed-off-by: alei <rayingecho@gmail.com> * lint code for meta
1 parent 59c19db commit 2ff8469

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,20 @@ curl -Lo kubectl-debug https://github.com/aylei/kubectl-debug/releases/download/
4141
curl -Lo kubectl-debug https://github.com/aylei/kubectl-debug/releases/download/0.0.1/kubectl-debug_0.0.1_macos-amd64
4242

4343
chmod +x ./kubectl-debug
44-
mv kubectdl-debug /usr/local/bin/
44+
mv kubectl-debug /usr/local/bin/
4545
```
4646

4747
For windows user, download the latest binary from the [release page](https://github.com/aylei/kubectl-debug/releases/tag/0.0.1) and add it to your PATH.
4848

4949
Try it out!
5050
```bash
51+
# kubectl 1.12.0 or higher
5152
kubectl debug POD_NAME
5253
# learn more with
5354
kubectl debug -h
55+
56+
# old versions of kubectl
57+
kubect-debug POD_NAME
5458
```
5559

5660
> Compatibility: I've tested `kubectl-debug` with kubectl v1.13.1 and kubernetes v1.9.1. I don't have an environment to test more versions but I suppose that `kubectl-debug` is compatible with all versions of kubernetes and kubectl 1.12.0+. Please [file an issue](https://github.com/aylei/kubectl-debug/issues/new) if you find `kubectl-debug` do not work.

pkg/util/jsonstream.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ func (jm *JSONMessage) Display(out io.Writer, termInfo termInfo) error {
197197
endl := "\r"
198198
if termInfo != nil && jm.Stream == "" && jm.Progress != nil {
199199
clearLine(out, termInfo)
200-
fmt.Fprintf(out, endl)
200+
fmt.Fprint(out, endl)
201201
} else if jm.Progress != nil && jm.Progress.String() != "" { //disable progressbar in non-terminal
202202
return nil
203203
}

0 commit comments

Comments
 (0)