Skip to content

Commit fb096da

Browse files
committed
Update tests
1 parent 1b94c3b commit fb096da

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

events/suite_test.go

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"k8s.io/client-go/kubernetes/scheme"
2424
clock "k8s.io/utils/clock/testing"
2525
"sigs.k8s.io/controller-runtime/pkg/client"
26-
"sigs.k8s.io/controller-runtime/pkg/client/fake"
2726
"sigs.k8s.io/controller-runtime/pkg/envtest"
2827
"sigs.k8s.io/controller-runtime/pkg/log"
2928
"sigs.k8s.io/controller-runtime/pkg/reconcile"
@@ -48,16 +47,12 @@ func Test(t *testing.T) {
4847
}
4948

5049
var _ = BeforeSuite(func() {
51-
ctx = context.Background()
5250
ctx = log.IntoContext(context.Background(), ginkgo.GinkgoLogr)
5351

5452
fakeClock = clock.NewFakeClock(time.Now())
55-
kubeClient = fake.NewClientBuilder().WithScheme(scheme.Scheme).WithIndex(&corev1.Event{}, "involvedObject.kind", func(o client.Object) []string {
56-
evt := o.(*corev1.Event)
57-
return []string{evt.InvolvedObject.Kind}
58-
}).Build()
5953
environment := envtest.Environment{Scheme: scheme.Scheme}
6054
_ = lo.Must(environment.Start())
55+
kubeClient = lo.Must(client.New(environment.Config, client.Options{Scheme: scheme.Scheme}))
6156

6257
controller = events.NewController[*test.CustomObject](ctx, kubeClient, fakeClock, kubernetes.NewForConfigOrDie(environment.Config))
6358
})
@@ -117,12 +112,14 @@ var _ = Describe("Controller", func() {
117112
func createEvent(name string, eventType string, reason string) *corev1.Event {
118113
return &corev1.Event{
119114
ObjectMeta: metav1.ObjectMeta{
120-
Name: test.RandomName(),
115+
Name: test.RandomName(),
116+
Namespace: "default",
121117
},
122118
InvolvedObject: corev1.ObjectReference{
123-
Namespace: "default",
124-
Name: name,
125-
Kind: object.GVK(&test.CustomObject{}).Kind,
119+
Namespace: "default",
120+
Name: name,
121+
Kind: object.GVK(&test.CustomObject{}).Kind,
122+
APIVersion: object.GVK(&test.CustomObject{}).GroupVersion().String(),
126123
},
127124
LastTimestamp: metav1.Time{Time: time.Now().Add(30 * time.Minute)},
128125
Type: eventType,

singleton/controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ func ChannelSource[T client.Object](ctx context.Context, objectChan <-chan watch
4343
eventSource := make(chan event.GenericEvent, 1)
4444

4545
go func(ctx context.Context, objectChan <-chan watch.Event, eventSource chan event.GenericEvent) {
46-
4746
for {
4847
select {
4948
case delta, ok := <-objectChan:

0 commit comments

Comments
 (0)