Skip to content

Commit 56c5c39

Browse files
committed
Drop controller-runtime deps
1 parent 8a1bc5e commit 56c5c39

File tree

2 files changed

+19
-9
lines changed

2 files changed

+19
-9
lines changed

events/controller.go

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,13 @@ import (
99
pmetrics "github.com/awslabs/operatorpkg/metrics"
1010
"github.com/awslabs/operatorpkg/object"
1111
"github.com/awslabs/operatorpkg/singleton"
12+
"github.com/samber/lo"
13+
corev1 "k8s.io/api/core/v1"
1214
v1 "k8s.io/api/core/v1"
15+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1316
"k8s.io/apimachinery/pkg/runtime/schema"
1417
"k8s.io/apimachinery/pkg/watch"
18+
"k8s.io/client-go/kubernetes"
1519
"k8s.io/utils/clock"
1620
controllerruntime "sigs.k8s.io/controller-runtime"
1721
"sigs.k8s.io/controller-runtime/pkg/client"
@@ -27,14 +31,17 @@ type Controller[T client.Object] struct {
2731
EventWatchChannel <-chan watch.Event
2832
}
2933

30-
func NewController[T client.Object](client client.Client, clock clock.Clock, channel <-chan watch.Event) *Controller[T] {
34+
func NewController[T client.Object](ctx context.Context, client client.Client, clock clock.Clock, kubernetesInterface kubernetes.Interface) *Controller[T] {
3135
gvk := object.GVK(object.New[T]())
3236
return &Controller[T]{
33-
gvk: gvk,
34-
startTime: clock.Now(),
35-
kubeClient: client,
36-
EventCount: eventTotalMetric(strings.ToLower(gvk.Kind)),
37-
EventWatchChannel: channel,
37+
gvk: gvk,
38+
startTime: clock.Now(),
39+
kubeClient: client,
40+
EventCount: eventTotalMetric(strings.ToLower(gvk.Kind)),
41+
EventWatchChannel: lo.Must(kubernetesInterface.CoreV1().Events("").Watch(ctx, metav1.ListOptions{
42+
// Only reconcile on the object kind we care about
43+
FieldSelector: fmt.Sprintf("involvedObject.kind=%s,involvedObject.apiVersion=%s", object.GVK(&corev1.Node{}).Kind, object.GVK(&corev1.Node{}).GroupVersion().String()),
44+
})).ResultChan(),
3845
}
3946
}
4047

events/suite_test.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ import (
2121
"k8s.io/apimachinery/pkg/runtime"
2222
"k8s.io/apimachinery/pkg/runtime/schema"
2323
"k8s.io/apimachinery/pkg/watch"
24+
"k8s.io/client-go/kubernetes/fake"
2425
"k8s.io/client-go/kubernetes/scheme"
2526
clock "k8s.io/utils/clock/testing"
2627
"sigs.k8s.io/controller-runtime/pkg/client"
27-
ctrlfake "sigs.k8s.io/controller-runtime/pkg/client/fake"
28+
crfake "sigs.k8s.io/controller-runtime/pkg/client/fake"
2829
"sigs.k8s.io/controller-runtime/pkg/log"
2930
"sigs.k8s.io/controller-runtime/pkg/reconcile"
3031
)
@@ -52,13 +53,15 @@ var _ = BeforeSuite(func() {
5253
ctx = log.IntoContext(context.Background(), ginkgo.GinkgoLogr)
5354

5455
fakeClock = clock.NewFakeClock(time.Now())
55-
kubeClient = ctrlfake.NewClientBuilder().WithScheme(scheme.Scheme).WithIndex(&corev1.Event{}, "involvedObject.kind", func(o client.Object) []string {
56+
kubeClient = crfake.NewClientBuilder().WithScheme(scheme.Scheme).WithIndex(&corev1.Event{}, "involvedObject.kind", func(o client.Object) []string {
5657
evt := o.(*corev1.Event)
5758
return []string{evt.InvolvedObject.Kind}
5859
}).Build()
5960

61+
client := fake.NewSimpleClientset()
6062
eventChannel = make(chan watch.Event, 1000)
61-
controller = events.NewController[*test.CustomObject](ctx, kubeClient, fakeClock, eventChannel)
63+
controller = events.NewController[*test.CustomObject](ctx, kubeClient, fakeClock, client)
64+
controller.EventWatchChannel = eventChannel
6265
})
6366

6467
var _ = Describe("Controller", func() {

0 commit comments

Comments
 (0)