Skip to content

Hidden peer dependency / process.env reference #321

@fochlac

Description

@fochlac

Hi,

I'm trying to use your library as a npm package, bundle it for the browser and I'm importing from it as follows:
import { Role, SignalingClient } from 'amazon-kinesis-video-streams-webrtc'
If I want to compile my library I now need to do two things that are not documented, I need to add the dependency 'events' and add an alias for process.env.PACKAGE_VERSION.
While this works, its not a nice DX and it would be better to ship the lib in a way that the entry point has all process.env.variables replaced and events is at least listed as peer dependency.
If this is not possible it would be good to add a note on those requirements if bundling for the browser.
See this code-sandbox and the following screenshots:
image
image

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions