Skip hostname parsing for stun servers (#2125)

* Skip hostname parsing for stun servers

* Clang-format

* Fix unit test

Author: sirknightj

src/include/com/amazonaws/kinesis/video/webrtcclient/Include.h

@@ -722,10 +722,12 @@ extern "C" {
 /**
  * Parameterized string for KVS STUN Server
  */
-#define KINESIS_VIDEO_STUN_URL_POSTFIX      "amazonaws.com"
-#define KINESIS_VIDEO_STUN_URL_POSTFIX_CN   "amazonaws.com.cn"
-#define KINESIS_VIDEO_STUN_URL              "stun:stun.kinesisvideo.%s.%s:443"
-#define KINESIS_VIDEO_STUN_URL_WITHOUT_PORT "stun.kinesisvideo.%s.%s"
+#define KINESIS_VIDEO_STUN_URL_POSTFIX       "amazonaws.com"
+#define KINESIS_VIDEO_STUN_URL_POSTFIX_CN    "amazonaws.com.cn"
+#define KINESIS_VIDEO_STUN_URL_PREFIX        "stun."
+#define KINESIS_VIDEO_STUN_URL_PREFIX_LENGTH 5
+#define KINESIS_VIDEO_STUN_URL               "stun:stun.kinesisvideo.%s.%s:443"
+#define KINESIS_VIDEO_STUN_URL_WITHOUT_PORT  "stun.kinesisvideo.%s.%s"
 
 /**
  * Default signaling SSL port

src/source/Ice/Network.c

@@ -406,25 +406,31 @@ STATUS getIpWithHostName(PCHAR hostname, PKvsIpAddress destIp)
     struct in_addr inaddr;
 
     CHAR addr[KVS_IP_ADDRESS_STRING_BUFFER_LEN + 1] = {'\0'};
+    BOOL isStunServer;
 
     CHK(hostname != NULL, STATUS_NULL_ARG);
     DLOGI("ICE SERVER Hostname received: %s", hostname);
 
     hostnameLen = STRLEN(hostname);
     addrLen = SIZEOF(addr);
+    isStunServer = STRNCMP(hostname, KINESIS_VIDEO_STUN_URL_PREFIX, KINESIS_VIDEO_STUN_URL_PREFIX_LENGTH) == 0;
 
     // Adding this check in case we directly get an IP address. With the current usage pattern,
     // there is no way this function would receive an address directly, but having this check
     // in place anyways
     if (isIpAddr(hostname, hostnameLen)) {
         MEMCPY(addr, hostname, hostnameLen);
-    } else {
+    } else if (!isStunServer) {
         retStatus = getIpAddrFromDnsHostname(hostname, addr, hostnameLen, addrLen);
     }
 
     // Verify the generated address has the format x.x.x.x
     if (!isIpAddr(addr, hostnameLen) || retStatus != STATUS_SUCCESS) {
-        DLOGW("Parsing for address failed for %s, fallback to getaddrinfo", hostname);
+        // Only print the message for TURN servers since STUN addresses don't have the IP in the URL
+        if (!isStunServer) {
+            DLOGW("Parsing for address failed for %s, fallback to getaddrinfo", hostname);
+        }
+
         errCode = getaddrinfo(hostname, NULL, NULL, &res);
         if (errCode != 0) {
             errStr = errCode == EAI_SYSTEM ? (strerror(errno)) : ((PCHAR) gai_strerror(errCode));