Windows Server Support

[saedx1]

We utilize dozens of EKS clusters and have lots of secrets to mount on windows nodes/containers. EKS support for windows is not something that is short-term according to the EKS team and is not in an early stage.

We expect to be able to use secrets with our windows containers in EKS and to be able to use them with secrets store csi driver.

We have looked at this before and we did fork this project to support windows, the support only requires a couple of small adjustments (filepath separator and explicitly closing some file AFAIR). We are happy to create a PR to do the adjustments for the helm chart, docker builds, and go code.

We have been using this fork for almost 2 years and it just works. However, we don't want to be managing this as we think this needs to be supported by AWS since they are standing behind windows support and since it's not a lot of work.

[simonmarty]

Feel free to share a link to the fork if it's open-source so we can take a look.

Most of the difficulty in us distributing official support for Windows is having the tooling to continuously verify that changes we introduce to this provider won't break Windows customers. Without good support from EKS, this is difficult for us.

I'm going to move this to a discussion.

[saedx1]

So, what exactly do you mean by "Without good support from EKS"?
I am not sure where exactly this is coming from, but EKS does support windows just well.

Here is a draft PR; you can dismiss most of the *Ops/Build stuff (just because I haven't had a chance to clean that) and just look at the .go code for now.

[simonmarty]

Maybe I misunderstood what you meant by

EKS support for windows is not something that is short-term according to the EKS team and is not in an early stage.

I do see there are significant parity differences between Windows and Linux EKS clusters. I'm not sure if any of those are blockers just yet.

[saedx1]

I meant to say that EKS is supporting Windows pretty well, long-term, and we've not been told of any plans of going back on the support by AWS.

If you look at the PR, you'd notice that the code changes are fairly minimal (a couple of lines only). Also, last I checked, all of the unit tests pass.

Again, we have this running already for over a year, it works just fine, we just don't think we should be the ones supporting this since we are using EKS (and AWS service) and Secrets Manager (another AWS service) with Windows (Officially Supported by AWS).

The differences between windows and Linux do not make a difference in the realm of this provider.