Skip to content

Commit c977f5f

Browse files
lianyidingchuyang-deng
authored andcommitted
change: update no-p2 and no-p3 regions. (#230)
Add placeholder in test commands for cpu-instance-type and aws-id.
1 parent 18496c5 commit c977f5f

File tree

3 files changed

+26
-4
lines changed

3 files changed

+26
-4
lines changed

buildspec-release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ phases:
7373
"dest": ["1.13.1-gpu-py3", "1.13-gpu-py3", "1.13.1-gpu-py3-'${CODEBUILD_BUILD_ID#*:}'"]
7474
}],
7575
"test": [
76-
"IGNORE_COVERAGE=- tox -e py36 -- -m deploy_test test/integration/sagemaker -n 4 --region {region} --account-id 520713654638 --docker-base-name sagemaker-tensorflow-scriptmode --framework-version 1.13.1 --processor cpu,gpu --py-version 2,3"
76+
"IGNORE_COVERAGE=- tox -e py36 -- -m deploy_test test/integration/sagemaker -n 4 --region {region} --account-id {aws-id} --instance-type {cpu-instance-type} --docker-base-name sagemaker-tensorflow-scriptmode --framework-version 1.13.1 --processor cpu --py-version 2,3",
77+
"IGNORE_COVERAGE=- tox -e py36 -- -m deploy_test test/integration/sagemaker -n 4 --region {region} --account-id {aws-id} --docker-base-name sagemaker-tensorflow-scriptmode --framework-version 1.13.1 --processor gpu --py-version 2,3"
7778
]
7879
}]' > deployments.json
7980

test/integration/__init__.py

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,26 @@
2121
RESOURCE_PATH = os.path.join(os.path.dirname(__file__), '..', 'resources')
2222

2323
# these regions have some p2 and p3 instances, but not enough for automated testing
24-
NO_P2_REGIONS = ['ca-central-1', 'eu-central-1', 'eu-west-2', 'us-west-1']
25-
NO_P3_REGIONS = ['ap-southeast-1', 'ap-southeast-2', 'ap-south-1', 'ca-central-1',
26-
'eu-central-1', 'eu-west-2', 'us-west-1']
24+
NO_P2_REGIONS = [
25+
'ca-central-1',
26+
'eu-central-1',
27+
'eu-west-2',
28+
'us-west-1',
29+
'eu-west-3',
30+
'eu-north-1',
31+
'sa-east-1',
32+
'ap-east-1'
33+
]
34+
NO_P3_REGIONS = [
35+
'ap-southeast-1',
36+
'ap-southeast-2',
37+
'ap-south-1',
38+
'ca-central-1',
39+
'eu-central-1',
40+
'eu-west-2',
41+
'us-west-1'
42+
'eu-west-3',
43+
'eu-north-1',
44+
'sa-east-1',
45+
'ap-east-1'
46+
]

tox.ini

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ ignore =
3434
FI15,
3535
FI16,
3636
FI17,
37+
FI18, # __future__ import "annotations" missing -> check only Python 3.7 compatible
3738
FI50,
3839
FI51,
3940
FI52,

0 commit comments

Comments
 (0)