Move label constants in to module (#1252)

kmcginnes · web-flow · commit f7124c98c46a · 2025-10-16T18:25:02.000-05:00
diff --git a/packages/graph-explorer/src/connector/entities/bundle.test.ts b/packages/graph-explorer/src/connector/entities/bundle.test.ts
@@ -1,7 +1,7 @@
 import { describe, it, expect } from "vitest";
 import { createPatchedResultBundle, getDisplayValueForBundle } from "./bundle";
 import { createResultScalar } from "./scalar";
-import { MISSING_DISPLAY_VALUE, ASCII } from "@/utils/constants";
+import { ASCII, LABELS } from "@/utils/constants";
 import { createTestableEdge, createTestableVertex } from "@/utils/testing";
 
 describe("getDisplayValueForBundle", () => {
@@ -47,7 +47,7 @@ describe("getDisplayValueForBundle", () => {
     const result = getDisplayValueForBundle(bundle);
 
     expect(result).toBe(
-      `EmptyField: ${MISSING_DISPLAY_VALUE}${ASCII.NBSP}• ${MISSING_DISPLAY_VALUE}`
+      `EmptyField: ${LABELS.MISSING_VALUE}${ASCII.NBSP}• ${LABELS.MISSING_VALUE}`
     );
   });
 
@@ -276,7 +276,7 @@ describe("getDisplayValueForBundle", () => {
       const result = getDisplayValueForBundle(bundle, upperCaseTransformer);
 
       expect(result).toBe(
-        `EMPTY_FIELD: ${MISSING_DISPLAY_VALUE}${ASCII.NBSP}• ${MISSING_DISPLAY_VALUE}`
+        `EMPTY_FIELD: ${LABELS.MISSING_VALUE}${ASCII.NBSP}• ${LABELS.MISSING_VALUE}`
       );
     });
 
diff --git a/packages/graph-explorer/src/connector/entities/scalar.test.ts b/packages/graph-explorer/src/connector/entities/scalar.test.ts
@@ -9,7 +9,7 @@ import {
   getDisplayValueForScalar,
   ResultScalar,
 } from "./scalar";
-import { MISSING_DISPLAY_VALUE } from "@/utils";
+import { LABELS } from "@/utils";
 
 describe("scalar", () => {
   describe("createScalar", () => {
@@ -150,7 +150,7 @@ describe("scalar", () => {
   describe("getDisplayValueForScalar", () => {
     it("should return null for null scalar", () => {
       const result = getDisplayValueForScalar(null);
-      expect(result).toBe(MISSING_DISPLAY_VALUE);
+      expect(result).toBe(LABELS.MISSING_VALUE);
     });
 
     it("should return string for string scalar", () => {
diff --git a/packages/graph-explorer/src/connector/entities/scalar.ts b/packages/graph-explorer/src/connector/entities/scalar.ts
@@ -1,4 +1,4 @@
-import { formatDate, MISSING_DISPLAY_VALUE } from "@/utils";
+import { formatDate, LABELS } from "@/utils";
 
 /**
  * Represents a scalar value that can be returned from a graph database query.
@@ -101,6 +101,6 @@ export function getDisplayValueForScalar(value: ScalarValue) {
     case "date":
       return formatDate(typedValue.value);
     case "null":
-      return MISSING_DISPLAY_VALUE;
+      return LABELS.MISSING_VALUE;
   }
 }
diff --git a/packages/graph-explorer/src/core/AppErrorPage.tsx b/packages/graph-explorer/src/core/AppErrorPage.tsx
@@ -7,7 +7,7 @@ import {
   Paragraph,
   ResetIcon,
 } from "@/components";
-import { APP_NAME, RELOAD_URL } from "@/utils/constants";
+import { LABELS, RELOAD_URL } from "@/utils/constants";
 
 /** This is the app wide error page that will be shown when the app essentially crashes */
 export default function AppErrorPage(props: FallbackProps) {
@@ -25,7 +25,7 @@ export default function AppErrorPage(props: FallbackProps) {
         {/* Force a full reload of the app in the browser */}
         <a href={RELOAD_URL}>
           <Button variant="filled" size="large" icon={<ResetIcon />}>
-            Reload {APP_NAME}
+            Reload {LABELS.APP_NAME}
           </Button>
         </a>
       </div>
diff --git a/packages/graph-explorer/src/core/StateProvider/displayAttribute.test.ts b/packages/graph-explorer/src/core/StateProvider/displayAttribute.test.ts
@@ -12,7 +12,7 @@ import {
   createRandomInteger,
   createRandomName,
 } from "@shared/utils/testing";
-import { formatDate, MISSING_DISPLAY_VALUE } from "@/utils";
+import { formatDate, LABELS } from "@/utils";
 import { getDisplayValueForScalar } from "@/connector/entities";
 
 describe("mapToDisplayAttribute", () => {
@@ -67,7 +67,7 @@ describe("mapToDisplayAttribute", () => {
     expect(displayAttribute).toStrictEqual({
       name,
       displayLabel: name,
-      displayValue: MISSING_DISPLAY_VALUE,
+      displayValue: LABELS.MISSING_VALUE,
     });
   });
 
diff --git a/packages/graph-explorer/src/core/StateProvider/displayEdge.ts b/packages/graph-explorer/src/core/StateProvider/displayEdge.ts
@@ -14,11 +14,7 @@ import {
   edgeTypeAttributesSelector,
 } from "@/core";
 import { textTransformSelector } from "@/hooks";
-import {
-  MISSING_DISPLAY_VALUE,
-  RESERVED_ID_PROPERTY,
-  RESERVED_TYPES_PROPERTY,
-} from "@/utils";
+import { LABELS, RESERVED_ID_PROPERTY, RESERVED_TYPES_PROPERTY } from "@/utils";
 import { atom, useAtomValue } from "jotai";
 import { atomFamily } from "jotai/utils";
 
@@ -96,11 +92,11 @@ const displayEdgeSelector = atomFamily((edge: Edge) =>
       } else if (name) {
         return (
           sortedAttributes.find(attr => attr.name === name)?.displayValue ??
-          MISSING_DISPLAY_VALUE
+          LABELS.MISSING_VALUE
         );
       }
 
-      return MISSING_DISPLAY_VALUE;
+      return LABELS.MISSING_VALUE;
     }
 
     const displayName = getDisplayAttributeValueByName(
diff --git a/packages/graph-explorer/src/core/StateProvider/displayTypeConfigs.test.ts b/packages/graph-explorer/src/core/StateProvider/displayTypeConfigs.test.ts
@@ -14,7 +14,7 @@ import {
   mapToDisplayVertexTypeConfig,
 } from "./displayTypeConfigs";
 import { createRandomName } from "@shared/utils/testing";
-import { MISSING_DISPLAY_TYPE } from "@/utils";
+import { LABELS } from "@/utils";
 import type { TextTransformer } from "@/hooks";
 
 // Simple identity text transformer for testing (non-SPARQL behavior)
@@ -49,7 +49,7 @@ describe("useDisplayVertexTypeConfig", () => {
       useDisplayVertexTypeConfig("")
     );
 
-    expect(result.current.displayLabel).toBe(MISSING_DISPLAY_TYPE);
+    expect(result.current.displayLabel).toBe(LABELS.MISSING_TYPE);
   });
 
   it("should ignore display label from schema", () => {
@@ -346,7 +346,7 @@ describe("useDisplayEdgeTypeConfig", () => {
   it("should use empty label constant when the type is empty", () => {
     const { result } = renderHookWithState(() => useDisplayEdgeTypeConfig(""));
 
-    expect(result.current.displayLabel).toBe(MISSING_DISPLAY_TYPE);
+    expect(result.current.displayLabel).toBe(LABELS.MISSING_TYPE);
   });
 
   it("should ignore display label from the config", () => {
diff --git a/packages/graph-explorer/src/core/StateProvider/displayTypeConfigs.ts b/packages/graph-explorer/src/core/StateProvider/displayTypeConfigs.ts
@@ -12,7 +12,7 @@ import {
   LineStyle,
 } from "@/core";
 import { TextTransformer, textTransformSelector } from "@/hooks";
-import { MISSING_DISPLAY_TYPE, RESERVED_TYPES_PROPERTY } from "@/utils";
+import { LABELS, RESERVED_TYPES_PROPERTY } from "@/utils";
 import { atomFamily, useAtomCallback } from "jotai/utils";
 import { atom, useAtomValue } from "jotai";
 import { useCallback } from "react";
@@ -133,7 +133,7 @@ export function mapToDisplayVertexTypeConfig(
   const displayLabel =
     typeConfig.displayLabel ||
     textTransform(typeConfig.type) ||
-    MISSING_DISPLAY_TYPE;
+    LABELS.MISSING_TYPE;
 
   const attributes: DisplayConfigAttribute[] = typeConfig.attributes
     .map(attr => ({
@@ -170,7 +170,7 @@ export function mapToDisplayEdgeTypeConfig(
   const displayLabel =
     typeConfig.displayLabel ||
     textTransform(typeConfig.type) ||
-    MISSING_DISPLAY_TYPE;
+    LABELS.MISSING_TYPE;
 
   const attributes: DisplayConfigAttribute[] = typeConfig.attributes
     .map(attr => ({
diff --git a/packages/graph-explorer/src/core/StateProvider/displayVertex.test.ts b/packages/graph-explorer/src/core/StateProvider/displayVertex.test.ts
@@ -26,7 +26,7 @@ import {
   patchToRemoveDisplayLabel,
 } from "./configuration";
 import { createRandomDate, createRandomName } from "@shared/utils/testing";
-import { MISSING_DISPLAY_VALUE } from "@/utils/constants";
+import { LABELS } from "@/utils/constants";
 import { mapToDisplayVertexTypeConfig } from "./displayTypeConfigs";
 import { QueryEngine } from "@shared/types";
 import { getDisplayValueForScalar } from "@/connector/entities";
@@ -203,7 +203,7 @@ describe("useDisplayVertexFromVertex", () => {
           <DisplayAttribute>{
             name: attr.name,
             displayLabel: attr.name,
-            displayValue: MISSING_DISPLAY_VALUE,
+            displayValue: LABELS.MISSING_VALUE,
           }
       )
       .toSorted((a, b) => a.displayLabel.localeCompare(b.displayLabel));
diff --git a/packages/graph-explorer/src/core/StateProvider/displayVertex.ts b/packages/graph-explorer/src/core/StateProvider/displayVertex.ts
@@ -14,11 +14,7 @@ import {
   useVertex,
 } from "@/core";
 import { textTransformSelector } from "@/hooks";
-import {
-  MISSING_DISPLAY_VALUE,
-  RESERVED_ID_PROPERTY,
-  RESERVED_TYPES_PROPERTY,
-} from "@/utils";
+import { LABELS, RESERVED_ID_PROPERTY, RESERVED_TYPES_PROPERTY } from "@/utils";
 import { atom, useAtomValue } from "jotai";
 import { atomFamily } from "jotai/utils";
 
@@ -109,11 +105,11 @@ const displayVertexSelector = atomFamily((vertex: Vertex) =>
       } else if (name) {
         return (
           sortedAttributes.find(attr => attr.name === name)?.displayValue ??
-          MISSING_DISPLAY_VALUE
+          LABELS.MISSING_VALUE
         );
       }
 
-      return MISSING_DISPLAY_VALUE;
+      return LABELS.MISSING_VALUE;
     }
 
     const displayName = getDisplayAttributeValueByName(
diff --git a/packages/graph-explorer/src/core/StateProvider/localDb.ts b/packages/graph-explorer/src/core/StateProvider/localDb.ts
@@ -3,7 +3,7 @@ import { logger } from "@/utils";
 import { deserializeData, serializeData } from "./serializeData";
 import { fromFileToJson, toJsonFileData } from "@/utils/fileData";
 import saveAs from "file-saver";
-import { APP_NAME } from "@/utils/constants";
+import { LABELS } from "@/utils/constants";
 
 /*
 
@@ -131,7 +131,7 @@ export async function createBackupData(localDb: LocalDb) {
   const backupData = Object.fromEntries(await getEntries(localDb));
 
   const result: SerializedBackup = {
-    backupSource: APP_NAME,
+    backupSource: LABELS.APP_NAME,
     backupSourceVersion: __GRAPH_EXP_VERSION__,
     backupVersion: "1.0",
     backupTimestamp: new Date(),
diff --git a/packages/graph-explorer/src/modules/ConnectionDetail/ConnectionDetail.tsx b/packages/graph-explorer/src/modules/ConnectionDetail/ConnectionDetail.tsx
@@ -44,12 +44,7 @@ import {
   useSchemaSync,
 } from "@/hooks/useSchemaSync";
 import useTranslations from "@/hooks/useTranslations";
-import {
-  formatDate,
-  formatRelativeDate,
-  logger,
-  MISSING_DISPLAY_VALUE,
-} from "@/utils";
+import { formatDate, formatRelativeDate, LABELS, logger } from "@/utils";
 import saveConfigurationToFile from "@/utils/saveConfigurationToFile";
 import CreateConnection from "@/modules/CreateConnection";
 import ConnectionData from "./ConnectionData";
@@ -93,7 +88,7 @@ function ConnectionDetail({ config }: ConnectionDetailProps) {
     ? config.connection.proxyConnection
       ? config.connection.graphDbUrl
       : config.connection.url
-    : MISSING_DISPLAY_VALUE;
+    : LABELS.MISSING_VALUE;
 
   const isSyncing = useIsSyncing();
 
@@ -268,7 +263,7 @@ function VertexCounts() {
   const t = useTranslations();
 
   const humanReadable =
-    totalNodes == null ? MISSING_DISPLAY_VALUE : toHumanString(totalNodes);
+    totalNodes == null ? LABELS.MISSING_VALUE : toHumanString(totalNodes);
 
   return (
     <InfoItem>
@@ -288,7 +283,7 @@ function EdgeCounts() {
   const t = useTranslations();
 
   const humanReadable =
-    totalEdges == null ? MISSING_DISPLAY_VALUE : toHumanString(totalEdges);
+    totalEdges == null ? LABELS.MISSING_VALUE : toHumanString(totalEdges);
 
   return (
     <InfoItem>
diff --git a/packages/graph-explorer/src/modules/EdgesStyling/SingleEdgeStyling.tsx b/packages/graph-explorer/src/modules/EdgesStyling/SingleEdgeStyling.tsx
@@ -3,7 +3,7 @@ import { Button, FormItem, InputField, Label, StylingIcon } from "@/components";
 import { useDisplayEdgeTypeConfig } from "@/core";
 import { useEdgeStyling } from "@/core/StateProvider/userPreferences";
 import { useDebounceValue, usePrevious } from "@/hooks";
-import { MISSING_DISPLAY_TYPE } from "@/utils";
+import { LABELS } from "@/utils";
 import { customizeEdgeTypeAtom } from "./EdgeStyleDialog";
 import { useSetAtom } from "jotai";
 
@@ -37,7 +37,7 @@ export default function SingleEdgeStyling({
       {edgeType ? (
         <Label>{edgeType}</Label>
       ) : (
-        <Label>{MISSING_DISPLAY_TYPE}</Label>
+        <Label>{LABELS.MISSING_TYPE}</Label>
       )}
       <div className="flex flex-row items-center gap-2">
         <InputField
diff --git a/packages/graph-explorer/src/modules/EntitiesTabular/components/EdgesTabular.tsx b/packages/graph-explorer/src/modules/EntitiesTabular/components/EdgesTabular.tsx
@@ -26,7 +26,7 @@ import {
   useDisplayVerticesInCanvas,
 } from "@/core";
 import { useAtom, useAtomValue, useSetAtom } from "jotai";
-import { MISSING_DISPLAY_VALUE } from "@/utils";
+import { LABELS } from "@/utils";
 
 /** Creates the model for the table data */
 function createEdgeForTable(
@@ -38,10 +38,10 @@ function createEdgeForTable(
     id: edge.id,
     displayTypes: edge.displayTypes,
     displayName: edge.displayName,
-    sourceDisplayId: source?.displayId ?? MISSING_DISPLAY_VALUE,
-    sourceDisplayTypes: source?.displayTypes ?? MISSING_DISPLAY_VALUE,
-    targetDisplayId: target?.displayId ?? MISSING_DISPLAY_VALUE,
-    targetDisplayTypes: target?.displayTypes ?? MISSING_DISPLAY_VALUE,
+    sourceDisplayId: source?.displayId ?? LABELS.MISSING_VALUE,
+    sourceDisplayTypes: source?.displayTypes ?? LABELS.MISSING_VALUE,
+    targetDisplayId: target?.displayId ?? LABELS.MISSING_VALUE,
+    targetDisplayTypes: target?.displayTypes ?? LABELS.MISSING_VALUE,
   };
 }
 
diff --git a/packages/graph-explorer/src/modules/EntityDetails/NodeDetail.tsx b/packages/graph-explorer/src/modules/EntityDetails/NodeDetail.tsx
@@ -3,7 +3,7 @@ import useTranslations from "@/hooks/useTranslations";
 import NeighborsList from "@/modules/common/NeighborsList/NeighborsList";
 import EntityAttribute from "./EntityAttribute";
 import {
-  LABEL_FOR_BLANK_NODE_ID,
+  LABELS,
   RESERVED_ID_PROPERTY,
   RESERVED_TYPES_PROPERTY,
 } from "@/utils/constants";
@@ -21,7 +21,7 @@ export default function NodeDetail({ node }: VertexDetailProps) {
       name: RESERVED_ID_PROPERTY,
       // Blank node IDs are not standard IDs, so they get a custom label
       displayLabel: node.isBlankNode
-        ? LABEL_FOR_BLANK_NODE_ID
+        ? LABELS.BLANK_NODE_ID
         : t("node-detail.node-id"),
       displayValue: node.displayId,
     },
diff --git a/packages/graph-explorer/src/modules/GraphViewer/exportedGraph.ts b/packages/graph-explorer/src/modules/GraphViewer/exportedGraph.ts
@@ -6,7 +6,7 @@ import {
   EntityRawId,
   VertexId,
 } from "@/core/entities";
-import { APP_NAME, escapeString, logger } from "@/utils";
+import { escapeString, LABELS, logger } from "@/utils";
 import {
   ConnectionConfig,
   QueryEngine,
@@ -44,7 +44,7 @@ export function createExportedGraph(
   return {
     meta: {
       kind: "graph-export",
-      source: APP_NAME,
+      source: LABELS.APP_NAME,
       sourceVersion: __GRAPH_EXP_VERSION__,
       version: "1.0",
       timestamp: new Date(),
diff --git a/packages/graph-explorer/src/modules/GraphViewer/useGraphStyles.test.tsx b/packages/graph-explorer/src/modules/GraphViewer/useGraphStyles.test.tsx
@@ -2,7 +2,7 @@ import { waitFor } from "@testing-library/react";
 import { describe, expect, it, vi, beforeEach, Mock } from "vitest";
 import useGraphStyles from "./useGraphStyles";
 import { renderNode } from "./renderNode";
-import { MISSING_DISPLAY_VALUE } from "@/utils/constants";
+import { LABELS } from "@/utils/constants";
 import { getEdgeIdFromRenderedEdgeId } from "@/core";
 import type { RenderedEdgeId } from "@/core";
 import type { GraphProps } from "@/components";
@@ -261,7 +261,7 @@ describe("useGraphStyles", () => {
     };
 
     const label = labelFunction(mockEdgeElement);
-    expect(label).toBe(MISSING_DISPLAY_VALUE);
+    expect(label).toBe(LABELS.MISSING_VALUE);
   });
 
   it("should handle renderNode failure gracefully", () => {
diff --git a/packages/graph-explorer/src/modules/GraphViewer/useGraphStyles.ts b/packages/graph-explorer/src/modules/GraphViewer/useGraphStyles.ts
@@ -14,7 +14,7 @@ import {
   useEdgeTypeConfigs,
   useVertexTypeConfigs,
 } from "@/core/ConfigurationProvider/useConfiguration";
-import { MISSING_DISPLAY_VALUE } from "@/utils/constants";
+import { LABELS } from "@/utils/constants";
 import { useBackgroundImageMap } from "./useBackgroundImageMap";
 
 const LINE_PATTERN = {
@@ -78,7 +78,7 @@ function createGraphStyles(
         const displayEdge = displayEdges.get(
           getEdgeIdFromRenderedEdgeId(edgeId)
         );
-        return displayEdge ? displayEdge.displayName : MISSING_DISPLAY_VALUE;
+        return displayEdge ? displayEdge.displayName : LABELS.MISSING_VALUE;
       },
       color: new Color(etConfig?.labelColor || "#17457b").isDark()
         ? "#FFFFFF"
diff --git a/packages/graph-explorer/src/modules/NodesStyling/SingleNodeStyling.tsx b/packages/graph-explorer/src/modules/NodesStyling/SingleNodeStyling.tsx
diff --git a/packages/graph-explorer/src/modules/SearchSidebar/useVertexAttributesAsScalars.ts b/packages/graph-explorer/src/modules/SearchSidebar/useVertexAttributesAsScalars.ts
diff --git a/packages/graph-explorer/src/routes/Connections/Connections.tsx b/packages/graph-explorer/src/routes/Connections/Connections.tsx
diff --git a/packages/graph-explorer/src/routes/DataExplorer/DataExplorer.tsx b/packages/graph-explorer/src/routes/DataExplorer/DataExplorer.tsx
diff --git a/packages/graph-explorer/src/routes/GraphExplorer/GraphExplorer.tsx b/packages/graph-explorer/src/routes/GraphExplorer/GraphExplorer.tsx
diff --git a/packages/graph-explorer/src/routes/Settings/LoadConfigButton.tsx b/packages/graph-explorer/src/routes/Settings/LoadConfigButton.tsx
diff --git a/packages/graph-explorer/src/routes/Settings/SettingsAbout.tsx b/packages/graph-explorer/src/routes/Settings/SettingsAbout.tsx
diff --git a/packages/graph-explorer/src/routes/Settings/SettingsRoot.tsx b/packages/graph-explorer/src/routes/Settings/SettingsRoot.tsx
diff --git a/packages/graph-explorer/src/utils/constants.ts b/packages/graph-explorer/src/utils/constants.ts

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { formatDate, MISSING_DISPLAY_VALUE } from "@/utils";`
	`1`	`+import { formatDate, LABELS } from "@/utils";`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* Represents a scalar value that can be returned from a graph database query.`
`@@ -101,6 +101,6 @@ export function getDisplayValueForScalar(value: ScalarValue) {`
`101`	`101`	`case "date":`
`102`	`102`	`return formatDate(typedValue.value);`
`103`	`103`	`case "null":`
`104`		`- return MISSING_DISPLAY_VALUE;`
	`104`	`+ return LABELS.MISSING_VALUE;`
`105`	`105`	`}`
`106`	`106`	`}`