chore(template): remove previous env template version (#2569)

<!-- Provide summary of changes -->
This PR removes all our previous env template versions because
1. similar to #2567, though we have all our previous env template versions, we don't actually need to rollback. Thus keeping these templates doesn't add any value
2. we don't version the partial env templates as well as the lambdas, which causes the fact that we often forget to update the latest template version even though the env template has been changed
3. creating a new template version is cumbersome and make it difficult for code reviewers to see the difference against the previous version

Also updated the latest version to 1.4.1 since we haven't updated the version number for a while even though the template changed because of lambda changes.
<!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" -->

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Author: iamhopaul123

internal/pkg/deploy/env.go

@@ -13,7 +13,7 @@ const (
 	// LegacyEnvTemplateVersion is the version associated with the environment template before we started versioning.
 	LegacyEnvTemplateVersion = "v0.0.0"
 	// LatestEnvTemplateVersion is the latest version number available for environment templates.
-	LatestEnvTemplateVersion = "v1.4.0"
+	LatestEnvTemplateVersion = "v1.4.1"
 )
 
 // CreateEnvironmentInput holds the fields required to deploy an environment.

internal/pkg/template/env.go

@@ -11,7 +11,7 @@ import (
 )
 
 const (
-	fmtEnvCFTemplatePath    = "environment/versions/cf-%s.yml"
+	envCFTemplatePath       = "environment/cf.yml"
 	fmtEnvCFSubTemplatePath = "environment/partials/%s.yml"
 )
 
@@ -44,7 +44,7 @@ type EnvOpts struct {
 
 // ParseEnv parses an environment's CloudFormation template with the specified data object and returns its content.
 func (t *Template) ParseEnv(data *EnvOpts, options ...ParseOption) (*Content, error) {
-	tpl, err := t.parse("base", envTemplatePath(data.Version), options...)
+	tpl, err := t.parse("base", envCFTemplatePath, options...)
 	if err != nil {
 		return nil, err
 	}
@@ -64,10 +64,3 @@ func (t *Template) ParseEnv(data *EnvOpts, options ...ParseOption) (*Content, er
 	}
 	return &Content{buf}, nil
 }
-
-func envTemplatePath(version string) string {
-	if version == "" {
-		return fmt.Sprintf(fmtEnvCFTemplatePath, "v0.0.0")
-	}
-	return fmt.Sprintf(fmtEnvCFTemplatePath, version)
-}

internal/pkg/template/env_test.go

@@ -4,7 +4,6 @@
 package template
 
 import (
-	"fmt"
 	"testing"
 
 	"github.com/gobuffalo/packd"
@@ -13,35 +12,14 @@ import (
 
 func TestTemplate_ParseEnv(t *testing.T) {
 	testCases := map[string]struct {
-		version          string
 		mockDependencies func(t *Template)
 		wantedContent    string
 		wantedErr        error
 	}{
-		"renders all nested templates in legacy template": {
+		"renders env template": {
 			mockDependencies: func(t *Template) {
 				mockBox := packd.NewMemoryBox()
-				var baseContent string
-				for _, name := range envCFSubTemplateNames {
-					baseContent += fmt.Sprintf(`{{include "%s" . | indent 2}}`+"\n", name)
-				}
-				mockBox.AddString("environment/versions/cf-v0.0.0.yml", baseContent)
-				t.box = mockBox
-			},
-			wantedContent: `  cfn-execution-role
-  custom-resources
-  custom-resources-role
-  environment-manager-role
-  lambdas
-  vpc-resources
-  nat-gateways
-`,
-		},
-		"renders v1.0.0 template": {
-			version: "v1.0.0",
-			mockDependencies: func(t *Template) {
-				mockBox := packd.NewMemoryBox()
-				mockBox.AddString("environment/versions/cf-v1.0.0.yml", "test")
+				mockBox.AddString("environment/cf.yml", "test")
 				t.box = mockBox
 			},
 			wantedContent: "test",
@@ -62,9 +40,7 @@ func TestTemplate_ParseEnv(t *testing.T) {
 			tpl.box.AddString("environment/partials/nat-gateways.yml", "nat-gateways")
 
 			// WHEN
-			c, err := tpl.ParseEnv(&EnvOpts{
-				Version: tc.version,
-			})
+			c, err := tpl.ParseEnv(&EnvOpts{})
 
 			if tc.wantedErr != nil {
 				require.Contains(t, err.Error(), tc.wantedErr.Error())

templates/environment/versions/cf-v1.4.0.yml renamed to templates/environment/cf.yml

@@ -2,7 +2,7 @@
 # SPDX-License-Identifier: MIT-0
 Description: CloudFormation environment template for infrastructure shared among Copilot workloads.
 Metadata:
-  Version: 'v1.4.0'
+  Version: 'v1.4.1'
 Parameters:
   AppName:
     Type: String