Skip to content

Commit e514087

Browse files
authored
test: adds integration and e2e container dependency tests (#2441)
Adds DependsOn field to integration test. Adds DependsOn field to e2e test. Addresses testing for #2175 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 67c5f59 commit e514087

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

e2e/sidecars/sidecars_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ image:
3030
build: hello/Dockerfile
3131
# Port exposed through your container to route traffic to it.
3232
port: 3000
33+
depends_on:
34+
nginx: start
3335
3436
http:
3537
# Requests to this path will be forwarded to your service.

internal/pkg/deploy/cloudformation/stack/testdata/workloads/job-manifest.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ image:
1212
labels:
1313
com.amazonaws.ecs.copilot.description: Hello world!
1414
location: alpine
15+
depends_on:
16+
nginx: start
1517

1618
# Number of CPU units for the task.
1719
cpu: 256

internal/pkg/deploy/cloudformation/stack/testdata/workloads/job-test.stack.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@ Resources:
150150
DockerLabels:
151151
com.amazonaws.ecs.copilot.coollabel: Synecdoche
152152
com.amazonaws.ecs.copilot.description: Hello world!
153+
DependsOn:
154+
- Condition: START
155+
ContainerName: nginx
153156
- Name: nginx
154157
Image: 'public.ecr.aws/nginx/nginx'
155158
LogConfiguration:

0 commit comments

Comments
 (0)