Skip to content

Commit c8f0afc

Browse files
authored
chore(cli): extract misleading language in job manifest for rates (#1554)
<!-- Provide summary of changes --> At some point, we decided not to accept simple duration strings like "1h30m" in favor of the "@every 1h30m" syntax. This PR rewords the comment in the manifest to clarify the required syntax. <!-- Issue number, if available. E.g. "Fixes #31", "Addresses #42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
1 parent 2256074 commit c8f0afc

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

internal/pkg/manifest/testdata/scheduled-job-fully-specified.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ cpu: 256
1818
memory: 512
1919

2020
on:
21-
# The scheduled trigger for your job. You can specify a cron schedule or keyword (@weekly) or a rate (2h, 1h30m, 15m)
21+
# The scheduled trigger for your job. You can specify a Unix cron schedule or keyword (@weekly) or a rate (@every 1h30m)
2222
# AWS Schedule Expressions are also accepted: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html
2323
schedule: "0 */2 * * *"
2424

internal/pkg/manifest/testdata/scheduled-job-no-retries.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ cpu: 256
1818
memory: 512
1919

2020
on:
21-
# The scheduled trigger for your job. You can specify a cron schedule or keyword (@weekly) or a rate (2h, 1h30m, 15m)
21+
# The scheduled trigger for your job. You can specify a Unix cron schedule or keyword (@weekly) or a rate (@every 1h30m)
2222
# AWS Schedule Expressions are also accepted: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html
2323
schedule: "@every 5h"
2424

internal/pkg/manifest/testdata/scheduled-job-no-timeout-or-retries.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ cpu: 256
1818
memory: 512
1919

2020
on:
21-
# The scheduled trigger for your job. You can specify a cron schedule or keyword (@weekly) or a rate (2h, 1h30m, 15m)
21+
# The scheduled trigger for your job. You can specify a Unix cron schedule or keyword (@weekly) or a rate (@every 1h30m)
2222
# AWS Schedule Expressions are also accepted: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html
2323
schedule: "@weekly"
2424

internal/pkg/manifest/testdata/scheduled-job-no-timeout.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ cpu: 256
1818
memory: 512
1919

2020
on:
21-
# The scheduled trigger for your job. You can specify a cron schedule or keyword (@weekly) or a rate (2h, 1h30m, 15m)
21+
# The scheduled trigger for your job. You can specify a Unix cron schedule or keyword (@weekly) or a rate (@every 1h30m)
2222
# AWS Schedule Expressions are also accepted: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html
2323
schedule: "@every 5h"
2424

templates/workloads/jobs/scheduled-job/manifest.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ cpu: {{.CPU}}
2424
memory: {{.Memory}}
2525

2626
on:
27-
# The scheduled trigger for your job. You can specify a cron schedule or keyword (@weekly) or a rate (2h, 1h30m, 15m)
27+
# The scheduled trigger for your job. You can specify a Unix cron schedule or keyword (@weekly) or a rate (@every 1h30m)
2828
# AWS Schedule Expressions are also accepted: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/ScheduledEvents.html
2929
schedule: "{{.On.Schedule}}"
3030

0 commit comments

Comments
 (0)