chore(cli): limit pipeline delete to prompt about deleting secret only when secret exists (#1880)

Now that there are non-GitHub source options, there will be pipeline sources without secrets. `pipeline delete` should prompt "Are you sure you want to delete the source secret...?" only when there is a secret. 

Fixes #1827.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Author: huanjani

internal/pkg/cli/pipeline_delete.go

@@ -153,6 +153,9 @@ func (o *deletePipelineOpts) readPipelineManifest() error {
 }
 
 func (o *deletePipelineOpts) deleteSecret() error {
+	if o.PipelineSecret == "" {
+		return nil
+	}
 	if !o.shouldDeleteSecret {
 		confirmDeletion, err := o.prompt.Confirm(
 			fmt.Sprintf(pipelineSecretDeleteConfirmPrompt, o.PipelineSecret, o.PipelineName),

internal/pkg/cli/pipeline_delete_test.go

@@ -191,6 +191,20 @@ func TestDeletePipelineOpts_Execute(t *testing.T) {
 
 		wantedError error
 	}{
+		"skips delete secret confirmation (and deletion attempt) if there is no secret": {
+			inAppName:      testAppName,
+			inPipelineName: testPipelineName,
+			setupMocks: func(mocks deletePipelineMocks) {
+				gomock.InOrder(
+					mocks.secretsmanager.EXPECT().DeleteSecret(gomock.Any()).Times(0),
+					mocks.prog.EXPECT().Start(fmt.Sprintf(fmtDeletePipelineStart, testPipelineName, testAppName)),
+					mocks.deployer.EXPECT().DeletePipeline(testPipelineName).Return(nil),
+					mocks.prog.EXPECT().Stop(log.Ssuccessf(fmtDeletePipelineComplete, testPipelineName, testAppName)),
+				)
+			},
+			wantedError: nil,
+		},
+
 		"skips delete secret confirmation when flag is specified": {
 			deleteSecret:     true,
 			inAppName:        testAppName,