chore: ignore INACTIVE cluster in DefaultCluster (#2045)

When we delete ECS cluster, AWS return it as INACTIVE cluster.

```
INACTIVE
The cluster has been deleted. Clusters with an INACTIVE status may remain discoverable in your account for a period of time. However, this behavior is subject to change in the future, so you should not rely on INACTIVE clusters persisting.
```
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/clusters.html

We can't run task on INACTIVE cluster so we should ignore it.

Author: ota42y

internal/pkg/aws/ecs/ecs.go

@@ -16,6 +16,8 @@ import (
 	"github.com/aws/aws-sdk-go/service/ecs"
 )
 
+const clusterStatusActive = "ACTIVE"
+
 type api interface {
 	DescribeClusters(input *ecs.DescribeClustersInput) (*ecs.DescribeClustersOutput, error)
 	DescribeServices(input *ecs.DescribeServicesInput) (*ecs.DescribeServicesOutput, error)
@@ -195,6 +197,10 @@ func (e *ECS) DefaultCluster() (string, error) {
 
 	// NOTE: right now at most 1 default cluster is possible, so cluster[0] must be the default cluster
 	cluster := resp.Clusters[0]
+	if aws.StringValue(cluster.Status) != clusterStatusActive {
+		return "", ErrNoDefaultCluster
+	}
+
 	return aws.StringValue(cluster.ClusterArn), nil
 }
 

internal/pkg/aws/ecs/ecs_test.go

@@ -422,17 +422,35 @@ func TestECS_DefaultCluster(t *testing.T) {
 							{
 								ClusterArn:  aws.String("arn:aws:ecs:us-east-1:0123456:cluster/cluster1"),
 								ClusterName: aws.String("cluster1"),
+								Status:      aws.String(clusterStatusActive),
 							},
 							{
 								ClusterArn:  aws.String("arn:aws:ecs:us-east-1:0123456:cluster/cluster2"),
 								ClusterName: aws.String("cluster2"),
+								Status:      aws.String(clusterStatusActive),
 							},
 						},
 					}, nil)
 			},
 
 			wantedClusters: "arn:aws:ecs:us-east-1:0123456:cluster/cluster1",
 		},
+		"ignore inactive cluster": {
+			mockECSClient: func(m *mocks.Mockapi) {
+				m.EXPECT().
+					DescribeClusters(&ecs.DescribeClustersInput{}).
+					Return(&ecs.DescribeClustersOutput{
+						Clusters: []*ecs.Cluster{
+							{
+								ClusterArn:  aws.String("arn:aws:ecs:us-east-1:0123456:cluster/cluster1"),
+								ClusterName: aws.String("cluster1"),
+								Status:      aws.String("INACTIVE"),
+							},
+						},
+					}, nil)
+			},
+			wantedError: fmt.Errorf("default cluster does not exist"),
+		},
 		"failed to get default clusters": {
 			mockECSClient: func(m *mocks.Mockapi) {
 				m.EXPECT().
@@ -492,7 +510,10 @@ func TestECS_HasDefaultCluster(t *testing.T) {
 				m.EXPECT().DescribeClusters(&ecs.DescribeClustersInput{}).
 					Return(&ecs.DescribeClustersOutput{
 						Clusters: []*ecs.Cluster{
-							{ClusterArn: aws.String("cluster")},
+							{
+								ClusterArn: aws.String("cluster"),
+								Status:     aws.String(clusterStatusActive),
+							},
 						},
 					}, nil)
 			},