Base64 Encoded JSON Endpoint Rules are quite wasteful #2816
Unanswered
casperisfine
asked this question in
Q&A
Replies: 1 comment 1 reply
-
Thanks for opening up a discussion. Yes, the base64 encoded rules are not ideal. It boils down to rushed deadlines. @alextwoods has a draft to use literals instead. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
We profile our application boot nightly and I discovered what I'd consider a regression after upgrading
aws-sdk
.Firs the Base64 encoding seem like an useless step for what is generated code.
Similarly the JSON parsing, while easier to understand, seem a bit superfluous and cause a lot of duplicated strings for little reasons where a Ruby hash literal would have avoided this.
I managed to track the change to #2741, but I don't understand the rationale.
I'm curious what's the reason for this chance, and whether you'd be open to a PR that would change this for some decoded JSON, or best some Ruby literals?
Beta Was this translation helpful? Give feedback.
All reactions