Skip to content

DataExchange: UpdateRevision is not sending Finalized: false in request #3066

Closed
@johnsonaj

Description

@johnsonaj

Acknowledgements

Describe the bug

When trying to update a "finalized" DataExchange Revision to "de-finalized" the request succeeds but has no change on the revision. We can finalize the revision by setting the Finalized parameter to true but are unable to de-finalize by setting it to false

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

UpdateRevision should be able to finalize and de-finalize a revision.

Current Behavior

UpdateRevision is able to finalize a revision when Finalized is set to true but when set to false the request succeeds but has no effect.

logs show that when Finalized is set to false the request is empty

true

{"Finalized":true}
SDK 2025/04/17 10:07:50 DEBUG Response
HTTP/2.0 200 OK

false

{}
SDK 2025/04/17 10:10:11 DEBUG Response
HTTP/2.0 200 OK

Reproduction Steps

given the following config using an already created revision. Setting Finalized to true works. When set to `false the request body is empty. Cloudtrail shows this request working with both values when done in the console.

func main() {
	ctx := context.Background()

	cfg, err := config.LoadDefaultConfig(ctx,
		config.WithRegion("us-west-2"),
		config.WithClientLogMode(aws.LogRequestWithBody|aws.LogResponse),
	)
	if err != nil {
		log.Fatalf("failed to load configuration, %v", err)
	}

	conn := dataexchange.NewFromConfig(cfg)

	input := dataexchange.UpdateRevisionInput{
		RevisionId: aws.String("revision-id"),
		DataSetId:  aws.String("data-set-id"),
		Finalized:  false,
	}

	_, err = conn.UpdateRevision(ctx, &input)
	if err != nil {
		log.Fatalf(err.Error())
	}
}

Possible Solution

No response

Additional Information/Context

Relates hashicorp/terraform-provider-aws#42272

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2/service/dataexchange v1.34.2

Compiler and Version used

go1.24.2 darwin/arm64

Operating System and version

macOS 15.4.1

Metadata

Metadata

Assignees

Labels

bugThis issue is a bug.p1This is a high priority issue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions