Skip to content

Commit e85cfd5

Browse files
committed
Force to string when assigning the value of new_value and old_value
1 parent 1fea041 commit e85cfd5

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

cli/src/pcluster/api/controllers/cluster_operations_controller.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -455,17 +455,15 @@ def _analyze_changes(changes):
455455

456456
for row in changes[1:]:
457457
parameter = ConfigPatch.build_config_param_path(row[key_indexes["param_path"]], row[key_indexes["parameter"]])
458-
new_value = row[key_indexes["new value"]] if not row[key_indexes["new value"]] is None else "-"
459-
old_value = row[key_indexes["old value"]] if not row[key_indexes["old value"]] is None else "-"
458+
new_value = str(row[key_indexes["new value"]]) if not row[key_indexes["new value"]] is None else "-"
459+
old_value = str(row[key_indexes["old value"]]) if not row[key_indexes["old value"]] is None else "-"
460460
check_result = row[key_indexes["check"]]
461461
message = _create_message(row[key_indexes["reason"]], row[key_indexes["action_needed"]])
462462
if not _cluster_update_change_succeded(check_result):
463463
errors.append(
464-
UpdateError(
465-
parameter=parameter, requested_value=str(new_value), message=message, current_value=str(old_value)
466-
)
464+
UpdateError(parameter=parameter, requested_value=new_value, message=message, current_value=old_value)
467465
)
468-
change_set.append(Change(parameter=parameter, requested_value=str(new_value), current_value=str(old_value)))
466+
change_set.append(Change(parameter=parameter, requested_value=new_value, current_value=old_value))
469467
return change_set, errors
470468

471469

0 commit comments

Comments
 (0)