[PCAPI][Test] Add integration test to validate PCAPI deployment with all custom parameters.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>

Author: gmarciani

tests/integration-tests/configs/develop.yaml

@@ -761,6 +761,9 @@ test-suites:
     test_api_infrastructure.py::test_api_infrastructure_with_default_parameters:
       dimensions:
         - regions: ["ap-south-1", "cn-north-1", "us-gov-west-1"]
+    test_api_infrastructure.py::test_api_infrastructure_with_full_parameters:
+      dimensions:
+        - regions: [ "eu-west-1" ]
     test_api.py::test_cluster_slurm:
       dimensions:
         - regions: ["sa-east-1"]

tests/integration-tests/conftest.py

@@ -1009,6 +1009,14 @@ def api_definition_s3_uri(request, resource_bucket):
     )
 
 
+@pytest.fixture(scope="class")
+def api_permissions_boundary_policy_arn(request, region):
+    """Return the ARN of an IAM permissions boundary to be used with the ParallelCluster API."""
+    arn_partition = get_arn_partition(region)
+    # TODO Restrict the permissions boundary to the minimum set of required permissions
+    return f"arn:{arn_partition}:iam::aws:policy/AdministratorAccess"
+
+
 @pytest.fixture(scope="session")
 def api_infrastructure_s3_uri(request):
     return request.config.getoption("api_infrastructure_s3_uri")

tests/integration-tests/tests/pcluster_api/test_api_infrastructure.py

@@ -63,6 +63,56 @@ def api_with_default_settings(
             factory.delete_all_stacks()
 
 
+@pytest.fixture()
+def api_with_full_settings(
+    api_infrastructure_s3_uri,
+    api_definition_s3_uri,
+    policies_uri,
+    request,
+    region,
+    resource_bucket,
+    api_permissions_boundary_policy_arn,
+):
+    """Deploy the ParallelCluster API infrastructure with all the stack parameters being set"""
+    factory = CfnStacksFactory(request.config.getoption("credential"))
+
+    params = []
+    if api_definition_s3_uri:
+        params.append({"ParameterKey": "ApiDefinitionS3Uri", "ParameterValue": api_definition_s3_uri})
+    if policies_uri:
+        params.append({"ParameterKey": "PoliciesTemplateUri", "ParameterValue": policies_uri})
+    if resource_bucket:
+        params.append({"ParameterKey": "CustomBucket", "ParameterValue": resource_bucket})
+
+    params.append({"ParameterKey": "CreateApiUserRole", "ParameterValue": "true"})
+    params.append({"ParameterKey": "EnableFSxS3Access", "ParameterValue": "true"})
+    params.append({"ParameterKey": "EnableIamAdminAccess", "ParameterValue": "true"})
+    params.append({"ParameterKey": "FsxS3Buckets", "ParameterValue": "*"})
+    params.append({"ParameterKey": "IAMRoleAndPolicyPrefix", "ParameterValue": "abcdefghij"})
+    params.append({"ParameterKey": "PermissionsBoundaryPolicy", "ParameterValue": api_permissions_boundary_policy_arn})
+    params.append({"ParameterKey": "Region", "ParameterValue": region})
+
+    template = (
+        api_infrastructure_s3_uri
+        or f"https://{resource_bucket}.s3.{region}.amazonaws.com{'.cn' if region.startswith('cn') else ''}"
+        f"/parallelcluster/{get_installed_parallelcluster_version()}/api/parallelcluster-api.yaml"
+    )
+    logging.info(f"Creating API Server stack in {region} with template {template}")
+    stack = CfnStack(
+        name=generate_stack_name("integ-tests-api", request.config.getoption("stackname_suffix")),
+        region=region,
+        parameters=params,
+        capabilities=["CAPABILITY_NAMED_IAM", "CAPABILITY_AUTO_EXPAND"],
+        template=template,
+    )
+    try:
+        factory.create_stack(stack)
+        yield stack
+    finally:
+        if not request.config.getoption("no_delete"):
+            factory.delete_all_stacks()
+
+
 def test_api_infrastructure_with_default_parameters(region, api_with_default_settings):
     """Test that creating the API Infrastructure stack with the defaults correctly sets up the Lambda and APIGateway API
 
@@ -82,6 +132,27 @@ def test_api_infrastructure_with_default_parameters(region, api_with_default_set
     _test_api_deletion(api_with_default_settings)
 
 
+def test_api_infrastructure_with_full_parameters(region, api_with_full_settings):
+    """
+    Test that creating the API Infrastructure stack with the all the parameters being set with custom values
+    correctly sets up the Lambda and APIGateway API
+
+    :param region: the region where the stack is run
+    :api_with_full_settings: factory that deploys a ParallelCluster API
+    """
+    parallelcluster_lambda_name = api_with_full_settings.cfn_resources["ParallelClusterFunction"]
+    parallelcluster_lambda_arn = api_with_full_settings.cfn_outputs["ParallelClusterLambdaArn"]
+
+    parallelcluster_api_id = api_with_full_settings.cfn_resources["ApiGatewayApiWithoutCustomDomain"]
+    parallelcluster_api_url = api_with_full_settings.cfn_outputs["ParallelClusterApiInvokeUrl"]
+    parallelcluster_user_role = api_with_full_settings.cfn_outputs["ParallelClusterApiUserRole"]
+
+    _assert_parallelcluster_lambda(lambda_name=parallelcluster_lambda_name, lambda_arn=parallelcluster_lambda_arn)
+    _assert_parallelcluster_api(api_id=parallelcluster_api_id, api_url=parallelcluster_api_url)
+    _test_auth(region, parallelcluster_user_role, parallelcluster_api_url)
+    _test_api_deletion(api_with_full_settings)
+
+
 def _assert_parallelcluster_lambda(lambda_name, lambda_arn):
     """Check that the ParallelCluster Lambda is correctly configured