Skip to content

Commit d455bdd

Browse files
hanwen-clusterhanwen-pcluste
authored andcommitted
Use CloudFormation pseudo-parameter to get stack name
We want the stack name to be decoded at CloudFormation deploy time, instead of template generate time. Signed-off-by: Hanwen <hanwenli@amazon.com>
1 parent 84c67cd commit d455bdd

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

cloudformation/external-slurmdbd/external_slurmdbd/external_slurmdbd_stack.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import json
33

44
import pkg_resources
5-
from aws_cdk import CfnOutput, CfnParameter, Fn, Stack
5+
from aws_cdk import Aws, CfnOutput, CfnParameter, Fn, Stack
66
from aws_cdk import aws_autoscaling as autoscaling
77
from aws_cdk import aws_ec2 as ec2
88
from aws_cdk import aws_iam as iam
@@ -122,7 +122,7 @@ def _add_cfn_init_config(self):
122122
"cluster": {
123123
"region": self.region,
124124
"log_group_name": self._log_group.log_group_name,
125-
"stack_name": self.stack_name,
125+
"stack_name": Aws.STACK_NAME,
126126
"node_type": "ExternalSlurmDbd",
127127
},
128128
}
@@ -276,7 +276,7 @@ def _add_external_slurmdbd_launch_template(self):
276276
{
277277
**{
278278
"CustomCookbookUrl": self.custom_cookbook_url_param.value_as_string,
279-
"StackName": self.stack_name,
279+
"StackName": Aws.STACK_NAME,
280280
"Region": self.region,
281281
"PrivateIp": self.slurmdbd_private_ip.value_as_string,
282282
"SubnetPrefix": self.slurmdbd_private_prefix.value_as_string,
@@ -409,7 +409,7 @@ def _add_cloudwatch_log_group(self):
409409
log_group_name=Fn.join(
410410
"-",
411411
[
412-
f"/aws/parallelcluster/external-slurmdbd/{self.stack_name}",
412+
f"/aws/parallelcluster/external-slurmdbd/{Aws.STACK_NAME}",
413413
Fn.select(4, Fn.split("-", Fn.select(2, Fn.split("/", self.stack_id)))),
414414
],
415415
),
@@ -420,7 +420,7 @@ def _add_s3_bucket(self):
420420
return s3.CfnBucket(
421421
self,
422422
id="ExternalSlurmdbdS3Bucket",
423-
bucket_name=self.stack_name.lower() + "-" + hashlib.sha256((self.account + self.region).encode()).hexdigest()[0:16],
423+
bucket_name=Aws.STACK_NAME + "-" + hashlib.sha256((self.account + self.region).encode()).hexdigest()[0:16],
424424
public_access_block_configuration=s3.CfnBucket.PublicAccessBlockConfigurationProperty(
425425
block_public_acls=True,
426426
block_public_policy=True,

0 commit comments

Comments
 (0)