Skip to content

Commit bb9f482

Browse files
committed
Remove mpi job termination check from test in private network
This is a flacky check that is randomly failing when testing LoginNodes in a private network. Since this test in unrelated to the behavior under test we can safely remove this check from the test. Signed-off-by: Nicola Sirena <nssirena@amazon.com>
1 parent 40f6e20 commit bb9f482

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

tests/integration-tests/tests/schedulers/test_slurm.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -203,9 +203,6 @@ def test_slurm_from_login_nodes_in_private_network(
203203
scaledown_idletime = 3
204204
gpu_instance_type = "g3.4xlarge"
205205
gpu_instance_type_info = get_instance_info(gpu_instance_type, region)
206-
# For OSs running _test_mpi_job_termination, spin up 2 compute nodes at cluster creation to run test
207-
# Else do not spin up compute node and start running regular slurm tests
208-
supports_impi = architecture == "x86_64"
209206
compute_node_bootstrap_timeout = 1600
210207
cluster_config = pcluster_config_reader(
211208
scaledown_idletime=scaledown_idletime,
@@ -221,9 +218,6 @@ def test_slurm_from_login_nodes_in_private_network(
221218
assert "/opt/slurm" == slurm_root_path
222219
slurm_commands = scheduler_commands_factory(remote_command_executor)
223220

224-
if supports_impi:
225-
_test_mpi_job_termination(remote_command_executor, test_datadir, slurm_commands, region, cluster)
226-
227221
_assert_no_node_in_cluster(region, cluster.cfn_name, slurm_commands)
228222
_test_job_dependencies(slurm_commands, region, cluster.cfn_name, scaledown_idletime)
229223
_test_job_arrays_and_parallel_jobs(

0 commit comments

Comments
 (0)