Unset proxies in test_runner (#6035)

* Unset proxies in test_runner

Signed-off-by: Judy Ng <njud@amazon.com>

* [Code Quality] Ignore bandit rules B036 and B038.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>

---------

Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
Co-authored-by: Giacomo Marciani <mgiacomo@amazon.com>

Author: judysng

cli/tests/pcluster/models/test_cluster_resources.py

@@ -62,7 +62,7 @@ def test_initialization_success(self, mock_head_node, filters, expected_filters_
         logs_filters = ClusterLogsFiltersParser(mock_head_node, filters)
 
         for attr in expected_attrs:
-            assert_that(getattr(logs_filters, attr)).is_equal_to(expected_attrs.get(attr))
+            assert_that(getattr(logs_filters, attr)).is_equal_to(expected_attrs.get(attr))  # noqa: B038
         assert_that(expected_filters_size).is_equal_to(len(logs_filters.filters_list))
 
     @pytest.mark.parametrize(
@@ -149,7 +149,7 @@ def test_initialization_success(self, mock_head_node, params, expected_attrs):
         )
 
         for attr in expected_attrs:
-            assert_that(getattr(export_logs_filters, attr)).is_equal_to(expected_attrs.get(attr))
+            assert_that(getattr(export_logs_filters, attr)).is_equal_to(expected_attrs.get(attr))  # noqa: B038
 
     @pytest.mark.parametrize(
         "attrs, event_in_window, expected_error",

cli/tests/pcluster/models/test_common.py

@@ -74,7 +74,7 @@ def test_initialization_success(self, params, expected_attrs):
         )
 
         for attr in expected_attrs:
-            assert_that(getattr(export_logs_filters, attr)).is_equal_to(expected_attrs.get(attr))
+            assert_that(getattr(export_logs_filters, attr)).is_equal_to(expected_attrs.get(attr))  # noqa: B038
 
     @pytest.mark.parametrize(
         "attrs, event_in_window, log_stream_prefix, expected_error",

tests/integration-tests/test_runner.py

@@ -762,6 +762,14 @@ def _check_args(args):
             raise argparse.ArgumentTypeError("'{0}' is not a valid test config".format(args.tests_config))
 
 
+def unset_proxies():
+    """Unset proxies"""
+    os.environ.pop("HTTP_PROXY", None)
+    os.environ.pop("HTTPS_PROXY", None)
+    os.environ.pop("http_proxy", None)
+    os.environ.pop("https_proxy", None)
+
+
 def _run_sequential(args):
     # Redirect stdout to file
     if not args.show_output:
@@ -788,6 +796,9 @@ def main():
     _check_args(args)
     logger.info("Parsed test_runner parameters {0}".format(args))
 
+    # Unset any proxies used to avoid network issues with tests, such as DCV
+    unset_proxies()
+
     _make_logging_dirs(args.output_dir)
 
     if args.sequential:

tests/integration-tests/tests/performance_tests/plotting/performance_tests_plots.py

@@ -50,7 +50,7 @@ def generate_plots(datadir, outdir, configurations, nodes):
         # Box Plots
         box_plots = {}
         for configuration in configurations:
-            positions = all_positions[configurations.index(configuration) :: n_configurations]  # noqa: E203
+            positions = all_positions[configurations.index(configuration) :: n_configurations]  # noqa: E203, B038
             box_plots[configuration] = ax.boxplot(
                 data[configuration],
                 patch_artist=True,

tests/integration-tests/tests/storage/snapshots_factory.py

@@ -157,7 +157,7 @@ def _open_ssh_connection(self):
                 )
                 ssh_conn.open()
                 tries = 0
-            except BaseException:
+            except BaseException:  # noqa: B036
                 logging.info("SSH connection error - retrying...")
                 tries -= 1
                 time.sleep(20)