Skip to content

Commit 5d07c67

Browse files
authored
[Subnet Prioritization] Support the new Integeration test (#6915)
* [Subnet Prioritization] Add the new integ test as part of the daily integration test set * [Subnet Prioritization] Fix format issue in develop.yaml
1 parent 3808cac commit 5d07c67

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

tests/integration-tests/configs/develop.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,12 @@ test-suites:
340340
instances: {{ common.INSTANCES_DEFAULT_X86 }}
341341
oss: [{{ OS_X86_1 }}]
342342
schedulers: ["slurm"]
343+
test_cluster_networking.py::test_cluster_with_subnet_prioritization:
344+
dimensions:
345+
- regions: [ "us-east-2" ]
346+
instances: [ "t3.large" ]
347+
oss: [{{ OS_X86_1 }}]
348+
schedulers: [ "slurm" ]
343349
test_networking.py::test_public_network_topology:
344350
dimensions:
345351
- regions: ["af-south-1", "us-gov-east-1", "cn-northwest-1"]

tests/integration-tests/tests/networking/test_cluster_networking.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -257,13 +257,12 @@ def test_cluster_with_subnet_prioritization(
257257
queues = ["queue1", "queue2"]
258258
logging.info(f"Public subnets: {public_subnets}")
259259
# Check that all instances are launched in the subnet with the highest priority
260-
with soft_assertions():
261-
for queue in queues:
262-
scheduler_commands.submit_command("sleep 60", nodes=5, partition=queue)
263-
wait_for_num_instances_in_queue(cluster.cfn_name, cluster.region, desired=5, queue=queue)
260+
for queue in queues:
261+
scheduler_commands.submit_command("sleep 60", nodes=5, partition=queue)
262+
wait_for_num_instances_in_queue(cluster.cfn_name, cluster.region, desired=5, queue=queue)
264263

265-
subnet_ids = get_compute_nodes_subnet_ids(cluster.cfn_name, region, node_type="Compute", queue_name=queue)
266-
logging.info(f"Subnets: {subnet_ids}")
264+
subnet_ids = get_compute_nodes_subnet_ids(cluster.cfn_name, region, node_type="Compute", queue_name=queue)
265+
with soft_assertions():
267266
for subnet_id in subnet_ids:
268267
assert_that(subnet_id).is_equal_to(public_subnets[0])
269268

0 commit comments

Comments
 (0)