Update unit tests

Author: hgreebe

cli/src/pcluster/api/controllers/cluster_operations_controller.py

@@ -461,7 +461,9 @@ def _analyze_changes(changes):
         message = _create_message(row[key_indexes["reason"]], row[key_indexes["action_needed"]])
         if not _cluster_update_change_succeded(check_result):
             errors.append(
-                UpdateError(parameter=parameter, requested_value=str(new_value), message=message, current_value=str(old_value))
+                UpdateError(
+                    parameter=parameter, requested_value=str(new_value), message=message, current_value=str(old_value)
+                )
             )
         change_set.append(Change(parameter=parameter, requested_value=str(new_value), current_value=str(old_value)))
     return change_set, errors

cli/tests/pcluster/api/controllers/test_cluster_operations_controller.py

@@ -1969,9 +1969,9 @@ def test_dryrun(self, mocker, client, errors):
             "message": "Request would have succeeded, but DryRun flag is set.",
             "changeSet": [
                 {
-                    "currentValue": 10,
+                    "currentValue": "10",
                     "parameter": "Scheduling.SlurmQueues[queue0].ComputeResources[queue0-i0].MaxCount",
-                    "requestedValue": 11,
+                    "requestedValue": "11",
                 }
             ],
         }
@@ -2460,10 +2460,12 @@ def test_cluster_update_change_succeded(check_result):
                 ],
             ],
             "-",
-            {
-                "ComputeResources": [{"InstanceType": "c5.9xlarge", "MinCount": 0, "Name": "compute2"}],
-                "Name": "queue2",
-            },
+            str(
+                {
+                    "Name": "queue2",
+                    "ComputeResources": [{"Name": "compute2", "InstanceType": "c5.9xlarge", "MinCount": 0}],
+                }
+            ),
         ),
         (
             [
@@ -2491,10 +2493,12 @@ def test_cluster_update_change_succeded(check_result):
                     "COMPUTE_FLEET_STOP_ON_REMOVE",
                 ],
             ],
-            {
-                "ComputeResources": [{"InstanceType": "c5.xlarge", "MinCount": 0, "Name": "compute1"}],
-                "Name": "queue1",
-            },
+            str(
+                {
+                    "Name": "queue1",
+                    "ComputeResources": [{"Name": "compute1", "InstanceType": "c5.xlarge", "MinCount": 0}],
+                }
+            ),
             "-",
         ),
     ],

tests/integration-tests/tests/pcluster_api/test_api.py

@@ -23,7 +23,6 @@
 from botocore.config import Config
 from cfn_stacks_factory import CfnStack
 from clusters_factory import Cluster, ClustersFactory
-from pcluster_client import ApiException
 from pcluster_client.api import (
     cluster_compute_fleet_api,
     cluster_instances_api,