Address code linter issues

Pylint released a new version with a new check on potentially unassigned
variables in if/else branches.

Checked that the affected variables are useful in only one of the branches
and disabled the linter for those specific lines.

Signed-off-by: Jacopo De Amicis <jdamicis@amazon.it>

Author: jdeamicis

awsbatch-cli/src/awsbatch/awsbstat.py

@@ -296,7 +296,7 @@ def run(self, job_status, expand_children, job_queue=None, job_ids=None, show_de
             fail("Error listing jobs from AWS Batch. job_ids or job_queue must be defined")
 
         sort_keys_function = self.__sort_by_status_startedat_jobid() if not job_ids else self.__sort_by_key(job_ids)
-        if details_required:
+        if details_required:  # pylint: disable=E0606
             self.output.show(sort_keys_function=sort_keys_function)
         else:
             self.output.show_table(

awsbatch-cli/src/awsbatch/awsbsub.py

@@ -245,7 +245,7 @@ def _upload_and_get_command(boto3_factory, args, job_s3_folder, job_name, config
         command = [args.command] + args.arguments
     else:
         fail("Unexpected error. Command cannot be empty.")
-    log.info("Command: %s" % shell_join(command))
+    log.info("Command: %s" % shell_join(command))  # pylint: disable=E0606
     return command
 
 

cli/src/pcluster/cli/commands/dcv_connect.py

@@ -117,7 +117,10 @@ def _retrieve_dcv_session_url(ssh_cmd, cluster_name, head_node_ip):
             raise DCVConnectionError(e.output)
 
     return "https://{IP}:{PORT}?authToken={TOKEN}#{SESSION_ID}".format(
-        IP=head_node_ip, PORT=dcv_server_port, TOKEN=dcv_session_token, SESSION_ID=dcv_session_id
+        IP=head_node_ip,
+        PORT=dcv_server_port,  # pylint: disable=E0606
+        TOKEN=dcv_session_token,  # pylint: disable=E0606
+        SESSION_ID=dcv_session_id,  # pylint: disable=E0606
     )
 
 

cli/src/pcluster/validators/directory_service_validators.py

@@ -92,7 +92,11 @@ def _validate(self, password_secret_arn: str, region: str):
                 resource_type = resource.split("/")[0]
             if service == "secretsmanager" and resource == "secret":
                 AWSApi.instance().secretsmanager.describe_secret(password_secret_arn)
-            elif service == "ssm" and resource_type == "parameter" and region == "us-isob-east-1":
+            elif (
+                service == "ssm"
+                and resource_type == "parameter"  # pylint: disable=E0606
+                and region == "us-isob-east-1"
+            ):
                 parameter_name = resource.split("/")[1]
                 AWSApi.instance().ssm.get_parameter(parameter_name)
             else: