Skip to content

Support awscrt v0.28.2 #9801

@carlsmedstad

Description

@carlsmedstad

Describe the feature

In awscrt v0.28.2, the io.init_logging() function can only be called once per process. Subsequent calls raise AWS_ERROR_INVALID_STATE.
See: awslabs/aws-crt-python@795f3fd

The above breaks the test suite completely, due to awscrt.io.init_logging() being called in the fixture clear_loggers.

Use Case

Packaging aws-cli for Arch Linux.

Proposed Solution

A quick-fix would be to make subsequent calls to enable_crt_logging()/disable_crt_logging() no-ops. Gave that a try here: carlsmedstad@0eaa376
But that might break the disabling of logging for the autoprompt, not sure:

$ rg disable_crt_logging awscli/autoprompt/prompttoolkit.py
28:from awscli.logger import LOG_FORMAT, disable_crt_logging
239:            disable_crt_logging()

Other Information

I package most things AWS for Arch Linux.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

2.31.18

Environment details (OS name and version, etc.)

Arch Linux

Metadata

Metadata

Labels

dependenciesThis issue is a problem in a dependency.feature-requestA feature should be added or improved.investigatingThis issue is being investigated and/or work is in progress to resolve the issue.p3This is a minor priority issue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions