Skip to content

Diff and security diff during deploy #33435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 3 tasks
mrgrain opened this issue Feb 13, 2025 · 2 comments · Fixed by aws/aws-cdk-cli#437
Closed
1 of 3 tasks

Diff and security diff during deploy #33435

mrgrain opened this issue Feb 13, 2025 · 2 comments · Fixed by aws/aws-cdk-cli#437
Assignees
@kaizencc
Labels
@aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Feb 13, 2025 •
edited by kaizencc
Loading

We currently do not send a message for the diff on deploy, only if we need to confirm approval.

We should send

  • a info message with the formatted security diff
  • a request response with the full diff to confirm
  • require approval should move into the CliIoHost
@mrgrain mrgrain self-assigned this Feb 13, 2025
@mrgrain mrgrain changed the title Re look at security diff Diff and security diff during deploy Feb 13, 2025
@mrgrain mrgrain removed their assignment Feb 13, 2025
@pahud pahud added feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort p1 @aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI labels Feb 14, 2025
@kaizencc kaizencc self-assigned this Feb 25, 2025
@github-actions github-actions bot mentioned this issue Mar 1, 2025
Open
@kaizencc
Copy link
Contributor

aws/aws-cdk-cli#151 -> require approval in cliiohost

@kaizencc kaizencc mentioned this issue Apr 30, 2025
Merged
github-merge-queue bot pushed a commit to aws/aws-cdk-cli that referenced this issue May 6, 2025
@kaizencc
feat(toolkit-lib): deploy prompt prints security diff and returns tem…
366e284 
…plate diff (#437)

closes aws/aws-cdk#33435

Does the following:

- sends the formatted security diff in the request response
- returns the full diff to in the request response

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <github-actions@github.com>
Co-authored-by: github-actions <github-actions@github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kaizencc kaizencc

Labels
@aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(toolkit-lib): deploy prompt prints security diff and returns template diff aws/aws-cdk-cli
3 participants
@pahud @mrgrain @kaizencc