Skip to content

Commit 3bd2eaa

Browse files
authored
Move duplicate awsrulesfn package to the ecs-agent module (#4661)
* remove duplicate awsrulesfn to ecs-agent * go mod
1 parent 1231939 commit 3bd2eaa

File tree

17 files changed

+536
-5
lines changed

17 files changed

+536
-5
lines changed

agent/engine/serviceconnect/manager_linux.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import (
2626
apicontainer "github.com/aws/amazon-ecs-agent/agent/api/container"
2727
apiserviceconnect "github.com/aws/amazon-ecs-agent/agent/api/serviceconnect"
2828
apitask "github.com/aws/amazon-ecs-agent/agent/api/task"
29-
"github.com/aws/amazon-ecs-agent/agent/awsrulesfn"
3029
"github.com/aws/amazon-ecs-agent/agent/config"
3130
"github.com/aws/amazon-ecs-agent/agent/dockerclient/dockerapi"
3231
"github.com/aws/amazon-ecs-agent/agent/taskresource"
@@ -35,6 +34,7 @@ import (
3534
apicontainerstatus "github.com/aws/amazon-ecs-agent/ecs-agent/api/container/status"
3635
"github.com/aws/amazon-ecs-agent/ecs-agent/api/ecs"
3736
apitaskstatus "github.com/aws/amazon-ecs-agent/ecs-agent/api/task/status"
37+
"github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn"
3838
"github.com/aws/amazon-ecs-agent/ecs-agent/ipcompatibility"
3939
"github.com/aws/amazon-ecs-agent/ecs-agent/logger"
4040
"github.com/aws/amazon-ecs-agent/ecs-agent/logger/field"

agent/taskresource/volume/dockervolume_efs.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ import (
1717
"fmt"
1818
"strconv"
1919

20-
"github.com/aws/amazon-ecs-agent/agent/awsrulesfn"
2120
"github.com/aws/amazon-ecs-agent/agent/config"
21+
"github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn"
2222

2323
"github.com/cihub/seelog"
2424
)

agent/vendor/modules.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ github.com/aws/amazon-ecs-agent/ecs-agent/api/errors
2525
github.com/aws/amazon-ecs-agent/ecs-agent/api/task/status
2626
github.com/aws/amazon-ecs-agent/ecs-agent/async
2727
github.com/aws/amazon-ecs-agent/ecs-agent/async/mocks
28+
github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn
2829
github.com/aws/amazon-ecs-agent/ecs-agent/config
2930
github.com/aws/amazon-ecs-agent/ecs-agent/credentials
3031
github.com/aws/amazon-ecs-agent/ecs-agent/credentials/mocks

ecs-init/config/awsrulesfn/partitions.gen.go renamed to ecs-agent/awsrulesfn/awspartition.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,14 @@ package awsrulesfn
22

33
import "regexp"
44

5-
// aws-sdk-go-v2 does not export partition metadata, so copy the files from vendor to make it accessible.
5+
const (
6+
// Partition identifiers
7+
AwsPartitionID = "aws" // AWS Standard partition.
8+
AwsCnPartitionID = "aws-cn" // AWS China partition.
9+
AwsUsGovPartitionID = "aws-us-gov" // AWS GovCloud (US) partition.
610

7-
//go:generate cp ../../vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partition.go ../../vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.go .
11+
DnsSuffix = "amazonaws.com" // Default DNS suffix for AWS Standard partition.
12+
)
813

914
// GetPartitionForRegion returns an AWS partition for the region provided.
1015
// Unlike GetPartition, this function
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package awsrulesfn
2+
3+
// aws-sdk-go-v2 does not export partition metadata, so copy the files from vendor to make it accessible.
4+
//go:generate bash -c "echo '// Code generated by go generate; DO NOT EDIT.' > partition.go && cat ../vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partition.go >> partition.go"
5+
//go:generate bash -c "echo '// Code generated by go generate; DO NOT EDIT.' > partitions.go && cat ../vendor/github.com/aws/aws-sdk-go-v2/internal/endpoints/awsrulesfn/partitions.go >> partitions.go"

ecs-init/config/awsrulesfn/partition.go renamed to ecs-agent/awsrulesfn/partition.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ecs-init/config/awsrulesfn/partitions.go renamed to ecs-agent/awsrulesfn/partitions.go

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ecs-init/config/common.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"strconv"
2323
"strings"
2424

25-
"github.com/aws/amazon-ecs-agent/ecs-init/config/awsrulesfn"
25+
"github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn"
2626
"github.com/cihub/seelog"
2727
godocker "github.com/fsouza/go-dockerclient"
2828
"github.com/pkg/errors"

ecs-init/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn/awspartition.go

Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ecs-init/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn/generate_partitions.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ecs-init/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/awsrulesfn/partition.go

Lines changed: 77 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)