Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit ef24413

Browse files
authored
Release/1.8.1 (#1011)
* chore: add object ownership to S3 buckets * doc: update the CHANGELOG.md file
1 parent 58dfe6e commit ef24413

16 files changed

+864
-2353
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.8.1] - 2023-05-01
9+
10+
- Update our CDK code in PDoA v1.8 to turn on S3 ACLs. They are [no longer on by default](https://aws.amazon.com/it/about-aws/whats-new/2022/12/amazon-s3-automatically-enable-block-public-access-disable-access-control-lists-buckets-april-2023/) as of April 2023
11+
812
## [1.8.0] - 2022-11-21
913

1014
- Settings page enhancement

backend/package-lock.json

Lines changed: 33 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "performance-dashboard-backend",
3-
"version": "1.8.0",
3+
"version": "1.8.1",
44
"description": "Performance Dashboard on AWS Backend",
55
"license": "Apache-2.0",
66
"awssdkUserAgent": "AwsSolution/SO0157/v",

buildspec.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: 0.2
33
phases:
44
install:
55
runtime-versions:
6-
nodejs: 14
6+
nodejs: 16
77
commands:
88
- ls -al
99
- npm --version

cdk/lib/constructs/contentstorage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import * as cdk from "@aws-cdk/core";
77
import * as s3 from "@aws-cdk/aws-s3";
8-
import { BucketAccessControl } from "@aws-cdk/aws-s3";
8+
import { ObjectOwnership } from "@aws-cdk/aws-s3";
99
import { Effect, PolicyStatement, AnyPrincipal } from "@aws-cdk/aws-iam";
1010

1111
interface Props {
@@ -22,7 +22,7 @@ export class ContentStorage extends cdk.Construct {
2222
encryption: s3.BucketEncryption.S3_MANAGED,
2323
versioned: true,
2424
serverAccessLogsPrefix: "access_logs/",
25-
accessControl: BucketAccessControl.LOG_DELIVERY_WRITE,
25+
objectOwnership: ObjectOwnership.OBJECT_WRITER,
2626

2727
/**
2828
* Ideally, one would leave the bucket name to be autogenerated by CF. But

cdk/lib/constructs/datastorage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import * as cdk from "@aws-cdk/core";
77
import * as s3 from "@aws-cdk/aws-s3";
8-
import { BucketAccessControl } from "@aws-cdk/aws-s3";
8+
import { ObjectOwnership } from "@aws-cdk/aws-s3";
99
import { Effect, PolicyStatement, AnyPrincipal } from "@aws-cdk/aws-iam";
1010

1111
interface Props {
@@ -22,7 +22,7 @@ export class DatasetStorage extends cdk.Construct {
2222
encryption: s3.BucketEncryption.S3_MANAGED,
2323
versioned: true,
2424
serverAccessLogsPrefix: "access_logs/",
25-
accessControl: BucketAccessControl.LOG_DELIVERY_WRITE,
25+
objectOwnership: ObjectOwnership.OBJECT_WRITER,
2626

2727
/**
2828
* Ideally, one would leave the bucket name to be autogenerated by CF. But

cdk/lib/dashboardexamples-stack.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import * as cdk from "@aws-cdk/core";
77
import * as lambda from "@aws-cdk/aws-lambda";
88
import s3Deploy = require("@aws-cdk/aws-s3-deployment");
99
import * as s3 from "@aws-cdk/aws-s3";
10+
import { ObjectOwnership } from "@aws-cdk/aws-s3";
1011
import { ExampleDashboardLambda } from "./constructs/exampledashboardlambda";
1112
import customResource = require("@aws-cdk/custom-resources");
1213

@@ -35,6 +36,7 @@ export class DashboardExamplesStack extends cdk.Stack {
3536
const exampleBucket = new s3.Bucket(this, "ExampleBucket", {
3637
encryption: s3.BucketEncryption.S3_MANAGED,
3738
versioned: false,
39+
objectOwnership: ObjectOwnership.OBJECT_WRITER,
3840
});
3941

4042
const lambdas = new ExampleDashboardLambda(

cdk/lib/frontend-stack.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import lambda = require("@aws-cdk/aws-lambda");
1212
import iam = require("@aws-cdk/aws-iam");
1313
import logs = require("@aws-cdk/aws-logs");
1414
import { HttpHeaders } from "@cloudcomponents/cdk-lambda-at-edge-pattern";
15-
import { BucketAccessControl } from "@aws-cdk/aws-s3";
15+
import { ObjectOwnership } from "@aws-cdk/aws-s3";
1616

1717
interface Props extends cdk.StackProps {
1818
datasetsBucket: string;
@@ -40,7 +40,7 @@ export class FrontendStack extends cdk.Stack {
4040
websiteErrorDocument: "index.html",
4141
encryption: s3.BucketEncryption.S3_MANAGED,
4242
serverAccessLogsPrefix: "access_logs/",
43-
accessControl: BucketAccessControl.LOG_DELIVERY_WRITE,
43+
objectOwnership: ObjectOwnership.OBJECT_WRITER,
4444
});
4545

4646
const httpHeaders = new HttpHeaders(this, "HttpHeaders", {

cdk/package-lock.json

Lines changed: 19 additions & 16 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "performance-dashboard-cdk",
3-
"version": "1.8.0",
3+
"version": "1.8.1",
44
"description": "Performance Dashboard on AWS CDK",
55
"license": "Apache-2.0",
66
"bin": {

deployment/performance-dashboard-on-aws.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"AWSTemplateFormatVersion": "2010-09-09",
3-
"Description": "(SO0157) Performance Dashboard on AWS Solution Implementation v1.8.0",
3+
"Description": "(SO0157) Performance Dashboard on AWS Solution Implementation v1.8.1",
44
"Parameters": {
55
"AdminEmail": {
66
"Type": "String",

0 commit comments

Comments
 (0)