Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit 479937e

Browse files
kharbutli-metamabreuortegaMiguel Abreutrietlu
authored
merge v1.5.0 onto mainline (#827)
* Fix the Save functionality in Edit Table/Chart (#795) * Programatically associate labels with their corresponding component (#797) * Makes interactive legends accessible and programmatically available (#796) * Make interactive legends accessible and programmatically available * Remove unused code * Move common function to a new component * Add aria-role alert for Alert component. (#798) Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Fix numbering logic (#799) Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Move Table of Content position to content view area (#800) * Update Table of Content position to content view area * Align table of content first item with first widget header Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Improve the search functionality's user experience and accessibility (#802) * Add support for persistent search and search accessibility * Add a styles file and move style related settings there. * Improve accessibility of text areas and table buttons (#806) * Miguel.abreu/gtt 1887 move preview below form (#808) * Fix Add/Edit Test form responsive design * Fix Add/Edit Metrics form responsive design * Fix Add/Edit Chart/Table views * Fix Section/Image Add/Edit forms * Minor fix Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Replace content header with h2 (#809) * Replace content header with h2 * Minor fix * Update DashboardHeader.test.tsx.snap Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Update version to 1.4.0 (#807) * Update version to 1.4.0 * Update version to 1.4.0 * GTT-1906: Update minimist version per dependabot (#811) * Update minimist version per dependabot * revert changes to cdk/package-lock.json * Miguel.abreu/gtt 1885 (#812) * Update drag icon and move widget type to the right * Update WidgetList actions layout * Update Metric list layout * minor fix * Add Edit metric functionality * Fix section items margin * Minor fix Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Miguel.abreu/gtt 1899 show full date (#813) * Show dates in short format * Minor fix * Fix translation * Minor fix Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Associate hints with inputs for accessibility (#814) * Move required logic to outside of the react form validation (#815) Co-authored-by: Miguel Abreu <miabreu@amazon.com> * feat: fix search button contrast color (#816) Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Add support for the new table pagination layout (#817) * Add support for pagination * Changes based on review and feedback * Fix examples build process (#819) Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Make pagination more accessible and USWDS compliant (#821) * Improve the layout of the add/edit metric screen (#822) * Improve the layout of the add/edit metric screen * Changes based on reviewer's feedback * Fixes * Update Combobox.test.tsx.snap * Update Combobox.test.tsx.snap * Miguel.abreu/gtt 1920 refactor publish workflow (#823) * fix: security alert https://github.com/awslabs/performance-dashboard-on-aws/security/dependabot/50 * feature: create publish dashboard modal * chore: remove pending views and functionality * fix: mobile layout for publish dashboard modal Co-authored-by: Miguel Abreu <miabreu@amazon.com> * Add a hover state to tabs and make topic areas hidden by default (#824) * Add hover state to tabs and make topic areas hidden by default * Add hover state to vertical tabs * Release 1.5.0 * Update CHANGELOG.md * Update README.md Co-authored-by: Miguel Alfonso Abreu Ortega <mabreuortega@gmail.com> Co-authored-by: Miguel Abreu <miabreu@amazon.com> Co-authored-by: Triet <triet05@gmail.com>
1 parent 3c67029 commit 479937e

File tree

133 files changed

+2540
-3772
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

133 files changed

+2540
-3772
lines changed

‎CHANGELOG.md

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,27 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.5.0] - 2022-06-08
9+
10+
- Made improvements to meet WCAG accessibility requirements
11+
- Pagination
12+
- Fix contrast colors in multiple components
13+
- Associate hints with inputs
14+
- Improve accessibility of text areas and table buttons
15+
- Improve the search functionality's user experience and accessibility
16+
- Add aria-role alert for Alert component
17+
- Makes interactive legends accessible and programmatically available
18+
- Add programmatic status messages to tables
19+
- Make modal experience more accessible
20+
- Add a hover state to tabs and make topic areas hidden by default
21+
- Improve the layout of the add/edit metric screen
22+
- Add support for the new table pagination layout
23+
- Fix numbering logic
24+
- Fix the Save functionality in Edit Table/Chart
25+
- Perform html escape on the returned error message
26+
- Improves the UX for the CheckData component
27+
- Updated dependency libraries to address potential security vulnerabilities
28+
829
## [1.3.0] - 2022-03-07
930

1031
- Made improvements to meet WCAG accessibility requirements

‎README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ PDoA comes with pre-built code to provision an instance in your AWS account. You
3333

3434
| Region | Launch |
3535
| -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
36-
| Install in us-east-1 | [![Install in us-east-1](docs/images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.3.0/performance-dashboard-on-aws.template) |
36+
| Install in us-east-1 | [![Install in us-east-1](docs/images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.5.0/performance-dashboard-on-aws.template) |
3737

3838
### Clone this repository
3939

‎backend/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎backend/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "performance-dashboard-backend",
3-
"version": "1.3.0",
3+
"version": "1.5.0",
44
"description": "Performance Dashboard on AWS Backend",
55
"awssdkUserAgent": "AwsSolution/SO0157/v",
66
"scripts": {

‎backend/src/lib/controllers/dashboard-ctrl.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,7 @@ async function publishDashboard(req: Request, res: Response) {
198198
const dashboard = await repo.getDashboardById(id);
199199

200200
if (
201+
dashboard.state !== DashboardState.Draft &&
201202
dashboard.state !== DashboardState.PublishPending &&
202203
dashboard.state !== DashboardState.Archived
203204
) {
@@ -227,6 +228,9 @@ async function publishDashboard(req: Request, res: Response) {
227228
return res.send();
228229
}
229230

231+
/**
232+
* @deprecated Removing the pending state from the dashboard
233+
*/
230234
async function publishPendingDashboard(req: Request, res: Response) {
231235
const user = req.user;
232236
const { id } = req.params;

‎backend/src/lib/models/dashboard.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ export enum DashboardState {
66
Draft = "Draft",
77
Published = "Published",
88
Archived = "Archived",
9+
/**
10+
* @type {string}
11+
* @deprecated in favor of {@link Draft}
12+
*/
913
PublishPending = "PublishPending",
1014
Inactive = "Inactive",
1115
}

‎backend/src/lib/repositories/dashboard-repo.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -297,6 +297,7 @@ class DashboardRepository extends BaseRepository {
297297
/**
298298
* Set a Dashboard identified by the param `dashboardId` to publish pending state.
299299
* Returns the updated dashboard object.
300+
* @deprecated Removing the pending state from the dashboard
300301
*/
301302
public async publishPendingDashboard(
302303
dashboardId: string,

‎backend/src/lib/services/friendlyurl-service.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ async function isFriendlyURLAvailable(
5555
dashboard: Dashboard,
5656
friendlyURL: string
5757
) {
58+
if (friendlyURL.toLowerCase().trim() === "admin") {
59+
return false;
60+
}
5861
try {
5962
const repo = DashboardRepository.getInstance();
6063
const existingDashboard = await repo.getDashboardByFriendlyURL(friendlyURL);

‎cdk/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎cdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "performance-dashboard-cdk",
3-
"version": "1.3.0",
3+
"version": "1.5.0",
44
"description": "Performance Dashboard on AWS CDK",
55
"bin": {
66
"cdk": "bin/main.js"

‎docs/installation.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ If you're not familiar with deploying resources on AWS using CFT, start by revie
2525

2626
| Region | Launch |
2727
| --------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
28-
| US East (N. Virginia) | [![Install in us-east-1](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.3.0/performance-dashboard-on-aws.template) |
28+
| US East (N. Virginia) | [![Install in us-east-1](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.5.0/performance-dashboard-on-aws.template) |
2929

3030
You will be directed to the CloudFormation console on your browser. Enter the stack name such as "MyCorp-PerfDash", and enter the email of the user who will initially administer PDoA in the "adminEmail" field, then press the "Next" button. Accept the default values on the next page, and press the Next button. Finally, check on the two "Capabilities" checkboxes at the bottom of the page. Press the "Create Stack" button. It will take about 25 minutes for the compute, storage, and database resources on AWS to be provisioned.
3131

@@ -41,10 +41,10 @@ If you prefer to deploy PDoA in a region other than US East (N. Virginia), you m
4141

4242
| Region | Launch |
4343
| ----------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
44-
| **Install this first in US East (N. Virginia)** | [![Install this first](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.3.0/LambdaEdge.template) |
45-
| Install PDoA in South America (São Paulo) | [![Install in non US East (N. Virginia) region](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=sa-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.3.0/performance-dashboard-on-aws.template) |
46-
| Install PDoA in Canada (Central) | [![Install in non US East (N. Virginia) region](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=ca-central-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.3.0/performance-dashboard-on-aws.template) |
47-
| Install PDoA in Europe (London) | [![Install in non US East (N. Virginia) region](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=eu-west-2#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.3.0/performance-dashboard-on-aws.template) |
44+
| **Install this first in US East (N. Virginia)** | [![Install this first](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.5.0/LambdaEdge.template) |
45+
| Install PDoA in South America (São Paulo) | [![Install in non US East (N. Virginia) region](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=sa-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.5.0/performance-dashboard-on-aws.template) |
46+
| Install PDoA in Canada (Central) | [![Install in non US East (N. Virginia) region](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=ca-central-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.5.0/performance-dashboard-on-aws.template) |
47+
| Install PDoA in Europe (London) | [![Install in non US East (N. Virginia) region](images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=eu-west-2#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.5.0/performance-dashboard-on-aws.template) |
4848

4949
## Deploying with AWS Cloud Development Kit (CDK)
5050

‎e2e-tests/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎examples/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎examples/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"test:ci": "jest --coverage --ci --passWithNoTests",
99
"build": "npm run clean && tsc && npm run build:backend && npm run install:prod",
1010
"build:backend": "npm run build --prefix ../backend",
11-
"install:prod": "npm install --production --prefix build && rm -rf backend/* && cp -R ../backend/build/* backend/",
11+
"install:prod": "npm install --production --prefix build && mkdir -p ./build/backend && cp -R ../backend/build/* ./build/backend/ && rm ./build/node_modules/performance-dashboard-backend && ln -s $(pwd)/build/backend ./build/node_modules/performance-dashboard-backend",
1212
"clean": "rm -rf build && rm -rf backend",
1313
"export": "ts-node src/export.ts && prettier --write resources",
1414
"import": "ts-node src/import.ts"

0 commit comments

Comments
 (0)