Skip to content

Commit 1c11d1e

Browse files
author
Joshua Leaverton
committed
Version 1.2.1
1 parent b006bd8 commit 1c11d1e

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

CHANGELOG.md

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,9 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
## [1.0.0] - 2020-01-10
8-
### Added
9-
- Initial public release
10-
11-
## [1.1.0] - 2020-02-25
12-
### Known Issue Fix and Code Optimization
13-
- Fixed Stack Instance Deletion Issue: In case there are existing stack instances but
14-
none of those instances belongs to the accounts specified in the user manifest
15-
file as the input for the StackSet state machine, the deletion of the existing
16-
stack instances would fail. This issue is not applicable if at least one account
17-
in the input account list has an existing stack instance.
18-
- Code Optimization for Best Practice
7+
## [1.2.1] - 2020-10-01
8+
### Changed
9+
- Fix the issue related to incompatibility between latest version of BotoCore and AWS CLI. Ref:[Boto3 Issue #2596](https://github.com/boto/boto3/issues/2596)
1910

2011
## [1.2.0] - 2020-06-20
2112
### Added
@@ -30,4 +21,17 @@ in the input account list has an existing stack instance.
3021
- Optimizes the CloudFormation resource stage to trigger step function execution only if there is difference between the configuration and deployed stack sets.
3122
- Fixes the issue in the build stage of the CodePipeline by updating manifest version to match the manifest schema.
3223
- Fixes the issue for comparing deployed stack set templates and parameters [#4](https://github.com/awslabs/aws-control-tower-customizations/issues/4)
33-
- Fixes the issue for updating the variables in the files using Jinja [#17](https://github.com/awslabs/aws-control-tower-customizations/issues/17)
24+
- Fixes the issue for updating the variables in the files using Jinja [#17](https://github.com/awslabs/aws-control-tower-customizations/issues/17)
25+
26+
## [1.1.0] - 2020-02-25
27+
### Known Issue Fix and Code Optimization
28+
- Fixed Stack Instance Deletion Issue: In case there are existing stack instances but
29+
none of those instances belongs to the accounts specified in the user manifest
30+
file as the input for the StackSet state machine, the deletion of the existing
31+
stack instances would fail. This issue is not applicable if at least one account
32+
in the input account list has an existing stack instance.
33+
- Code Optimization for Best Practice
34+
35+
## [1.0.0] - 2020-01-10
36+
### Added
37+
- Initial public release

deployment/custom-control-tower-initiation.template

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,7 @@ Resources:
996996
Effect: "Allow"
997997
Principal:
998998
AWS:
999-
- Fn::Sub: ${StateMachineLambdaRole.Arn}
999+
- Fn::Sub: ${CustomControlTowerStateMachineLambdaRole.Arn}
10001000
- Fn::Sub: ${CustomControlTowerDeploymentLambdaRole.Arn}
10011001
- Fn::Sub: ${CustomControlTowerCodePipelineRole.Arn}
10021002
- Fn::Sub: ${CustomControlTowerCodeBuildRole.Arn}
@@ -1018,7 +1018,7 @@ Resources:
10181018
region: !Sub ${AWS::Region}
10191019
ServiceToken: !GetAtt CustomControlTowerDeploymentLambda.Arn
10201020

1021-
StateMachineLambdaRole:
1021+
CustomControlTowerStateMachineLambdaRole:
10221022
Type: AWS::IAM::Role
10231023
Metadata:
10241024
cfn_nag:
@@ -1030,7 +1030,7 @@ Resources:
10301030
- id: W11
10311031
reason: "Allow Resource * for KMS/SSM/Org/SC/CFN API. Key ID is generated by the service. Other resources are customer defined."
10321032
Properties:
1033-
RoleName: StateMachineLambdaRole
1033+
RoleName: CustomControlTowerStateMachineLambdaRole
10341034
AssumeRolePolicyDocument:
10351035
Version: '2012-10-17'
10361036
Statement:
@@ -1217,7 +1217,7 @@ Resources:
12171217
Description: Custom Control Tower State Machine Handler
12181218
Handler: state_machine_router.lambda_handler
12191219
MemorySize: 1024
1220-
Role: !GetAtt 'StateMachineLambdaRole.Arn'
1220+
Role: !GetAtt 'CustomControlTowerStateMachineLambdaRole.Arn'
12211221
Runtime: python3.8
12221222
Timeout: 300
12231223
TracingConfig:

source/bin/codebuild_scripts/install_stage_dependencies.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ install_common_pip_packages () {
2525
pip install --upgrade yorm
2626
pip install --upgrade jinja2
2727
pip install --upgrade boto3
28+
pip install --upgrade awscli
2829
pip install --upgrade requests
2930
}
3031

0 commit comments

Comments
 (0)