Skip to content

Commit 70fe05d

Browse files
authored
fix: update custom resource name for api router deployment handler (#111)
* fix: update custom resource name for api router deployment handler * fix: update custom resource name for api router deployment handler
1 parent 2970bd6 commit 70fe05d

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

src/emd/cfn/ecs/template.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -386,13 +386,11 @@ Resources:
386386
- Type: forward
387387
TargetGroupArn: !Ref ServiceTargetGroup
388388

389-
ForceAPIRouterDeployment:
390-
Type: Custom::ForceAPIRouterDeployment
389+
ForceApiRouterDeployment:
390+
Type: Custom::ForceApiRouterDeployment
391391
DependsOn: Service
392392
Properties:
393393
ServiceToken: !Ref LambdaDeploymentHelperArn
394-
# Adding a timestamp parameter to ensure this resource is updated when needed
395-
Timestamp: !Ref "AWS::StackName"
396394

397395
Outputs:
398396
Model:

src/emd/cfn/shared/ecs_cluster.yaml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -289,16 +289,16 @@ Resources:
289289
)
290290
291291
if not response['services'] or response['services'][0]['status'] != 'ACTIVE':
292-
raise Exception(f"Service {service_name} not found or not active in cluster {cluster_name}")
293-
294-
# Force a new deployment
295-
ecs_client.update_service(
296-
cluster=cluster_name,
297-
service=service_name,
298-
forceNewDeployment=True
299-
)
292+
response_data = {'Message': f"Service {service_name} not found or not active in cluster {cluster_name}"}
293+
else:
294+
# Force a new deployment
295+
ecs_client.update_service(
296+
cluster=cluster_name,
297+
service=service_name,
298+
forceNewDeployment=True
299+
response_data = {'Message': f"Forced new deployment for {service_name}"}
300+
)
300301
301-
response_data = {'Message': f"Forced new deployment for {service_name}"}
302302
cfnresponse.send(event, context, cfnresponse.SUCCESS, response_data)
303303
except Exception as e:
304304
print(f"Error forcing deployment: {str(e)}")

0 commit comments

Comments
 (0)