fix: minor policy updates for nested stacks

Author: sliedig

Unicorn.Contracts/template.yaml

@@ -12,10 +12,10 @@ Metadata:
     config:
       ignore_checks:
         - ES4000 # Rule disabled because the CatchAll Rule doesn't need a DLQ
-        - ES6000 # Rule disabled because SQS DLOs don't need a RedrivePolicy
+        - ES6000 # Rule disabled because SQS DLQs don't need a RedrivePolicy
         - WS2001 # Rule disabled because check does not support !ToJsonString transform
         - ES1001 # Rule disabled because our Lambda functions don't need DestinationConfig.OnFailure
-        - W3002
+        - W3002 # Rule disabled as nested templates are being packaged 
 
 Parameters:
   Stage:
@@ -437,6 +437,8 @@ Resources:
   # CloudFormation Stack with the Contracts Service Event Registry and Schemas
   EventSchemasStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     Properties:
       Location: "Integration/event-schemas.yaml"
       Parameters:
@@ -445,6 +447,8 @@ Resources:
   # CloudFormation Stack with the Cross-service EventBus policy for Contracts Service
   SubscriberPoliciesStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     DependsOn:
       - UnicornContractsEventBusNameParam
     Properties:

Unicorn.Properties/template.yaml

@@ -12,10 +12,11 @@ Metadata:
     config:
       ignore_checks:
         - ES4000 # Rule disabled because the CatchAll Rule doesn't need a DLQ
-        - ES6000 # Rule disabled because SQS DLOs don't need a RedrivePolicy
+        - ES6000 # Rule disabled because SQS DLQs don't need a RedrivePolicy
         - E0001 # Rule disabled because cfn-lint cannot parse SAM Policy templates without arguments (ComprehendBasicAccessPolicy, RekognitionDetectOnlyPolicy)
         - WS2001 # Rule disabled because check does not support !ToJsonString transform
         - ES1001 # Rule disabled because our Lambda functions don't need DestinationConfig.OnFailure
+        - W3002 # Rule disabled as nested templates are being packaged 
 
 Parameters:
   Stage:
@@ -270,7 +271,7 @@ Resources:
         Level: ALL
         IncludeExecutionData: true
       Events:
-        PubApproReqEvent:
+        PublicationApprovalRequestedEvent:
           Type: EventBridgeRule
           Properties:
             RuleName: unicorn.properties-PublicationApprovalRequested
@@ -448,6 +449,8 @@ Resources:
   # CloudFormation Stack with the Properties Service Event Registry and Schemas
   EventSchemasStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     Properties:
       Location: "Integration/event-schemas.yaml"
       Parameters:
@@ -456,6 +459,8 @@ Resources:
   # CloudFormation Stack with the Cross-service EventBus policy for Properties Service
   SubscriberPoliciesStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     DependsOn:
       - UnicornPropertiesEventBusNameParam
     Properties:
@@ -466,6 +471,8 @@ Resources:
   # CloudFormation Stack with the Cross-service EventBus Rules for Properties Service
   SubscriptionsStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     DependsOn:
       - UnicornPropertiesEventBusArnParam
     Properties:

Unicorn.Web/template.yaml

@@ -12,10 +12,10 @@ Metadata:
     config:
       ignore_checks:
         - ES4000 # Rule disabled because the CatchAll Rule doesn't need a DLQ
-        - ES6000 # Rule disabled because SQS DLOs don't need a RedrivePolicy
+        - ES6000 # Rule disabled because SQS DLQs don't need a RedrivePolicy
         - WS2001 # Rule disabled because check does not support !ToJsonString transform
         - ES1001 # Rule disabled because our Lambda functions don't need DestinationConfig.OnFailure
-        - W3002
+        - W3002 # Rule disabled as nested templates are being packaged 
 
 Parameters:
   Stage:
@@ -424,6 +424,8 @@ Resources:
   # CloudFormation Stack with the Web Service Event Registry and Schemas
   EventSchemasStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     Properties:
       Location: "Integration/event-schemas.yaml"
       Parameters:
@@ -432,6 +434,8 @@ Resources:
   # CloudFormation Stack with the Cross-service EventBus policy for Web Service
   SubscriberPoliciesStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     DependsOn:
       - UnicornWebEventBusParam
     Properties:
@@ -442,6 +446,8 @@ Resources:
   # CloudFormation Stack with the Cross-service EventBus Rules for Web Service
   SubscriptionsStack:
     Type: AWS::Serverless::Application
+    UpdateReplacePolicy: Delete
+    DeletionPolicy: Delete
     DependsOn:
       - UnicornWebEventBusArnParam
     Properties: