Skip to content

Add trace method for decorated styles #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Add trace method for decorated styles #55

merged 3 commits into from
May 23, 2025

Conversation

simlapointe
Copy link
Contributor

Add trace method for decorated styles

@codecov Codecov
Copy link

codecov bot commented May 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@gpeairs
Copy link
Member

gpeairs commented May 23, 2025

Thanks, this method ought to exist and was just overlooked. While we're here, can you do the same thing for width and gap? And I see CompoundStyle forwards extent and width, so it should do the same for trace and gap.

@simlapointe simlapointe marked this pull request as ready for review May 23, 2025 19:00
@simlapointe simlapointe requested a review from gpeairs May 23, 2025 19:00
gpeairs
gpeairs approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@gpeairs gpeairs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gpeairs gpeairs merged commit b98f9d7 into main May 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeairs gpeairs gpeairs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simlapointe @gpeairs