increasing default handler timeout for cfn test (#554)

* increasing default handler timeout for cfn test
#486
* clarifying cfn test --enforce-timeout in README

Co-authored-by: Kevin DeJong <kddejong@amazon.com>

Author: PatMyron

README.md

@@ -52,10 +52,10 @@ To run the contract tests for a resource type, use the `test` command.
 
 ```bash
 cfn test
-cfn test -- -k contract_delete_update #to run a single test
-cfn test -- --tb=long #exhaustive, informative traceback formatting
-cfn test --enforce-timeout 60 #set the RL handler timeout to 60 seconds and CUD handler timeout to 120 seconds.
-cfn test --enforce-timeout 60 -- -k contract_delete_update # combine args
+cfn test -- -k contract_delete_update # to run a single test
+cfn test -- --tb=long # exhaustive, informative traceback formatting
+cfn test --enforce-timeout 60  # Read/List handler timeout (Create/Update/Delete handler timeout is twice the Read/List handler timeout)
+cfn test --enforce-timeout 60 -- -k contract_delete_update # combine arguments
 cfn test --log-group-name cw_log_group --log-role-arn log_delivery_role_arn # Handler logs generated by contract tests will be delivered to the specified cw_log_group using the credentials from log_delivery_role_arn
 ```
 

src/rpdk/core/test.py

@@ -33,7 +33,7 @@
 DEFAULT_ENDPOINT = "http://127.0.0.1:3001"
 DEFAULT_FUNCTION = "TypeFunction"
 DEFAULT_REGION = "us-east-1"
-DEFAULT_TIMEOUT = "30"
+DEFAULT_TIMEOUT = "240"
 INPUTS = "inputs"
 
 RESOURCE_OVERRIDES_VALIDATOR = Draft6Validator(

tests/test_test.py

@@ -139,8 +139,8 @@ def create_invalid_input_file(base):
 @pytest.mark.parametrize(
     "args_in,pytest_args,plugin_args",
     [
-        ([], [], [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "30"]),
-        (["--endpoint", "foo"], [], [DEFAULT_FUNCTION, "foo", DEFAULT_REGION, "30"]),
+        ([], [], [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "240"]),
+        (["--endpoint", "foo"], [], [DEFAULT_FUNCTION, "foo", DEFAULT_REGION, "240"]),
         (
             ["--function-name", "bar", "--enforce-timeout", "60"],
             [],
@@ -149,12 +149,12 @@ def create_invalid_input_file(base):
         (
             ["--", "-k", "create"],
             ["-k", "create"],
-            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "30"],
+            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "240"],
         ),
         (
             ["--region", "us-west-2", "--", "--collect-only"],
             ["--collect-only"],
-            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, "us-west-2", "30"],
+            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, "us-west-2", "240"],
         ),
     ],
 )
@@ -220,8 +220,8 @@ def test_test_command_happy_path_resource(
 @pytest.mark.parametrize(
     "args_in,pytest_args,plugin_args",
     [
-        ([], [], [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "30"]),
-        (["--endpoint", "foo"], [], [DEFAULT_FUNCTION, "foo", DEFAULT_REGION, "30"]),
+        ([], [], [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "240"]),
+        (["--endpoint", "foo"], [], [DEFAULT_FUNCTION, "foo", DEFAULT_REGION, "240"]),
         (
             ["--function-name", "bar", "--enforce-timeout", "60"],
             [],
@@ -230,12 +230,12 @@ def test_test_command_happy_path_resource(
         (
             ["--", "-k", "create"],
             ["-k", "create"],
-            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "30"],
+            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, DEFAULT_REGION, "240"],
         ),
         (
             ["--region", "us-west-2", "--", "--collect-only"],
             ["--collect-only"],
-            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, "us-west-2", "30"],
+            [DEFAULT_FUNCTION, DEFAULT_ENDPOINT, "us-west-2", "240"],
         ),
     ],
 )