fix: resolve strict concurrency errors (#3731)

* chore: add @mainactor attribuete to DeviceInfo

* chore: add @mainactor attribuete to DeviceInfo

* chore: update swift tool to 5.9

* chore: temporarily enable experimentation flags

* chore: update minimum xcode version

* fix(logging): fix Swift 6 compiler error (#3691)

* resolve build errors with xcode 15.0.1

* fix build error

* fix incorrect storage user agent string

* refactor cloudwatch logging stream name formatter

* revert experimental settings

* fix swift lint warning

* resolve review comments

* fix formatting issues

* resolve review comments

Author: phantumcode

Amplify/Core/Support/DeviceInfo.swift

@@ -28,6 +28,7 @@ import AppKit
 /// ```
 ///
 /// - Tag: DeviceInfo
+@MainActor
 public struct DeviceInfo {
 
     private init() {}

Amplify/DevMenu/Data/DeviceInfoHelper.swift

@@ -10,6 +10,7 @@ import Foundation
 import UIKit
 
 /// Helper class to fetch information for Device Information Screen
+@MainActor
 struct DeviceInfoHelper {
 
     static func getDeviceInformation() -> [DeviceInfoItem] {

Amplify/DevMenu/Data/IssueInfo.swift

@@ -9,6 +9,7 @@
 import Foundation
 
 /// Struct consisting of information required to report an issue
+@MainActor
 struct IssueInfo {
 
     private var includeEnvironmentInfo: Bool

Amplify/DevMenu/Data/IssueInfoHelper.swift

@@ -9,6 +9,7 @@
 import Foundation
 
 /// Helper class to generate markdown text for issue reporting
+@MainActor
 struct IssueInfoHelper {
 
     private static let issueDescTitle = "Issue Description"

Amplify/DevMenu/Trigger/LongPressGestureRecognizer.swift

@@ -47,13 +47,5 @@ class LongPressGestureRecognizer: NSObject, TriggerRecognizer, UIGestureRecogniz
         uiWindow?.addGestureRecognizer(recognizer)
         recognizer.delegate = self
     }
-
-    deinit {
-        if let window = uiWindow {
-            window.removeGestureRecognizer(recognizer)
-        }
-        uiWindow = nil
-        triggerDelegate = nil
-    }
 }
 #endif

Amplify/DevMenu/View/IssueReporter.swift

@@ -95,36 +95,42 @@ struct IssueReporter: View {
 
     /// Open Amplify iOS issue logging screen on Github
     private func reportToGithub() {
-        let issueDescriptionMarkdown =
-            IssueInfoHelper.generateMarkdownForIssue(
-                issue: IssueInfo(issueDescription: issueDescription,
-                         includeEnvInfo: includeEnvInfo,
-                         includeDeviceInfo: includeDeviceInfo))
-
-        let urlString = amplifyIosNewIssueUrl + issueDescriptionMarkdown
-        guard let url = urlString.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) else {
-            showAlertIfInvalidURL = true
-            return
-        }
-        guard let urlToOpen = URL(string: url) else {
-            showAlertIfInvalidURL = true
-            return
+        Task {
+            let issue = await IssueInfo(issueDescription: issueDescription,
+                                        includeEnvInfo: includeEnvInfo,
+                                        includeDeviceInfo: includeDeviceInfo)
+            let issueDescriptionMarkdown =
+                await IssueInfoHelper.generateMarkdownForIssue(
+                    issue: issue)
+
+            let urlString = amplifyIosNewIssueUrl + issueDescriptionMarkdown
+            guard let url = urlString.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed) else {
+                showAlertIfInvalidURL = true
+                return
+            }
+            guard let urlToOpen = URL(string: url) else {
+                showAlertIfInvalidURL = true
+                return
+            }
+
+            await UIApplication.shared.open(urlToOpen)
         }
 
-        UIApplication.shared.open(urlToOpen)
     }
 
     /// Copy issue as a markdown string to clipboard
     private func copyToClipboard() {
-        let issue = IssueInfo(issueDescription: issueDescription,
-                              includeEnvInfo: includeEnvInfo,
-                              includeDeviceInfo: includeDeviceInfo)
-        let value = IssueInfoHelper.generateMarkdownForIssue(issue: issue)
-#if os(iOS)
-        UIPasteboard.general.string = value
-#elseif canImport(AppKit)
-        NSPasteboard.general.setString(value, forType: .string)
-#endif
+        Task {
+            let issue = await IssueInfo(issueDescription: issueDescription,
+                                  includeEnvInfo: includeEnvInfo,
+                                  includeDeviceInfo: includeDeviceInfo)
+            let value = await IssueInfoHelper.generateMarkdownForIssue(issue: issue)
+            #if os(iOS)
+            UIPasteboard.general.string = value
+            #elseif canImport(AppKit)
+            NSPasteboard.general.setString(value, forType: .string)
+            #endif
+        }
     }
 }
 
@@ -166,6 +172,7 @@ final class MultilineTextField: UIViewRepresentable {
         return view
     }
 
+    @MainActor
     @objc func dismissKeyboard() {
         UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder),
                                         to: nil, from: nil, for: nil)

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/ASF/ASFDeviceInfo.swift

@@ -8,6 +8,7 @@
 import Foundation
 import Amplify
 
+@MainActor
 struct ASFDeviceInfo: ASFDeviceBehavior {
 
     let id: String

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/ASF/AdvancedSecurityBehavior.swift

@@ -15,7 +15,7 @@ protocol AdvancedSecurityBehavior {
                          configuration: UserPoolConfigurationData) throws -> String
 }
 
-protocol ASFDeviceBehavior {
+protocol ASFDeviceBehavior: Sendable {
 
     var id: String { get }
 

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/ASF/CognitoUserPoolASF+KeyChain.swift

@@ -32,8 +32,8 @@ extension CognitoUserPoolASF {
     static func encodedContext(username: String,
                                asfDeviceId: String,
                                asfClient: AdvancedSecurityBehavior,
-                               userPoolConfiguration: UserPoolConfigurationData) -> String? {
-        let deviceInfo: ASFDeviceBehavior = ASFDeviceInfo(id: asfDeviceId)
+                               userPoolConfiguration: UserPoolConfigurationData) async -> String? {
+        let deviceInfo: ASFDeviceBehavior = await ASFDeviceInfo(id: asfDeviceId)
         let appInfo: ASFAppInfoBehavior = ASFAppInfo()
 
         do {

AmplifyPlugins/Auth/Sources/AWSCognitoAuthPlugin/Actions/RefreshAuthorizationSession/UserPool/RefreshUserPoolTokens.swift

@@ -41,7 +41,7 @@ struct RefreshUserPoolTokens: Action {
                 for: existingSignedIndata.username,
                 credentialStoreClient: authEnv.credentialsClient)
 
-            let input = InitiateAuthInput.refreshAuthInput(
+            let input = await InitiateAuthInput.refreshAuthInput(
                 username: existingSignedIndata.username,
                 refreshToken: existingTokens.refreshToken,
                 clientMetadata: [:],