Skip to content

Commit f4e8707

Browse files
authored
chore(storage): update generated s3 types (#14361)
2 parents 893d9cf + f3e9be3 commit f4e8707

File tree

9 files changed

+3510
-925
lines changed

9 files changed

+3510
-925
lines changed

packages/storage/__tests__/providers/s3/utils/client/S3/cases/copyObject.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const copyObjectHappyCase: ApiFunctionalTestCase<typeof copyObject> = [
2222
Key: 'key',
2323
CacheControl: 'cacheControl',
2424
ContentType: 'contentType',
25-
ACL: 'acl',
25+
ACL: 'public-read',
2626
CopySourceIfMatch: 'eTag',
2727
CopySourceIfUnmodifiedSince: new Date(0),
2828
},
@@ -35,7 +35,7 @@ const copyObjectHappyCase: ApiFunctionalTestCase<typeof copyObject> = [
3535
'x-amz-copy-source': 'sourceBucket/sourceKey',
3636
'cache-control': 'cacheControl',
3737
'content-type': 'contentType',
38-
'x-amz-acl': 'acl',
38+
'x-amz-acl': 'public-read',
3939
'x-amz-copy-source-if-match': 'eTag',
4040
'x-amz-copy-source-if-unmodified-since': 'Thu, 01 Jan 1970 00:00:00 GMT',
4141
}),

packages/storage/__tests__/providers/s3/utils/client/S3/cases/listObjectsV2.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,21 @@ const listObjectsV2HappyCaseTruncated: ApiFunctionalTestCase<
2222
Bucket: 'bucket',
2323
ContinuationToken: 'ContinuationToken',
2424
Delimiter: 'Delimiter',
25-
EncodingType: 'EncodingType',
25+
EncodingType: 'url',
2626
ExpectedBucketOwner: 'ExpectedBucketOwner',
2727
FetchOwner: false,
2828
MaxKeys: 0,
2929
Prefix: 'Prefix',
30-
RequestPayer: 'RequestPayer',
30+
RequestPayer: 'requester',
3131
StartAfter: 'StartAfter',
3232
},
3333
expect.objectContaining({
3434
url: expect.objectContaining({
35-
href: 'https://bucket.s3.us-east-1.amazonaws.com/?list-type=2&continuation-token=ContinuationToken&delimiter=Delimiter&encoding-type=EncodingType&fetch-owner=false&max-keys=0&prefix=Prefix&start-after=StartAfter',
35+
href: 'https://bucket.s3.us-east-1.amazonaws.com/?list-type=2&continuation-token=ContinuationToken&delimiter=Delimiter&encoding-type=url&fetch-owner=false&max-keys=0&prefix=Prefix&start-after=StartAfter',
3636
}),
3737
method: 'GET',
3838
headers: expect.objectContaining({
39-
'x-amz-request-payer': 'RequestPayer',
39+
'x-amz-request-payer': 'requester',
4040
'x-amz-expected-bucket-owner': 'ExpectedBucketOwner',
4141
}),
4242
}),
@@ -51,7 +51,7 @@ const listObjectsV2HappyCaseTruncated: ApiFunctionalTestCase<
5151
<StartAfter>ExampleGuide.pdf</StartAfter>
5252
<MaxKeys>1000</MaxKeys>
5353
<IsTruncated>true</IsTruncated>
54-
<EncodingType>string</EncodingType>
54+
<EncodingType>url</EncodingType>
5555
<ContinuationToken>1ueGcxLPRx1Tr/XYExHnhbYLgveDs2J/wm36Hy4vbOwM=</ContinuationToken>
5656
<NextContinuationToken>Next1ueGcxLPRx1Tr/XYExHnhbYLgveDs2J/wm36Hy4vbOwM=</NextContinuationToken>
5757
<Contents>
@@ -112,7 +112,7 @@ const listObjectsV2HappyCaseTruncated: ApiFunctionalTestCase<
112112
],
113113
ContinuationToken: '1ueGcxLPRx1Tr/XYExHnhbYLgveDs2J/wm36Hy4vbOwM=',
114114
Delimiter: 'string',
115-
EncodingType: 'string',
115+
EncodingType: 'url',
116116
IsTruncated: true,
117117
KeyCount: 4,
118118
MaxKeys: 1000,

packages/storage/__tests__/providers/s3/utils/client/S3/cases/putObject.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const putObjectRequest = {
1414
Bucket: 'bucket',
1515
Key: 'key',
1616
Body: 'body',
17-
ACL: 'public-read',
17+
ACL: 'public-read' as const,
1818
CacheControl: 'CacheControl',
1919
ContentDisposition: 'ContentDisposition',
2020
ContentEncoding: 'ContentEncoding',

packages/storage/src/providers/s3/apis/internal/list.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ export const list = async (
8686
ContinuationToken: options?.listAll ? undefined : options?.nextToken,
8787
Delimiter: getDelimiter(options),
8888
ExpectedBucketOwner: options?.expectedBucketOwner,
89-
EncodingType: 'url',
89+
EncodingType: 'url' as const,
9090
};
9191
logger.debug(`listing items from "${listParams.Prefix}"`);
9292

packages/storage/src/providers/s3/utils/client/s3data/deleteObject.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,12 @@ import {
2323
validateS3RequiredParameter,
2424
} from '../utils';
2525
import { validateObjectUrl } from '../../validateObjectUrl';
26+
import { deserializeStringTag } from '../utils/deserializeHelpers';
2627

2728
import type {
2829
DeleteObjectCommandInput,
2930
DeleteObjectCommandOutput,
31+
RequestPayer,
3032
} from './types';
3133
import { defaultConfig, parseXmlError } from './base';
3234

@@ -73,7 +75,10 @@ const deleteObjectDeserializer = async (
7375
const content = map(response.headers, {
7476
DeleteMarker: ['x-amz-delete-marker', deserializeBoolean],
7577
VersionId: 'x-amz-version-id',
76-
RequestCharged: 'x-amz-request-charged',
78+
RequestCharged: [
79+
'x-amz-request-charged',
80+
deserializeStringTag<RequestPayer>,
81+
],
7782
});
7883

7984
return {

packages/storage/src/providers/s3/utils/client/s3data/listObjectsV2.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,13 @@ import {
2525
s3TransferHandler,
2626
} from '../utils';
2727
import { IntegrityError } from '../../../../../errors/IntegrityError';
28+
import { deserializeStringTag } from '../utils/deserializeHelpers';
2829

2930
import type {
31+
ChecksumAlgorithm,
3032
ListObjectsV2CommandInput,
3133
ListObjectsV2CommandOutput,
34+
StorageClass,
3235
} from './types';
3336
import { defaultConfig, parseXmlError } from './base';
3437

@@ -83,7 +86,7 @@ const listObjectsV2Deserializer = async (
8386
],
8487
ContinuationToken: 'ContinuationToken',
8588
Delimiter: 'Delimiter',
86-
EncodingType: 'EncodingType',
89+
EncodingType: ['EncodingType', deserializeStringTag<'url'>],
8790
IsTruncated: ['IsTruncated', deserializeBoolean],
8891
KeyCount: ['KeyCount', deserializeNumber],
8992
MaxKeys: ['MaxKeys', deserializeNumber],
@@ -124,12 +127,12 @@ const deserializeObject = (output: any) =>
124127
value => emptyArrayGuard(value, deserializeChecksumAlgorithmList),
125128
],
126129
Size: ['Size', deserializeNumber],
127-
StorageClass: 'StorageClass',
130+
StorageClass: ['StorageClass', deserializeStringTag<StorageClass>],
128131
Owner: ['Owner', deserializeOwner],
129132
});
130133

131134
const deserializeChecksumAlgorithmList = (output: any[]) =>
132-
output.map(entry => String(entry));
135+
output.map(deserializeStringTag<ChecksumAlgorithm>);
133136

134137
const deserializeOwner = (output: any) =>
135138
map(output, { DisplayName: 'DisplayName', ID: 'ID' });

0 commit comments

Comments
 (0)