chore(): Migrate to js_interop (#6162)

Author: tyllark

actions/lib/src/node/actions/exec.dart

@@ -3,8 +3,6 @@
 
 import 'dart:convert';
 import 'dart:js_interop';
-//ignore: deprecated_member_use
-import 'dart:js_util';
 
 @JS()
 external Exec get exec;
@@ -46,9 +44,14 @@ extension type Exec._(JSObject it) {
       ignoreReturnCode: !failOnNonZeroExit,
     );
     try {
-      final exitCode = await promiseToFuture<int>(
-        _exec(commandLine, args.map((arg) => arg.toJS).toList().toJS, options),
-      );
+      final jsExitCode =
+          await _exec(
+            commandLine,
+            args.map((arg) => arg.toJS).toList().toJS,
+            options,
+          ).toDart;
+          
+      final exitCode = (jsExitCode as JSNumber).toDartInt;
       return ExecResult(
         exitCode: exitCode,
         stdout: stdout.toString(),

actions/lib/src/node/actions/http_request.dart

@@ -3,6 +3,8 @@
 
 import 'dart:js_interop';
 
+import 'package:web/web.dart';
+
 @JS()
 extension type HttpClient._(JSObject it) {
   external HttpClient([
@@ -18,7 +20,11 @@ extension type HttpClient._(JSObject it) {
     String requestUrl, {
     Map<String, String> headers = const {},
   }) async {
-    final jsHeaders = headers.jsify() as JSObject;
+    final jsHeaders = Headers();
+      for(final entry in headers.entries) {
+        jsHeaders.append(entry.key, entry.value);
+      }
+
     final response = await _getJson(requestUrl, jsHeaders).toDart;
     final result = response as TypedResponse<JSObject>;
     if (result.statusCode != 200) {

actions/pubspec.yaml

@@ -18,6 +18,7 @@ dependencies:
   source_maps: ^0.10.12
   stack_trace: ^1.10.0
   stream_transform: ^2.1.0
+  web: ^1.1.1
 
 dev_dependencies:
   amplify_lints: ^3.0.0

packages/amplify_core/lib/src/platform/platform.dart

@@ -3,4 +3,4 @@
 
 export 'platform_stub.dart'
     if (dart.library.io) 'platform_io.dart'
-    if (dart.library.html) 'platform_html.dart';
+    if (dart.library.js_interop) 'platform_html.dart';

packages/amplify_core/lib/src/platform/platform_html.dart

@@ -1,8 +1,7 @@
 // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-//ignore: deprecated_member_use
-import 'dart:html';
+import 'package:web/web.dart';
 
 final RegExp _edgeRegex = RegExp(r'Edg/[\d\.]+');
 final RegExp _operaRegex = RegExp(r'OPR/[\d\.]+');

packages/amplify_core/pubspec.yaml

@@ -21,6 +21,7 @@ dependencies:
   retry: ^3.1.0
   stack_trace: ^1.10.0
   uuid: ">=3.0.6 <5.0.0"
+  web: ^1.1.1
 
 dev_dependencies:
   amplify_lints: ">=3.1.2 <3.2.0"

packages/analytics/amplify_analytics_pinpoint/lib/src/device_context_info_provider/device_info_provider/device_info_provider.dart

@@ -2,5 +2,5 @@
 // SPDX-License-Identifier: Apache-2.0
 
 export 'device_info_provider_stub.dart'
-    if (dart.library.html) 'device_info_provider_html.dart'
+    if (dart.library.js_interop) 'device_info_provider_html.dart'
     if (dart.library.io) 'device_info_provider_io.dart';

packages/analytics/amplify_analytics_pinpoint/lib/src/flutter_path_provider/flutter_path_provider.dart

@@ -2,5 +2,5 @@
 // SPDX-License-Identifier: Apache-2.0
 
 export 'flutter_path_provider_stub.dart'
-    if (dart.library.html) 'flutter_path_provider_html.dart'
+    if (dart.library.js_interop) 'flutter_path_provider_html.dart'
     if (dart.library.io) 'flutter_path_provider_io.dart';

packages/analytics/amplify_analytics_pinpoint_dart/lib/src/impl/analytics_client/event_client/queued_item_store/dart_queued_item_store.dart

@@ -2,5 +2,5 @@
 // SPDX-License-Identifier: Apache-2.0
 
 export 'dart_queued_item_store.stub.dart'
-    if (dart.library.html) 'dart_queued_item_store.web.dart'
+    if (dart.library.js_interop) 'dart_queued_item_store.web.dart'
     if (dart.library.io) 'dart_queued_item_store.vm.dart';

packages/analytics/amplify_analytics_pinpoint_dart/lib/src/impl/analytics_client/event_client/queued_item_store/index_db/indexed_db_adapter.dart

@@ -2,14 +2,15 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import 'dart:async';
-//ignore: deprecated_member_use
-import 'dart:js_util';
+import 'dart:js_interop';
+import 'dart:js_interop_unsafe';
 
 import 'package:amplify_analytics_pinpoint_dart/src/impl/analytics_client/event_client/queued_item_store/queued_item_store.dart';
 import 'package:amplify_core/amplify_core.dart';
 // ignore: implementation_imports
 import 'package:aws_common/src/js/indexed_db.dart';
 import 'package:collection/collection.dart';
+import 'package:web/web.dart';
 
 // TODO(kylechen): Consider merging/refactoring with existing 'amplify_secure_storage_web - _IndexedDBStorage' class
 /// {@template amplify_analytics_pinpoint_dart.indexed_db_adapter}
@@ -39,36 +40,43 @@ class IndexedDbAdapter implements QueuedItemStore {
     if (db == null) {
       throw const InvalidStateException('IndexedDB is not available');
     }
+    void onUpgradeNeeded(IDBVersionChangeEvent event) {
+      final database = event.target?.getProperty<IDBDatabase>('result'.toJS);
+      final objectStoreNames = database?.objectStoreNames;
+      if (!(objectStoreNames?.contains(storeName) ?? false)) {
+        database?.createObjectStore(
+          storeName,
+          IDBObjectStoreParameters(keyPath: 'id'.toJS, autoIncrement: true),
+        );
+      }
+    }
+
     final openRequest = db.open(databaseName, 1)
-      ..onupgradeneeded = (event) {
-        final database = event.target.result;
-        final objectStoreNames = database.objectStoreNames;
-        if (!objectStoreNames.contains(storeName)) {
-          database.createObjectStore(
-            storeName,
-            keyPath: 'id',
-            autoIncrement: true,
-          );
-        }
-      };
-    _database = await openRequest.future;
+      ..onupgradeneeded = onUpgradeNeeded.toJS;
+
+    final result = await openRequest.future;
+    if (result.isA<IDBDatabase>()) {
+      result as IDBDatabase;
+      _database = result;
+    } else {
+      throw const InvalidStateException('IDBOpenDBRequest failed');
+    }
   }
 
   /// Returns a new [IDBObjectStore] instance after waiting for initialization
   /// to complete.
   IDBObjectStore _getObjectStore() {
-    final transaction = _database.transaction(
-      storeName,
-      mode: IDBTransactionMode.readwrite,
-    );
+    final transaction = _database.transaction(storeName.toJS, 'readwrite');
     final store = transaction.objectStore(storeName);
     return store;
   }
 
   @override
   Future<void> addItem(String string) async {
     await _databaseOpenEvent;
-    await _getObjectStore().push({'value': string}).future;
+    final item = JSObject()..setProperty('value'.toJS, string.toJS);
+
+    await _getObjectStore().add(item).future;
   }
 
   @override
@@ -77,14 +85,26 @@ class IndexedDbAdapter implements QueuedItemStore {
 
     await _databaseOpenEvent;
     final store = _getObjectStore();
-    final request = store.getAll(null, count);
+
+    late IDBRequest request;
+    if (count == null) {
+      request = store.getAll();
+    } else {
+      request = store.getAll(null, count);
+    }
 
     await request.future;
+    final jsResult = request.result;
+    var result = <JSObject>[];
+    if (jsResult.isA<JSArray<JSObject>>()) {
+      jsResult as JSArray<JSObject>;
+      result = jsResult.toDart;
+    }
+
+    for (final elem in result) {
+      final id = elem.getProperty<JSNumber>('id'.toJS).toDartInt;
+      final string = elem.getProperty<JSString>('value'.toJS).toDart;
 
-    for (final elem in request.result) {
-      final value = elem as Object;
-      final id = getProperty<int>(value, 'id');
-      final string = getProperty<String>(value, 'value');
       readValues.add(QueuedItem(id: id, value: string));
     }
     return readValues;
@@ -101,10 +121,8 @@ class IndexedDbAdapter implements QueuedItemStore {
 
     final ranges = idsToDelete
         .splitBetween((a, b) => b != a + 1)
-        .map((range) => IDBKeyRange.bound(range.first, range.last));
-    await Future.wait<void>(
-      ranges.map((range) => store.deleteByKeyRange(range).future),
-    );
+        .map((range) => IDBKeyRange.bound(range.first.toJS, range.last.toJS));
+    await Future.wait<void>(ranges.map((range) => store.delete(range).future));
   }
 
   /// Clear the database.