chore(common): Windows CMake file collision

Author: Equartey

packages/common/amplify_db_common/windows/CMakeLists.txt

@@ -21,7 +21,7 @@ add_library(${PLUGIN_NAME} SHARED
 ###
 
 # Essentially, the idea of this build script is to compile a sqlite3.dll
-# and make Fluter bundle that with the final app.
+# and make Flutter bundle that with the final app.
 # It looks like we can't avoid building a sqlite3_flutter_libs.dll too,
 # but that's not on me.
 
@@ -34,57 +34,62 @@ target_include_directories(${PLUGIN_NAME} INTERFACE
 target_link_libraries(${PLUGIN_NAME} PRIVATE flutter flutter_wrapper_plugin)
 
 include(FetchContent)
+
 if (CMAKE_VERSION VERSION_GREATER_EQUAL "3.24.0")
   # cmake 3.24.0 added the `DOWNLOAD_EXTRACT_TIMESTAMP` and prints an ugly warning when
   # the default is used, so override it to the recommended behavior.
   # We can't really ask users to use a cmake that recent, so there's this if here.
   FetchContent_Declare(
     sqlite3
-    URL https://sqlite.org/2023/sqlite-autoconf-3430000.tar.gz
+    URL https://sqlite.org/2024/sqlite-autoconf-3460000.tar.gz
     DOWNLOAD_EXTRACT_TIMESTAMP NEW
   )
 else()
   FetchContent_Declare(
     sqlite3
-    URL https://sqlite.org/2023/sqlite-autoconf-3430000.tar.gz
+    URL https://sqlite.org/2024/sqlite-autoconf-3460000.tar.gz
   )
 endif()
-FetchContent_MakeAvailable(sqlite3)
 
-add_library(sqlite3 SHARED "sqlite3_flutter.c")
+# Only fetch and build sqlite3 if it hasn't been added yet
+if (NOT TARGET sqlite3)
+  FetchContent_MakeAvailable(sqlite3)
 
-target_include_directories(sqlite3 PRIVATE "${sqlite3_SOURCE_DIR}")
-target_compile_options(sqlite3 PRIVATE "$<$<NOT:$<CONFIG:Debug>>:-O2>" "/w")
+  add_library(sqlite3 SHARED "sqlite3_flutter.c")
 
-# Note: Keep in sync with https://github.com/simolus3/sqlite-native-libraries/blob/master/sqlite3-native-library/cpp/CMakeLists.txt
-target_compile_definitions(sqlite3 PRIVATE
-  SQLITE_ENABLE_FTS5
-  SQLITE_ENABLE_RTREE
-  SQLITE_DQS=0
-  SQLITE_DEFAULT_MEMSTATUS=0
-  SQLITE_TEMP_STORE=2
-  SQLITE_MAX_EXPR_DEPTH=0
-  SQLITE_OMIT_AUTHORIZATION
-  SQLITE_OMIT_DECLTYPE
-  SQLITE_OMIT_DEPRECATED
-  SQLITE_OMIT_GET_TABLE
-  SQLITE_OMIT_LOAD_EXTENSION
-  SQLITE_OMIT_PROGRESS_CALLBACK
-  SQLITE_OMIT_SHARED_CACHE
-  SQLITE_OMIT_TCL_VARIABLE
-  SQLITE_OMIT_TRACE
-  SQLITE_USE_ALLOCA
-  SQLITE_UNTESTABLE
-  SQLITE_HAVE_ISNAN
-  SQLITE_HAVE_LOCALTIME_R
-  SQLITE_HAVE_LOCALTIME_S
-)
+  target_include_directories(sqlite3 PRIVATE "${sqlite3_SOURCE_DIR}")
+  target_compile_options(sqlite3 PRIVATE "$<$<NOT:$<CONFIG:Debug>>:-O2>" "/w")
 
-# Ensure sqlite3 actually gets build
-add_dependencies(${PLUGIN_NAME} sqlite3)
+  # Note: Keep in sync with https://github.com/simolus3/sqlite-native-libraries/blob/master/sqlite3-native-library/cpp/CMakeLists.txt
+  target_compile_definitions(sqlite3 PRIVATE
+    SQLITE_ENABLE_DBSTAT_VTAB
+    SQLITE_ENABLE_FTS5
+    SQLITE_ENABLE_RTREE
+    SQLITE_DQS=0
+    SQLITE_DEFAULT_MEMSTATUS=0
+    SQLITE_TEMP_STORE=2
+    SQLITE_MAX_EXPR_DEPTH=0
+    SQLITE_STRICT_SUBTYPE=1
+    SQLITE_OMIT_AUTHORIZATION
+    SQLITE_OMIT_DECLTYPE
+    SQLITE_OMIT_DEPRECATED
+    SQLITE_OMIT_PROGRESS_CALLBACK
+    SQLITE_OMIT_SHARED_CACHE
+    SQLITE_OMIT_TCL_VARIABLE
+    SQLITE_OMIT_TRACE
+    SQLITE_USE_ALLOCA
+    SQLITE_UNTESTABLE
+    SQLITE_HAVE_ISNAN
+    SQLITE_HAVE_LOCALTIME_R
+    SQLITE_HAVE_LOCALTIME_S
+  )
 
-# List of absolute paths to libraries that should be bundled with the plugin
-set(amplify_db_common_bundled_libraries
-  "$<TARGET_FILE:sqlite3>"
-  PARENT_SCOPE
-)
+  # Ensure sqlite3 actually gets built
+  add_dependencies(${PLUGIN_NAME} sqlite3)
+
+  # List of absolute paths to libraries that should be bundled with the plugin
+  set(amplify_db_common_bundled_libraries
+    "$<TARGET_FILE:sqlite3>"
+    PARENT_SCOPE
+  )
+endif()