fix: restructured tests for readability

Author: hahnandrew

packages/auth/amplify_auth_cognito_test/test/plugin/fetch_current_device.dart

@@ -31,92 +31,86 @@ void main() {
     return secrets?.deviceKey;
   }
 
-  group(
-      'fetchCurrentDevice expected return value and DeviceNotTrackedException',
-      () {
-    setUp(() async {
-      secureStorage = MockSecureStorage();
-      seedStorage(
-        secureStorage,
-        userPoolKeys: userPoolKeys,
-        identityPoolKeys: identityPoolKeys,
-        deviceKeys: CognitoDeviceKeys(userPoolConfig, username),
-      );
-      plugin = AmplifyAuthCognitoDart(
-        secureStorageFactory: (_) => secureStorage,
-      );
-      stateMachine = plugin.stateMachine;
-      await plugin.configure(
-        config: mockConfig,
-        authProviderRepo: testAuthRepo,
-      );
-      final mockIdp = MockCognitoIdentityProviderClient(
-        getDevice: () async => mockDeviceResponse,
-        forgetDevice: () async {},
-      );
-      stateMachine.addInstance<CognitoIdentityProviderClient>(mockIdp);
-      repo = stateMachine.getOrCreate<DeviceMetadataRepository>();
-    });
+  setUp(() async {
+    secureStorage = MockSecureStorage();
+    seedStorage(
+      secureStorage,
+      userPoolKeys: userPoolKeys,
+      identityPoolKeys: identityPoolKeys,
+      deviceKeys: CognitoDeviceKeys(userPoolConfig, username),
+    );
+    plugin = AmplifyAuthCognitoDart(
+      secureStorageFactory: (_) => secureStorage,
+    );
+    stateMachine = plugin.stateMachine;
+    await plugin.configure(
+      config: mockConfig,
+      authProviderRepo: testAuthRepo,
+    );
+    repo = stateMachine.getOrCreate<DeviceMetadataRepository>();
+  });
 
-    test(
-        'should get the current device. current device id should be equal to the local device id',
-        () async {
-      final currentDeviceKey = await getDeviceKey();
-      expect(currentDeviceKey, isNotNull);
-      final currentDevice = await plugin.fetchCurrentDevice();
-      expect(currentDeviceKey, currentDevice.id);
-    });
+  tearDown(() async {
+    await plugin.close();
+  });
 
-    test(
-        'should should throw a DeviceNotTrackedException when current device key is null',
-        () async {
-      await plugin.forgetDevice();
-      await expectLater(
-        plugin.fetchCurrentDevice,
-        throwsA(isA<DeviceNotTrackedException>()),
-      );
-    });
+  group('fetchCurrentDevice', () {
+    group('expected return value and DeviceNotTrackedException', () {
+      setUp(() async {
+        final mockIdp = MockCognitoIdentityProviderClient(
+          getDevice: () async => mockDeviceResponse,
+          forgetDevice: () async {},
+        );
+        stateMachine.addInstance<CognitoIdentityProviderClient>(mockIdp);
+      });
 
-    tearDown(() async {
-      await plugin.close();
+      test(
+          'should get the current device. current device id should be equal to the local device id',
+          () async {
+        final currentDeviceKey = await getDeviceKey();
+        expect(currentDeviceKey, isNotNull);
+        final currentDevice = await plugin.fetchCurrentDevice();
+        expect(currentDeviceKey, currentDevice.id);
+      });
     });
-  });
 
-  group('fetchCurrentDevice AWSHttpException', () {
-    setUp(() async {
-      secureStorage = MockSecureStorage();
-      seedStorage(
-        secureStorage,
-        userPoolKeys: userPoolKeys,
-        identityPoolKeys: identityPoolKeys,
-        deviceKeys: CognitoDeviceKeys(userPoolConfig, username),
-      );
-      plugin = AmplifyAuthCognitoDart(
-        secureStorageFactory: (_) => secureStorage,
-      );
-      stateMachine = plugin.stateMachine;
-      await plugin.configure(
-        config: mockConfig,
-        authProviderRepo: testAuthRepo,
-      );
-      final mockIdp = MockCognitoIdentityProviderClient(
-        getDevice: () async => throw AWSHttpException(
-          AWSHttpRequest.get(Uri.parse('https://www.amazon.com')),
-        ),
-      );
-      stateMachine.addInstance<CognitoIdentityProviderClient>(mockIdp);
-      repo = stateMachine.getOrCreate<DeviceMetadataRepository>();
-    });
+    group('DeviceNotTrackedException', () {
+      setUp(() async {
+        final mockIdp = MockCognitoIdentityProviderClient(
+          getDevice: () async => mockDeviceResponse,
+          forgetDevice: () async {},
+        );
+        stateMachine.addInstance<CognitoIdentityProviderClient>(mockIdp);
+      });
 
-    test('should throw a NetworkException', () async {
-      await expectLater(
-        plugin.fetchCurrentDevice,
-        throwsA(isA<NetworkException>()),
-      );
+      test(
+          'should throw a DeviceNotTrackedException when current device key is null',
+          () async {
+        await plugin.forgetDevice();
+        await expectLater(
+          plugin.fetchCurrentDevice,
+          throwsA(isA<DeviceNotTrackedException>()),
+        );
+      });
     });
 
-    tearDown(() async {
-      await plugin.close();
+    group('AWSHttpException', () {
+      setUp(() async {
+        final mockIdp = MockCognitoIdentityProviderClient(
+          getDevice: () async => throw AWSHttpException(
+            AWSHttpRequest.get(Uri.parse('https://aws.amazon.com/cognito/')),
+          ),
+        );
+        stateMachine.addInstance<CognitoIdentityProviderClient>(mockIdp);
+      });
+
+      test('should convert AWSHttpException to and throw a NetworkException',
+          () async {
+        await expectLater(
+          plugin.fetchCurrentDevice,
+          throwsA(isA<NetworkException>()),
+        );
+      });
     });
   });
 }