chore!: rename StorageNotFoundException (#4770)

* chore!: rename `StorageNotFoundException`

* chore: remove skip test for web

Author: Jordan-Nelson

packages/amplify_core/lib/src/types/exception/amplify_exception.dart

@@ -21,8 +21,8 @@ part 'network_exception.dart';
 part 'push/push_notification_exception.dart';
 part 'storage/access_denied_exception.dart';
 part 'storage/http_status_exception.dart';
-part 'storage/key_not_found_exception.dart';
 part 'storage/local_file_not_found_exception.dart';
+part 'storage/not_found_exception.dart';
 part 'storage/operation_canceled_exception.dart';
 part 'storage/path_validation_exception.dart';
 part 'storage/storage_exception.dart';

packages/amplify_core/lib/src/types/exception/storage/key_not_found_exception.dart

@@ -0,0 +1,19 @@
+// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+// SPDX-License-Identifier: Apache-2.0
+
+part of '../amplify_exception.dart';
+
+/// {@template amplify_core.storage.not_found_exception}
+/// Exception thrown when the item is not found in the storage service.
+/// {@endtemplate}
+class StorageNotFoundException extends StorageException {
+  /// {@macro amplify_core.storage.not_found_exception}
+  const StorageNotFoundException(
+    super.message, {
+    super.recoverySuggestion,
+    super.underlyingException,
+  });
+
+  @override
+  String get runtimeTypeName => 'StorageNotFoundException';
+}

packages/amplify_core/lib/src/types/exception/storage/not_found_exception.dart

@@ -6,7 +6,7 @@ export '../exception/amplify_exception.dart'
         StorageException,
         StorageAccessDeniedException,
         StorageHttpStatusException,
-        StorageKeyNotFoundException,
+        StorageNotFoundException,
         StorageLocalFileNotFoundException,
         StorageOperationCanceledException,
         NetworkException,

packages/amplify_core/lib/src/types/storage/storage_types.dart

@@ -114,7 +114,7 @@ void main() {
             source: const StoragePath.fromString('public/non-existent-path'),
             destination: const StoragePath.fromString('public/foo'),
           ).result,
-          throwsA(isA<StorageKeyNotFoundException>()),
+          throwsA(isA<StorageNotFoundException>()),
         );
       });
     });

packages/storage/amplify_storage_s3/example/integration_test/copy_test.dart

@@ -75,7 +75,7 @@ void main() {
           () => Amplify.Storage.getProperties(
             path: const StoragePath.fromString('public/not-existent-path'),
           ).result,
-          throwsA(isA<StorageKeyNotFoundException>()),
+          throwsA(isA<StorageNotFoundException>()),
         );
       });
     });

packages/storage/amplify_storage_s3/example/integration_test/get_properties_test.dart

@@ -140,7 +140,7 @@ void main() {
                 ),
               ),
             ).result,
-            throwsA(isA<StorageKeyNotFoundException>()),
+            throwsA(isA<StorageNotFoundException>()),
           );
         });
 

packages/storage/amplify_storage_s3/example/integration_test/get_url_test.dart

@@ -4,7 +4,6 @@
 import 'package:amplify_core/amplify_core.dart';
 import 'package:amplify_storage_s3/amplify_storage_s3.dart';
 import 'package:amplify_storage_s3_example/amplifyconfiguration.dart';
-import 'package:flutter/foundation.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:integration_test/integration_test.dart';
 
@@ -40,8 +39,6 @@ void main() {
             ).result;
             expect(downloadResult.bytes, data);
           },
-          // TODO(Jordan-Nelson): Resolve bug with `AWSFile.fromData` on web.
-          skip: kIsWeb,
         );
 
         testWidgets('from path', (_) async {

packages/storage/amplify_storage_s3/example/integration_test/upload_file_test.dart

@@ -5,7 +5,7 @@ Future<bool> objectExists(StoragePath path) async {
   try {
     await Amplify.Storage.getProperties(path: path).result;
     return true;
-  } on StorageKeyNotFoundException {
+  } on StorageNotFoundException {
     return false;
   }
 }

packages/storage/amplify_storage_s3/example/integration_test/utils/object_exists.dart

@@ -7,8 +7,7 @@ import 'package:amplify_storage_s3_dart/src/sdk/s3.dart' as s3;
 import 'package:meta/meta.dart';
 import 'package:smithy/smithy.dart' as smithy;
 
-const _keyNotFoundRecoveryMessage =
-    'Ensure that correct StoragePath is provided.';
+const _notFoundRecoveryMessage = 'Ensure that correct StoragePath is provided.';
 const _httpErrorRecoveryMessage =
     'HTTP error returned from service, review the `underlyingException` for details.';
 
@@ -29,12 +28,12 @@ final accelerateEndpointUnusable = ConfigurationError(
 
 /// Extension of [s3.NoSuchKey] to add util methods.
 extension NoSuchKeyToStorageKeyNotFoundException on s3.NoSuchKey {
-  /// Creates a [StorageKeyNotFoundException] with the [s3.NoSuchKey] as the
+  /// Creates a [StorageNotFoundException] with the [s3.NoSuchKey] as the
   /// underlying exception.
-  StorageKeyNotFoundException toStorageKeyNotFoundException() {
-    return StorageKeyNotFoundException(
+  StorageNotFoundException toStorageNotFoundException() {
+    return StorageNotFoundException(
       'Cannot find the item specified by the provided path.',
-      recoverySuggestion: _keyNotFoundRecoveryMessage,
+      recoverySuggestion: _notFoundRecoveryMessage,
       underlyingException: this,
     );
   }
@@ -64,9 +63,9 @@ extension UnknownSmithyHttpExceptionToStorageException
           underlyingException: this,
         );
       } else if (statusCode == 404) {
-        return StorageKeyNotFoundException(
+        return StorageNotFoundException(
           'Cannot find the item specified by the provided path.',
-          recoverySuggestion: _keyNotFoundRecoveryMessage,
+          recoverySuggestion: _notFoundRecoveryMessage,
           underlyingException: this,
         );
       } else {

packages/storage/amplify_storage_s3_dart/lib/src/exception/s3_storage_exception.dart

@@ -355,7 +355,7 @@ class S3DownloadTask {
       throw error.toStorageException();
     } on s3.NoSuchKey catch (error) {
       // 404 error is wrapped by s3.NoSuchKey for getObject :/
-      throw error.toStorageKeyNotFoundException();
+      throw error.toStorageNotFoundException();
     } on AWSHttpException catch (error) {
       throw error.toNetworkException();
     }

packages/storage/amplify_storage_s3_dart/lib/src/storage_s3_service/service/task/s3_download_task.dart

@@ -465,7 +465,7 @@ void main() {
       });
 
       test(
-          'should throw StorageKeyNotFoundException when UnknownSmithyHttpException'
+          'should throw StorageNotFoundException when UnknownSmithyHttpException'
           ' with status code 404 returned from service', () async {
         const testOptions = StorageGetPropertiesOptions();
         const testUnknownException = UnknownSmithyHttpException(
@@ -484,7 +484,7 @@ void main() {
             path: const StoragePath.fromString('a key'),
             options: testOptions,
           ),
-          throwsA(isA<StorageKeyNotFoundException>()),
+          throwsA(isA<StorageNotFoundException>()),
         );
       });
 
@@ -668,7 +668,7 @@ void main() {
             path: testPath,
             options: testOptions,
           ),
-          throwsA(isA<StorageKeyNotFoundException>()),
+          throwsA(isA<StorageNotFoundException>()),
         );
 
         final capturedRequest = verify(
@@ -707,7 +707,7 @@ void main() {
             path: testPath,
             options: testOptions,
           ),
-          throwsA(isA<StorageKeyNotFoundException>()),
+          throwsA(isA<StorageNotFoundException>()),
         );
 
         final capturedRequest = verify(

packages/storage/amplify_storage_s3_dart/test/storage_s3_service/storage_s3_service_test.dart

@@ -430,9 +430,9 @@ void main() {
           exceptionTypeMatcher: isA<StorageHttpStatusException>(),
         ),
         DownloadTaskExceptionConversionTestItem(
-          description: 'it should complete with a StorageKeyNotFoundException',
+          description: 'it should complete with a StorageNotFoundException',
           originalException: NoSuchKey(),
-          exceptionTypeMatcher: isA<StorageKeyNotFoundException>(),
+          exceptionTypeMatcher: isA<StorageNotFoundException>(),
         ),
         DownloadTaskExceptionConversionTestItem(
           description: 'it should complete with a NetworkException',