Skip to content

Commit 0634b07

Browse files
tyllarkhahnandrew
andauthored
Chore/goldens flutter lint (#5271)
* temp: generate goldens png * test: fixing context mounted issue * chore: add todo comment about deprecated member use --------- Co-authored-by: Andrew Hahn <dev.andrewhahn@gmail.com>
1 parent d59a804 commit 0634b07

File tree

280 files changed

+3
-15
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

280 files changed

+3
-15
lines changed

packages/amplify/amplify_flutter/example/macos/Flutter/GeneratedPluginRegistrant.swift

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/analytics/amplify_analytics_pinpoint/example/macos/Flutter/GeneratedPluginRegistrant.swift

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/api/amplify_api/example/macos/Flutter/GeneratedPluginRegistrant.swift

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/auth/amplify_auth_cognito/example/macos/Flutter/GeneratedPluginRegistrant.swift

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/authenticator/amplify_authenticator/example/macos/Flutter/GeneratedPluginRegistrant.swift

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/authenticator/amplify_authenticator/lib/amplify_authenticator.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ class _AuthenticatorState extends State<Authenticator> {
554554
final resolver = widget.stringResolver.messages;
555555
_infoSub = _stateMachineBloc.infoMessages.listen((key) {
556556
final context = scaffoldMessengerKey.currentContext;
557-
if (mounted && context != null) {
557+
if (context != null && context.mounted) {
558558
final message = resolver.resolve(context, key);
559559
_logger.info(message);
560560
_showExceptionBanner(
@@ -821,6 +821,8 @@ class _AuthenticatorBody extends StatelessWidget {
821821
builder: (state, child) {
822822
if (state is AuthenticatedState) return child;
823823
return Navigator(
824+
// TODO(hahnand): onPopupPage to use onDidRemovePage
825+
// ignore: deprecated_member_use
824826
onPopPage: (_, dynamic __) => true,
825827
pages: [
826828
MaterialPage<void>(

0 commit comments

Comments
 (0)