Skip to content

Commit 9d01ea3

Browse files
author
Dane Pilcher
committed
ci: let build pass on lint failures
1 parent dee28d6 commit 9d01ea3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

codebuild_specs/scripts/lint_pr.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,7 @@ if [ -z "$PR_NUM" ]; then
1010
fi
1111

1212
# get PR file list, filter out removed files, filter only JS/TS files, then pass to the linter
13-
curl -fsSL https://api.github.com/repos/$PROJECT_USERNAME/$REPO_NAME/pulls/$PR_NUM/files | jq -r '.[] | select(.status!="removed") | .filename' | grep -E '\.(js|jsx|ts|tsx)$' || true | xargs yarn eslint
13+
# The linter will print the errors but the build will still pass.
14+
# This is intentional because we have thousands of lint errors that will require a separate effort to resolve
15+
curl -fsSL https://api.github.com/repos/$PROJECT_USERNAME/$REPO_NAME/pulls/$PR_NUM/files | jq -r '.[] | select(.status!="removed") | .filename' | grep -E '\.(js|jsx|ts|tsx)$' | xargs yarn eslint || true
1416
set +x

0 commit comments

Comments
 (0)