Support cached results for related media query

[james2doyle]

I have a large form with a bunch of images on it. It looks like when the CuratorPicker is loading the relationship, it checks the DB over and over again for the same model.

these calls were found using Clockwork.

Although I don't quite understand why this happens, it would be nice if this call could be cached or have a method on the field to enable caching.

Any thoughts on this? Maybe I've screwed something up?

[awcodes]

Can you give me a reproduction repo? I've never seen this before.

[james2doyle]

Sorry, but I am working on a tight deadline so I can't make a recreation, but having multiple fields or using the field in a repeater should give the same effect from what I can tell

[awcodes]

Ok, but I'm just not following unless the relationship is off. I want to help, but need to be able to see what is happening to offer more advice / insight. The field uses a whereIn on the ids to retrieve the related models, so it doesn't make sense that it is querying the same model multiple times unless the relationship is off.

[james2doyle]

I understand. If you look where the source of the call is, it is in the relationship where it doesn't use a whereIn, but just a regular where, and then accesses the media on each result.

I think the challenge here is that when the field is repeated, those calls are repeated. So this particular form that I'm building has a repeater with a CuratorPicker inside of it. And so every instance of the field, the relationship gets called.

I don't think fields have a collective store they can pull from, so I'm not really sure what there is to do about this. I ended up extending the field (as MyCuratorPicker) and making my own that had this particular call wrapped in a cache:

$relatedMedia = cache()->remember('MyCuratorPicker:' . implode(':', $query->getBindings()), now()->addMinutes(1), function () use ($query) {
    return $query->get()->map(function ($item) {
        return $item->media->toArray();
    })->toArray();
});

This allowed me to at least have a shared cache between all of the instances of the CuratorPicker on the form.

I feel like a solution in Filament for issues like this would actually having the components lazily loaded so that they don't actually make any calls unless it's visible on the screen. The lazy loading they have now doesn't seem to work that way